Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6d8fff45-012b-b545-0d38-ec38a42326df@linaro.org>
Date:   Mon, 16 May 2022 17:17:00 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH 1/2] dt-bindings: remoteproc: pru: Update bindings for K3
 AM62x SoCs
Content-Language: en-US
To:     Kishon Vijay Abraham I <kishon@ti.com>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Mathieu Poirier <mathieu.poirier@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc:     Suman Anna <s-anna@ti.com>, linux-remoteproc@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220427083509.14458-1-kishon@ti.com>
 <20220427083509.14458-2-kishon@ti.com>
 <7bc6fb49-ae7e-d270-b2a4-a14a1d933d61@linaro.org>
 <de237f2c-6630-2f63-e1da-915ab55a1a7c@ti.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <de237f2c-6630-2f63-e1da-915ab55a1a7c@ti.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 16/05/2022 14:35, Kishon Vijay Abraham I wrote:
> Hi Krzysztof,
> 
> On 28/04/22 11:48, Krzysztof Kozlowski wrote:
>> On 27/04/2022 10:35, Kishon Vijay Abraham I wrote:
>>> Update the PRU remoteproc bindings for the PRU cores on AM62x SoCs.
>>>
>>> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
>>> ---
>>>  Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml
>>> index d7c3a78e37e6..e351550b012c 100644
>>> --- a/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml
>>> +++ b/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml
>>> @@ -47,6 +47,7 @@ properties:
>>>        - ti,j721e-pru    # for PRUs in K3 J721E SoC family
>>>        - ti,j721e-rtu    # for RTUs in K3 J721E SoC family
>>>        - ti,j721e-tx-pru # for Tx_PRUs in K3 J721E SoC family
>>> +      - ti,am625-pru    # for PRUs in K3 AM62x SoC family
>>
>> Looks like out of order.
> 
> yes, this is out of sync with the existing format binding. I'll send a
> patch fixing it.

I meant, you introduce it out-of-order. So this patch should be modified
and new compatible added in some better place.


Best regards,
Krzysztof