Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 16 May 2022 12:44:16 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Takashi Iwai <tiwai@suse.de>
Cc:     Siddh Raman Pant <siddhpant.gh@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Shuah Khan <skhan@linuxfoundation.org>,
        alsa-devel@alsa-project.org, linux-kselftest@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests: alsa: Better error messages
Message-ID: <YoI5EEPjOQPzB6se@sirena.org.uk>
References: <8598037d-0e24-9bc1-3f2c-a2751ec8e871@gmail.com>
 <s5h35h9c3yn.wl-tiwai@suse.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="5M0Q1jZTiTZHriO1"
Content-Disposition: inline
In-Reply-To: <s5h35h9c3yn.wl-tiwai@suse.de>
Precedence: bulk


--5M0Q1jZTiTZHriO1
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, May 16, 2022 at 09:49:04AM +0200, Takashi Iwai wrote:
> On Fri, 13 May 2022 15:40:57 +0200,
> Siddh Raman Pant wrote:

> > This allows for potentially better machine-parsing due to an
> > expected / fixed format. Also because of eyecandy reasons.

> > Whenever possible, errors will start with the name of the
> > offending card/control, separated by the error with colons.

> > Whenever there is a description of an error given, the generated
> > error string from snd_strerror will be (mostly) enclosed in
> > parentheses at the end.

> > Clarity of error messages have been (hopefully) improved.

> But, honestly speaking, I'm not sure whether it worth.
> Although it's possibly a bit more consistent over all texts, I
> don't see significant improvement by this change.

> But I'm fine to apply it, so keep this pending and would like to
> hear from others.

Some of it is probably fine but there's a lot of different changes for a
lot of different styles in here, not all of which look great to me.

--5M0Q1jZTiTZHriO1
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmKCORAACgkQJNaLcl1U
h9DH2wf/V+ceewah5O1Pfdjt0PzOsKcr3er5o2sR3Bn2bVPSb37LtrKyLUXz+PNR
F7JqHqiJRA2ynQUsxWpRKneSLj8rMCh1QPl9k4DJiELy5UzhRiEPoKqaF4qyDW0l
03Ts3YCLGoZ8+jUr+ke67Gz63B5kxmrzoXsHjcp8d/xPMy7mUZYtJqzDN2Vdqxqr
U6iDhB2qN+sL6dw+2TpYs1PvKjrKETlEaieH0Q4CTJSACs/WN5aYFZNoVzmOgwwC
yb+0gevUiAtTZCjgu6Ki+BveQaUa39P3HNoOU9NSdPjkqHt1H7ixIHiaJANzT1xZ
VX5E8TqorRsoIoDtvTeoxdbsF7mfWg==
=xUpY
-----END PGP SIGNATURE-----

--5M0Q1jZTiTZHriO1--