Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <bae4e416-b0e9-31c6-c9d0-df6b5a5fd46f@linux.ibm.com>
Date:   Mon, 16 May 2022 16:21:54 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.0
Subject: Re: [PATCH v9 3/3] s390x: KVM: resetting the Topology-Change-Report
Content-Language: en-US
To:     David Hildenbrand <david@redhat.com>,
        Claudio Imbrenda <imbrenda@linux.ibm.com>
Cc:     kvm@vger.kernel.org, linux-s390@vger.kernel.org,
        linux-kernel@vger.kernel.org, borntraeger@de.ibm.com,
        frankja@linux.ibm.com, cohuck@redhat.com, thuth@redhat.com,
        hca@linux.ibm.com, gor@linux.ibm.com, wintera@linux.ibm.com,
        seiden@linux.ibm.com, nrb@linux.ibm.com
References: <20220506092403.47406-1-pmorel@linux.ibm.com>
 <20220506092403.47406-4-pmorel@linux.ibm.com>
 <76fd0c11-5b9b-0032-183b-54db650f13b1@redhat.com>
 <20220512115250.2e20bfdf@p-imbrenda>
 <70a7d93c-c1b1-fa72-0eb4-02e3e2235f94@redhat.com>
From:   Pierre Morel <pmorel@linux.ibm.com>
In-Reply-To: <70a7d93c-c1b1-fa72-0eb4-02e3e2235f94@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 5/12/22 12:01, David Hildenbrand wrote:
>>>
>>> I think we prefer something like u16 when copying to user space.
>>
>> but then userspace also has to expect a u16, right?
> 
> Yep.
> 

Yes but in fact, inspired by previous discussion I had on the VFIO 
interface, that is the reason why I did prefer an int.
It is much simpler than a u16 and the definition of a bit.

Despite a bit in a u16 is what the s3990 achitecture proposes I thought 
we could make it easier on the KVM/QEMU interface.

But if the discussion stops here, I will do as you both propose change 
to u16 in KVM and userland and add the documentation for the interface.

Regards,
Pierre

-- 
Pierre Morel
IBM Lab Boeblingen