Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <49a7602f-dd79-cac3-e6e0-83c4c41fcd53@kernel.org>
Date:   Mon, 16 May 2022 09:00:45 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH -next v2] vt: defkeymap.c_shipped remove unused variables
Content-Language: en-US
To:     Zhang Jianhua <chris.zjh@huawei.com>, gregkh@linuxfoundation.org
Cc:     linux-kernel@vger.kernel.org
References: <20220513015427.569539-1-chris.zjh@huawei.com>
From:   Jiri Slaby <jirislaby@kernel.org>
In-Reply-To: <20220513015427.569539-1-chris.zjh@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 13. 05. 22, 3:54, Zhang Jianhua wrote:
> The global variables 'funcbufptr' 'funcbufsize' and 'funcbufleft' have
> been initialized but not used, they are redundant and remove them.
> 
> Signed-off-by: Zhang Jianhua <chris.zjh@huawei.com>
> 
> ---
> No code changes since v1, only remove the redundant line "--------" in
> v1 commit message.
> ---
>   drivers/tty/vt/defkeymap.c_shipped | 4 ----

The file header says:
/* Do not edit this file! It was automatically generated by   */
/*    loadkeys --mktable defkeymap.map > defkeymap.c          */

So I'm not sure anyone wants to touch it.

> --- a/drivers/tty/vt/defkeymap.c_shipped
> +++ b/drivers/tty/vt/defkeymap.c_shipped
> @@ -185,10 +185,6 @@ char func_buf[] = {
>   	'\033', '[', 'P', 0,
>   };
>   
> -char *funcbufptr = func_buf;
> -int funcbufsize = sizeof(func_buf);
> -int funcbufleft = 0;          /* space left */
> -
>   char *func_table[MAX_NR_FUNC] = {
>   	func_buf + 0,
>   	func_buf + 5,


-- 
js
suse labs