Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp3116033iob; Mon, 16 May 2022 13:30:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw+ZcEQTLZFkrenrKK7ab1INrQQDE+tHt1kwFGwxnnL/+jN0PT5P+VxzbKYOSTdlGIZLW4y X-Received: by 2002:a62:cf44:0:b0:50d:6d18:17f9 with SMTP id b65-20020a62cf44000000b0050d6d1817f9mr18919914pfg.63.1652733018576; Mon, 16 May 2022 13:30:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652733018; cv=none; d=google.com; s=arc-20160816; b=VL57N6Wo2FEStRLrlqbuS8eFBVVgmejVPnRo0sldQCmAgetWomSzM/p+t6nOtUAr64 vQHKUce8JU7+uGePbPJZJo1KcNXslf5Po0JsAq8/eeIVTcyK+nVMHIE7OBnq1UxpkjRi vwOk8uZqc7sy9wA/UvZNDSj0jM0pFnL3ZDpqvbBGY9RLKOMwLwoL64aMNw3RzlsKAUp7 weBUCzM20TANfxnjePkwX7/lLO2AA2IegC0G2nJXEYvgDwm3U9rILsUB4tQc3cJcqYXV Q4R/YzzcYrhMeeouvk18FXT5ipTImdFsuWfyzvhbQ2Hs6fUpHSTsq7v4JE8EmPpU9YO0 6vnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=SVDUONhVw5ZNRuBJMXJdo69MaC1KSqLGxc/NXSS+Bn4=; b=WQIRfH0sOT+HTYkPu3sKXxaxRKYP4/IlAUlDEEOmk0DrDbV+VaxeKVir/weft0uiNa vf9rG0S0mwJWImawxGAPUFe+AOFaOOF/Ss9uJ0cR5fpWGDhC0TuPTe9pFIOB5BmaiaWo Stv9Tov0EqVqCAENuaLRN+eU/Onr0Td/kQNqfsjyXOJpaS4TYYPc9+CaKAlOGJOkEE6D 6+Z41uxEmIIJEeztGV2iZTxGYkvsY63GT2smlxtMyhF1gigT3UUxbOZ4qe8fFtJusLlj +8I9uh+V9qu9AIuspuUw1zlD5gt72vndIdMnNU2UEKIFXZRiTGekBxDSyd2FnYOsDW+I AUNg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=bitwise.fi Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c134-20020a63358c000000b003c637ec7ce2si14529696pga.840.2022.05.16.13.30.07; Mon, 16 May 2022 13:30:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=bitwise.fi Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243998AbiEPNzb (ORCPT + 99 others); Mon, 16 May 2022 09:55:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240567AbiEPNyi (ORCPT ); Mon, 16 May 2022 09:54:38 -0400 Received: from mail.bitwise.fi (mail.bitwise.fi [109.204.228.163]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33C74377CE; Mon, 16 May 2022 06:54:35 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by mail.bitwise.fi (Postfix) with ESMTP id 8FCA846002A; Mon, 16 May 2022 16:49:01 +0300 (EEST) X-Virus-Scanned: Debian amavisd-new at Received: from mail.bitwise.fi ([127.0.0.1]) by localhost (mustetatti.dmz.bitwise.fi [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mtDHU4i6qgiO; Mon, 16 May 2022 16:48:59 +0300 (EEST) Received: from localhost.net (fw1.dmz.bitwise.fi [192.168.69.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: anssiha) by mail.bitwise.fi (Postfix) with ESMTPSA id 2605A46002B; Mon, 16 May 2022 16:48:57 +0300 (EEST) From: Anssi Hannula To: Jimmy Assarsson Cc: linux-can@vger.kernel.org, Marc Kleine-Budde , linux-kernel@vger.kernel.org Subject: [PATCH 04/12] can: kvaser_usb: Mark Mini PCIe 2xHS as supporting error counters Date: Mon, 16 May 2022 16:47:40 +0300 Message-Id: <20220516134748.3724796-5-anssi.hannula@bitwise.fi> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220516134748.3724796-1-anssi.hannula@bitwise.fi> References: <20220516134748.3724796-1-anssi.hannula@bitwise.fi> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The 0bfd:0124 Kvaser Mini PCI Express 2xHS (FW 4.18.778) seems to support TX/RX error counters in exactly the same way (via unsolicited cmd 106 on bus errors and via cmd 20 when queried with cmd 19) as 0bfd:0017 Kvaser Memorator Professional HS/HS (FW 2.0.50), but only the latter has KVASER_USB_HAS_TXRX_ERRORS set to enable do_get_berr_counter(). Enable error counter retrieval for Kvaser Mini PCI Express 2xHS, too. Fixes: 71873a9b38d1 ("can: kvaser_usb: Add support for more Kvaser Leaf v2 devices") Signed-off-by: Anssi Hannula --- I'm not really sure what KVASER_USB_HAS_TXRX_ERRORS means, exactly, w.r.t. device behavior, though, i.e. how does a device without it behave. drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c b/drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c index 47bff40c36b6..7388fdca9079 100644 --- a/drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c +++ b/drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c @@ -165,7 +165,8 @@ static const struct usb_device_id kvaser_usb_table[] = { { USB_DEVICE(KVASER_VENDOR_ID, USB_MINI_PCIE_HS_PRODUCT_ID) }, { USB_DEVICE(KVASER_VENDOR_ID, USB_LEAF_LIGHT_HS_V2_OEM_PRODUCT_ID) }, { USB_DEVICE(KVASER_VENDOR_ID, USB_USBCAN_LIGHT_2HS_PRODUCT_ID) }, - { USB_DEVICE(KVASER_VENDOR_ID, USB_MINI_PCIE_2HS_PRODUCT_ID) }, + { USB_DEVICE(KVASER_VENDOR_ID, USB_MINI_PCIE_2HS_PRODUCT_ID), + .driver_info = KVASER_USB_HAS_TXRX_ERRORS }, { USB_DEVICE(KVASER_VENDOR_ID, USB_USBCAN_R_V2_PRODUCT_ID) }, { USB_DEVICE(KVASER_VENDOR_ID, USB_LEAF_LIGHT_R_V2_PRODUCT_ID) }, { USB_DEVICE(KVASER_VENDOR_ID, USB_LEAF_LIGHT_HS_V2_OEM2_PRODUCT_ID) }, -- 2.34.1