Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp3122336iob; Mon, 16 May 2022 13:40:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzL9AykhLET1DvvhfI25LQy3cWsw7EEWytAl1X4/NJMVqmRMz5FRFVew2BIyft5G9AiRHn2 X-Received: by 2002:a05:6402:4384:b0:427:b5c0:4bf with SMTP id o4-20020a056402438400b00427b5c004bfmr15137261edc.127.1652733609571; Mon, 16 May 2022 13:40:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652733609; cv=none; d=google.com; s=arc-20160816; b=itso5oHdMTDZAh8IK8XxrbWukXFW38gNbhpHanRK0fZO1+zuLtnLQwtmRcHhSLzyww Tf37umX5xgE34YW3N3vgkdNzhvJb78lZM9AwY9unxcmd0ULzaVSZ/Zw4ZnQk4cDE57NL BoC+EBs3Mq5A8OTqToo7rFOl5Whd1eJfz/TLhBh6f1+TbBaymC0cHEJSQKe4BKoq6Nb7 VzLfwuTEMa6lFEZ6myVlJFJvwHA0yZJtAJuFrpkqiU72G8fjai5gfdJmTqX6kMBJER+j 51bNZIYdH5u8/qbKeY9TqrRq/whm9VZipOGmmr1zqWw7ugEdOY50A5Qnmx/jdAyigQHe b8mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from; bh=ODNi1f09kUan0oKchu45RgFGCsU/nGzfEbE977hyLH0=; b=c7CRiarD+AiLXyS4hzKNdKA/nGpvVF7fR0teyRiRDlXEomUspZRNziKOir8rxgrbGY iFOXeiOPSUSZnlH3WoOpMbcuotUIqH/IDn/hhyWRLG5ivUo1cmXBqd9YS7jHy/Y8Z3b5 H4LkiMOq3+2YhzGHjmoDyA8LidKSP9GLeiMA/CbTCD/ZRTsFQ0JD5zDW95ELpwJk8DS0 EgcyStGWKnUamhVDy3HvM1zBoiNjitvxhsE2Lh/9gywP+oPIKrZuEejhCDLqs0EXXV6k Hc2q+P4L9RXOgbYYyOKaB3Ndd0G3xY3YUoXxfv1g0vSp2EJvYQiCL1KYsEuztfPrCaPf ElbQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ds16-20020a170907725000b006f38bf1700fsi374404ejc.585.2022.05.16.13.39.43; Mon, 16 May 2022 13:40:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236436AbiEOKco (ORCPT + 99 others); Sun, 15 May 2022 06:32:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236312AbiEOKbN (ORCPT ); Sun, 15 May 2022 06:31:13 -0400 Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93B9DAE4B; Sun, 15 May 2022 03:31:12 -0700 (PDT) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4L1JZS1sXJz4xZv; Sun, 15 May 2022 20:31:12 +1000 (AEST) From: Michael Ellerman To: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Laurent Dufour , mpe@ellerman.id.au Cc: Nicholas Piggin , Fabiano Rosas , stable@vger.kernel.org In-Reply-To: <20220504101244.12107-1-ldufour@linux.ibm.com> References: <20220504101244.12107-1-ldufour@linux.ibm.com> Subject: Re: [PATCH v3] powerpc/rtas: Keep MSR[RI] set when calling RTAS Message-Id: <165261054578.1047019.8022784676618367625.b4-ty@ellerman.id.au> Date: Sun, 15 May 2022 20:29:05 +1000 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 4 May 2022 12:12:44 +0200, Laurent Dufour wrote: > RTAS runs in real mode (MSR[DR] and MSR[IR] unset) and in 32bits > big endian mode (MSR[SF,LE] unset). > > The change in MSR is done in enter_rtas() in a relatively complex way, > since the MSR value could be hardcoded. > > Furthermore, a panic has been reported when hitting the watchdog interrupt > while running in RTAS, this leads to the following stack trace: > > [...] Applied to powerpc/next. [1/1] powerpc/rtas: Keep MSR[RI] set when calling RTAS https://git.kernel.org/powerpc/c/b6b1c3ce06ca438eb24e0f45bf0e63ecad0369f5 cheers