Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8142ad15-1fdc-10f8-86f2-fb275cb6cd39@gmail.com>
Date:   Mon, 16 May 2022 22:49:50 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH 0/3] staging: r8188eu: fix checkpatch.pl warnings
Content-Language: en-US
To:     Vihas Makwana <makvihas@gmail.com>,
        Larry Finger <Larry.Finger@lwfinger.net>,
        Phillip Potter <phil@philpotter.co.uk>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Michael Straube <straube.linux@gmail.com>
Cc:     linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
        Dan Carpenter <dan.carpenter@oracle.com>
References: <20220516170306.6008-1-makvihas@gmail.com>
From:   Pavel Skripkin <paskripkin@gmail.com>
In-Reply-To: <20220516170306.6008-1-makvihas@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Vihas,

On 5/16/22 20:03, Vihas Makwana wrote:
> This patchset fixes following checkpatch warning:
>      WARNING: Comparisons should place the constant on the right side of the test
> 
> Compiled tested only.
> 
> Vihas Makwana (3):
>    staging: r8188eu: fix checkpatch warnings in rtw_p2p
>    staging: r8188eu: fix checkpatch warnings in rtw_pwrctrl
>    staging: r8188eu: fix checkpatch warnings in rtw_wlan_util
> 
>   drivers/staging/r8188eu/core/rtw_p2p.c       |  8 ++++----
>   drivers/staging/r8188eu/core/rtw_pwrctrl.c   | 12 ++++++------
>   drivers/staging/r8188eu/core/rtw_wlan_util.c |  2 +-
>   3 files changed, 11 insertions(+), 11 deletions(-)
> 
checkpatch warns about the subjects. See an example for 1/3, but it's 
related to all 3.

> WARNING: A patch subject line should describe the change not the tool that found it
> #4: 
> Subject: [PATCH 1/3] staging: r8188eu: fix checkpatch.pl warnings in rtw_p2p
> 
> total: 0 errors, 1 warnings, 0 checks, 32 lines checked


With regards,
Pavel Skripkin