Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220516104209.1407388-1-hsinyi@chromium.org>
In-Reply-To: <20220516104209.1407388-1-hsinyi@chromium.org>
From:   Hsin-Yi Wang <hsinyi@chromium.org>
Date:   Mon, 16 May 2022 18:47:02 +0800
Message-ID: <CAJMQK-gT6H1BM0i+tLM1ORuf+Tz+GNSJUJdKZOjPYzVJX84u1A@mail.gmail.com>
Subject: Re: [PATCH 0/3] Implement readahead for squashfs
To:     Phillip Lougher <phillip@squashfs.org.uk>,
        Matthew Wilcox <willy@infradead.org>,
        Xiongwei Song <Xiongwei.Song@windriver.com>
Cc:     Zheng Liang <zhengliang6@huawei.com>,
        Zhang Yi <yi.zhang@huawei.com>, Hou Tao <houtao1@huawei.com>,
        Miao Xie <miaoxie@huawei.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        "linux-mm @ kvack . org" <linux-mm@kvack.org>,
        "squashfs-devel @ lists . sourceforge . net" 
        <squashfs-devel@lists.sourceforge.net>,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, May 16, 2022 at 6:42 PM Hsin-Yi Wang <hsinyi@chromium.org> wrote:
>
> Commit c1f6925e1091("mm: put readahead pages in cache earlier") requires
> fs to implement readahead callback. Otherwise there will be a
> performance regression.
>
> Commit 9eec1d897139("squashfs: provide backing_dev_info in order to
> disable read-ahead") mitigates the performance drop issue for squashfs
> by closing readahead for it.
>
> This series implements readahead callback for squashfs. The previous
> discussion are in [1] and [2].
>
> [1] https://lore.kernel.org/all/CAJMQK-g9G6KQmH-V=BRGX0swZji9Wxe_2c7ht-MMAapdFy2pXw@mail.gmail.com/T/
> [2] https://lore.kernel.org/linux-mm/Yn5Yij9pRPCzDozt@casper.infradead.org/t/#m4af4473b94f98a4996cb11756b633a07e5e059d1
>
> Hsin-Yi Wang (3):
>   Revert "squashfs: Convert squashfs to read_folio"
>   Revert "squashfs: provide backing_dev_info in order to disable
>     read-ahead"
>   squashfs: implement readahead
>
>  fs/squashfs/file.c    | 82 +++++++++++++++++++++++++++++++++++++++++--
>  fs/squashfs/super.c   | 33 -----------------
>  fs/squashfs/symlink.c |  5 ++-
>  3 files changed, 81 insertions(+), 39 deletions(-)
>
> --
> 2.36.0.550.gb090851708-goog
>

hi, please ignore this for now. I'll resend a correct cover letter.