Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Veerasenareddy Burru <vburru@marvell.com>
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        Abhijit Ayarekar <aayarekar@marvell.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Satananda Burla <sburla@marvell.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: [EXT] [PATCH 1/2] octeon_ep: Fix a memory leak in the error
 handling path of octep_request_irqs()
Thread-Topic: [EXT] [PATCH 1/2] octeon_ep: Fix a memory leak in the error
 handling path of octep_request_irqs()
Thread-Index: AQHYaHR1Tks+ZqCqYkqTcEMzF5xO+q0iECng
Date:   Mon, 16 May 2022 22:06:59 +0000
Message-ID: <BYAPR18MB2423D0E1D395F112E06015B9CCCF9@BYAPR18MB2423.namprd18.prod.outlook.com>
References: <cover.1652629833.git.christophe.jaillet@wanadoo.fr>
 <78dcfbb5d22328bc83edbfc74af10c3625c54087.1652629833.git.christophe.jaillet@wanadoo.fr>
In-Reply-To: <78dcfbb5d22328bc83edbfc74af10c3625c54087.1652629833.git.christophe.jaillet@wanadoo.fr>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?2QNTpWEgS67eStKpLzd598dfS7EQh9/+2XVtMtVfppgVTfknSwPNNGgy7o1m?=
 =?us-ascii?Q?TlYseSlCwfoNmomDXe3w4otD5//tBoh9LR4M8lFZBAIfBGT8F1ctcSe8Q+/P?=
 =?us-ascii?Q?AM2kmaafNxtWSGvNcXk+VRRTOvIhbUBYfJjA5fz+cp1j6DlZNsb5LT4I8yhl?=
 =?us-ascii?Q?RBgi7qwQWH23LoeRh5AkuBMHzsvn1Bk6E1w5Qlgn6iz/Ey2LK8hHsYBfgAyY?=
 =?us-ascii?Q?KbdN65PqwKHXxAvq7B0O+mTJA2gP6I1h4xVNC8yeczcyMxgezHAOH7y/NHpX?=
 =?us-ascii?Q?oFsJSPglaY9Frat663TpaR/RauMFnz+z0nGmun5gEXSeaVgzV3M+4sWXiXhm?=
 =?us-ascii?Q?aC2lMb3TM7ObY1dJoYrWuwoLslCKFc+WhWLBk/emNwpQtxsuxSf4xatADSCn?=
 =?us-ascii?Q?c+SPsqAVJxrsUbn4OoV1Z6pg8tNI/x/a/HctgUOjcGNOU6XufOd7fqZMWi7c?=
 =?us-ascii?Q?YD9dlZH93u/1Cy+AQZxc7zQyj8BiaGlVBhCvc1PzVfp7VDsGze0bMGNn/JZn?=
 =?us-ascii?Q?M7EY1O4axsO0xXvTKJtIpHH+GuUPAPC1zRXPgXuN7Ed28sJYrmfbG22VGLef?=
 =?us-ascii?Q?ogq6eY5YFU8dajQd8+r3PLlfOKCIae+NkJNmr39SbR7/km0GYqSv2PXkM/xO?=
 =?us-ascii?Q?4N67AC3seOlIifxBk/gqArTz4T2MHGBo9y6Nu6TdqWo3uKGRO8Do3159Z3P+?=
 =?us-ascii?Q?dxQJUekqQ+J6gKiokzVz17N2WbGoCy9EYM3r0bipERE21bOQbHNG53YByTC3?=
 =?us-ascii?Q?U8W2FrM19j7nB1+c8P72YZpgOQbsygdXblCyy/j2tKyO0DdKlDa1GVxU/MDl?=
 =?us-ascii?Q?nQJdbceKjJmGPHYt0xE5+685Wpv1E9To+g5fAVz8J9n+lwFW0bWqCdJw7EHW?=
 =?us-ascii?Q?//16OdQZ7AacggRr84xjvyH+03wyk054TBcJY/wJBWN8FllFe4GLaj6/W2wT?=
 =?us-ascii?Q?tsYRXDpILtqTx9upTeGsSiPvqQNq7DWoeMF8OMan6saI5pKCzmhOEw9TdaLV?=
 =?us-ascii?Q?DudzqDmcELsKW9qv0Q4rq7xQ97rnucklLM7Xb/ERplyeOiQOq4jIN7fgi7Tg?=
 =?us-ascii?Q?T3jut/oGkXk9uk3v0gNjj2mvUo21kSg0jVTnGvaQInDMvvm6Vl3NaT/e2jks?=
 =?us-ascii?Q?FSRL2Ep+Y3Ey16c6rrt27bGDKl7Ck1jt4FvK/aiE/CtHG7RskxD//6uDfKhJ?=
 =?us-ascii?Q?ppu8ZNAxlAweXHzEgGrfTYsyeSmH8zzEJiGbLrKq96xnzXsl/8TJJOkScJOH?=
 =?us-ascii?Q?8oWWpIrUljqtwmwe2mpJK+YSVht0LfbawXPtfbPVYcVHgfMVr08m264Ef8ID?=
 =?us-ascii?Q?wl9kT0qN/+MA5B+qO36rOa9YE5tJeeDtKXbSIfi0UZqXgW3DFsokLjDSBc2m?=
 =?us-ascii?Q?gA+zbaQM6afMin8CbTo9HfRgRCECZ1X26O/r88y40DitJEvn4T6AsT8RRlLO?=
 =?us-ascii?Q?mE03A5HUwqKbYdIkkkO9ob5DdlM3EpkC6q3Ua3cZtVVZ3/9/SETAdnAhMiIA?=
 =?us-ascii?Q?nc9QDi9QW+UWcgw6A/dWIvIMuGKivrqKIfzCyzjnLCF7fZmCi0pIEX9dtFAG?=
 =?us-ascii?Q?iPlZVfxNRJhWOoShV4zuqB6tJWWdg1QJK5ukcbJTM1UXmcn3g0RcRg1edcfu?=
 =?us-ascii?Q?7IP84c5vOKrFIESOqsENGKzMHcnGRN3TjpiZ7j+eXdqJDTVSDtlKGXeM8Hmp?=
 =?us-ascii?Q?Jijclre1kFsc9eGA/yJHaLW29Aa12g3YMoHDWiSH7DAXKqbEeAF25PFG/Gkf?=
 =?us-ascii?Q?11DHU2rwyw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR18MB2423.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 702c20f3-b738-4041-e970-08da378865fb
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 May 2022 22:06:59.2278
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: G8QnfvnTmMuCLFyUvMrNNPFBWNAD7fa5BinERzpEIjeQ4B8kldGbS/qas77YEZpX5au0INeXlAjM2GxWibfJpw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR18MB1068
X-Proofpoint-ORIG-GUID: A-hnpXWXA6xzdi02R4awY8Em1TL6-x1e
X-Proofpoint-GUID: A-hnpXWXA6xzdi02R4awY8Em1TL6-x1e
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514
 definitions=2022-05-16_15,2022-05-16_02,2022-02-23_01
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Sent: Sunday, May 15, 2022 8:57 AM
> To: Veerasenareddy Burru <vburru@marvell.com>; Abhijit Ayarekar
> <aayarekar@marvell.com>; David S. Miller <davem@davemloft.net>; Eric
> Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>;
> Paolo Abeni <pabeni@redhat.com>; Satananda Burla <sburla@marvell.com>
> Cc: linux-kernel@vger.kernel.org; kernel-janitors@vger.kernel.org;
> Christophe JAILLET <christophe.jaillet@wanadoo.fr>;
> netdev@vger.kernel.org
> Subject: [EXT] [PATCH 1/2] octeon_ep: Fix a memory leak in the error
> handling path of octep_request_irqs()
>=20
> External Email
>=20
> ----------------------------------------------------------------------
> 'oct->non_ioq_irq_names' is not freed in the error handling path of
> octep_request_irqs().
>=20
> Add the missing kfree().
>=20
> Fixes: 37d79d059606 ("octeon_ep: add Tx/Rx processing and interrupt
> support")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>  drivers/net/ethernet/marvell/octeon_ep/octep_main.c | 2 ++
>  1 file changed, 2 insertions(+)
>=20
> diff --git a/drivers/net/ethernet/marvell/octeon_ep/octep_main.c
> b/drivers/net/ethernet/marvell/octeon_ep/octep_main.c
> index e020c81f3455..6b60a03574a0 100644
> --- a/drivers/net/ethernet/marvell/octeon_ep/octep_main.c
> +++ b/drivers/net/ethernet/marvell/octeon_ep/octep_main.c
> @@ -267,6 +267,8 @@ static int octep_request_irqs(struct octep_device
> *oct)
>  		--i;
>  		free_irq(oct->msix_entries[i].vector, oct);
>  	}
> +	kfree(oct->non_ioq_irq_names);
> +	oct->non_ioq_irq_names =3D NULL;
Ack
Thanks for the change.

Regards,
Veerasenareddy
>  alloc_err:
>  	return -1;
>  }
> --
> 2.34.1