Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp3285551iob; Mon, 16 May 2022 18:09:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy8MXiHmLRN9NEtqZmhJuDBzO0e4g5l43AxH/6l0SCr97JYttrWVBMuWxjDtWK1zrL3GLu8 X-Received: by 2002:a17:907:2da7:b0:6f4:801c:6c3d with SMTP id gt39-20020a1709072da700b006f4801c6c3dmr16966731ejc.310.1652749748732; Mon, 16 May 2022 18:09:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652749748; cv=none; d=google.com; s=arc-20160816; b=iqsDQzXHQVeraKsObEHpvA2tXqkBR0qsHlwIuGjOfFtShU+/cCARNjcVPecdjFRWBw 3S/ursaRV7iXHmSqlAUXMwe9gPNLKfcPHAO9fGBPu9DW7IUk8ZrDa3ZRUPAHHiSfuyBX hAT/44i+x+YwlC0m6u9NTqP4dK0ZkVFFEL8DA1zgXUHnxjx9/h8N85FCroU30G4Qx38W 5SniAvIXTiYgHO64qWluz/Mxbl2zSKGoER8b4OHnKgAx0g9hXC1KP+aWNTgv9hZcTpW+ LgXNS1XAMqs/QALoNHRzaypsAg23viN3G7uNK7/knHFHOjOmQiJb50CZiygL/grcOWHp DCOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=6fv5cFMe4PovOS1Pb/BPdFLGjCuHN1P8D6Z1ZFKXZt0=; b=WPXW6MtyNG67exXNxI6lSV9ATUvZyO4JbU+6Ta28eatNUUbduZw9bn2jOuNDOWDRP2 QMPVydDDPZt1D4VA8+qu7dkcAvJKTAZESlpp8LJ8mut38e4bXYfKtjK6yHPR/wJ4bKkn TBfgSOZGg6kDGiTnh2f2Z9a7DBIYeFDzJDpGxIAmb7JxugIcGtDtXxlfmdjF7tIS+SQO V52jXp0J6nQJ/CCy5D9t1+z5aRCDe2tRn/SdF0y7RGZLqSwvxovdodVBQvgssvcJvT5l WVgEGTuSt+CBhKWoUXtGnQWlgZqFArtnz5DXcW9YqkEFO4cySyzYWmFhHzvorMkqbaEf uK2Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ufKsylYr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d33-20020a056402402100b0042824992221si10820965eda.132.2022.05.16.18.08.42; Mon, 16 May 2022 18:09:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ufKsylYr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242805AbiEPUKT (ORCPT + 99 others); Mon, 16 May 2022 16:10:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347246AbiEPT5M (ORCPT ); Mon, 16 May 2022 15:57:12 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B27C24832E; Mon, 16 May 2022 12:49:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 36BF160BB5; Mon, 16 May 2022 19:49:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 40900C34115; Mon, 16 May 2022 19:49:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1652730569; bh=ynx/7QHVVjHV4bOAXzGkWyMuH2sZpWlvcEwXWOxepes=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ufKsylYrUC2JtowH35sc9DR6gmBfdUU/ldCRqn2r98ZYHouRGyzu7sD0XxMRG3nMU bpIHSf2+Evug9+ROwgK4Rt2ZR7mEaooRE6zOWHqVDyI1T0Qm2xY6/Vqv6Nl7fBKWdZ hoWNGGE9JKwORmx24CqLMzKDYYgQxn6Si+6l8ePI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Florian Fainelli , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.15 039/102] net: dsa: bcm_sf2: Fix Wake-on-LAN with mac_link_down() Date: Mon, 16 May 2022 21:36:13 +0200 Message-Id: <20220516193625.122578225@linuxfoundation.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220516193623.989270214@linuxfoundation.org> References: <20220516193623.989270214@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Florian Fainelli [ Upstream commit b7be130c5d52e5224ac7d89568737b37b4c4b785 ] After commit 2d1f90f9ba83 ("net: dsa/bcm_sf2: fix incorrect usage of state->link") the interface suspend path would call our mac_link_down() call back which would forcibly set the link down, thus preventing Wake-on-LAN packets from reaching our management port. Fix this by looking at whether the port is enabled for Wake-on-LAN and not clearing the link status in that case to let packets go through. Fixes: 2d1f90f9ba83 ("net: dsa/bcm_sf2: fix incorrect usage of state->link") Signed-off-by: Florian Fainelli Link: https://lore.kernel.org/r/20220512021731.2494261-1-f.fainelli@gmail.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/dsa/bcm_sf2.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/dsa/bcm_sf2.c b/drivers/net/dsa/bcm_sf2.c index 2e314e3021d8..b3a43a3d90e4 100644 --- a/drivers/net/dsa/bcm_sf2.c +++ b/drivers/net/dsa/bcm_sf2.c @@ -796,6 +796,9 @@ static void bcm_sf2_sw_mac_link_down(struct dsa_switch *ds, int port, struct bcm_sf2_priv *priv = bcm_sf2_to_priv(ds); u32 reg, offset; + if (priv->wol_ports_mask & BIT(port)) + return; + if (port != core_readl(priv, CORE_IMP0_PRT_ID)) { if (priv->type == BCM4908_DEVICE_ID || priv->type == BCM7445_DEVICE_ID) -- 2.35.1