Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp3296587iob; Mon, 16 May 2022 18:30:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwiwduI9icTfxZPnPupjxPC22Bd7GoUI75KoiljklRHPexC8ydafkuX7f/v3hBWZAgHc/Iq X-Received: by 2002:a05:6402:787:b0:42a:a2af:f3f8 with SMTP id d7-20020a056402078700b0042aa2aff3f8mr12835906edy.363.1652751045042; Mon, 16 May 2022 18:30:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652751045; cv=none; d=google.com; s=arc-20160816; b=hWzTkZIjFWSMWCQ5DexBUCRhmwIjemHfoIvh1l/IWgRw4Zoqf2Psv0nq61Qe7GgPl1 ayvWRS0cCj+uHxLoy/IGIz3CJmpAyMM+xloYf4Duod+HKF2NGPhKKbFNs9vMJMiojzO7 Pkw0Uy0rflqOQF0gwenpuGixiw1DQoAavXlzALjHd7n3WRdbIHvGE8JNmGr9qu8yWyie cs4UrrEF1lAGB88x8u7zPtPEok0LMr7W+SxxSBnbm8ChCw+yznughtzTcUMAmCZG3/m4 PexzfkN5r9+D889nmANZ3mdlhPMwlObfiLEW/XL/XOGmugwYRCfQGdgXV2cdRS65Um9R coRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ReVnn3HqMKvp8FevSSBeXT8CJ13/GLgAjNjJ2uapLAw=; b=A+85gHfKIYKjmGE7q7i0okXuCZthxwsUnb2j9X9BZN8KSHPClV39lQa6NuRMVlALVR 7qnZmT57vkuTljIRJXDfbp5G/z0BDMYDJZbkMChLQId9+WUpSbyD9IcW3qdFpHdyjAZu fF6ofko8YVUdE1RZGeS2slaxZwLzoWE7F+/UXaKJZM2fbXC885Tngv2mIunkl44PMAaC 6g8wBdbN9QDnEwaPRH9tmSm6uZAH69vhRvnEmXBFEMs8KKv7yX3JCogt3G99vXwiaUt6 19UcAjVNokdrNth56xNNQhGIzZsJ5/yCv6ZSzowBIjIqqdaMOYGW6b1dJf9WQZmpuJAy 1Xmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=BaIBwsnl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i3-20020a170906444300b006df76385e67si920872ejp.775.2022.05.16.18.30.19; Mon, 16 May 2022 18:30:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=BaIBwsnl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350458AbiEPXuF (ORCPT + 99 others); Mon, 16 May 2022 19:50:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349256AbiEPXtu (ORCPT ); Mon, 16 May 2022 19:49:50 -0400 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 03D7C42A01; Mon, 16 May 2022 16:49:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652744987; x=1684280987; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=0mOPfpBUiRzI5SkqjRRFXG0YBOoQLfvYPFjhx2Jgt+Y=; b=BaIBwsnlaFck1uoLbv9CbTGXGOiLj4OFQUXONfbG/JkuZNUtiqm13W9Q l/VacZoKwSs7OvVa0cD/jVqP9XpZxOzcSZ4JUkafdWNpqHFmlthgTM9hW Q4a+RhRBaDurj7MmW4SdZSaGmP4vdiJJ/7WikTYxdu9f/4oKATS0cbDQZ hw2XxirgcIz8D3vDI1f45u66hfwqkTqGSz++/YvpFocgTVLKN2FVM7zsw yobv5Cnh2uA7jHExNFjERxNfcFoIcHVoM8i4eWbs0TDPsTGkc6slRYlgW hmW8Wy5l6tJZWTXLf40ailTsncgXUKhHVGdUAhydbu2NJnyjsi2+2bLOX w==; X-IronPort-AV: E=McAfee;i="6400,9594,10349"; a="357408347" X-IronPort-AV: E=Sophos;i="5.91,231,1647327600"; d="scan'208";a="357408347" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 May 2022 16:49:47 -0700 X-IronPort-AV: E=Sophos;i="5.91,231,1647327600"; d="scan'208";a="522688219" Received: from rhweight-mobl.amr.corp.intel.com (HELO rhweight-mobl.ra.intel.com) ([10.209.36.153]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 May 2022 16:49:47 -0700 From: Russ Weight To: mdf@kernel.org, hao.wu@intel.com, yilun.xu@intel.com, lee.jones@linaro.org, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org Cc: trix@redhat.com, marpagan@redhat.com, lgoncalv@redhat.com, matthew.gerlach@linux.intel.com, basheer.ahmed.muddebihal@intel.com, tianfei.zhang@intel.com, Russ Weight Subject: [PATCH v20 3/5] fpga: m10bmc-sec: expose max10 flash update count Date: Mon, 16 May 2022 16:49:39 -0700 Message-Id: <20220516234941.592886-4-russell.h.weight@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220516234941.592886-1-russell.h.weight@intel.com> References: <20220516234941.592886-1-russell.h.weight@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Extend the MAX10 BMC Secure Update driver to provide a sysfs file to expose the flash update count. Signed-off-by: Russ Weight Reviewed-by: Tom Rix --- v20: - No change v19: - Change "card bmc" naming back to "m10 bmc" naming to be consistent with the parent driver. v18: - No change v17: - Update the Date and KernelVersion for the ABI documentation to Jul 2022 and 5.19 respectively. - Change "m10bmc" in symbol names to "cardbmc" to reflect the fact that the future devices will not necessarily use the MAX10. v16: - No Change v15: - Updated the Dates and KernelVersions in the ABI documentation v14: - No change v13: - Updated ABI documentation date and kernel version v12: - Updated Date and KernelVersion fields in ABI documentation v11: - No change v10: - Changed the path expression in the sysfs documentation to replace the n3000 reference with something more generic to accomodate other devices that use the same driver. v9: - Rebased to 5.12-rc2 next - Updated Date and KernelVersion in ABI documentation v8: - Previously patch 3/6, otherwise no change v7: - Updated Date and KernelVersion in ABI documentation v6: - Changed flash_count_show() parameter list to achieve reverse-christmas tree format. - Added WARN_ON() call for (FLASH_COUNT_SIZE / stride) to ensure that the proper count is passed to regmap_bulk_read(). v5: - Renamed sysfs node user_flash_count to flash_count and updated the sysfs documentation accordingly. v4: - Moved the sysfs file for displaying the flash count from the FPGA Security Manager class driver to here. The m10bmc_user_flash_count() function is removed and the functionality is moved into a user_flash_count_show() function. - Added ABI documentation for the new sysfs entry v3: - Changed: iops -> sops, imgr -> smgr, IFPGA_ -> FPGA_, ifpga_ to fpga_ - Changed "MAX10 BMC Secure Engine driver" to "MAX10 BMC Secure Update driver" - Removed wrapper functions (m10bmc_raw_*, m10bmc_sys_*). The underlying functions are now called directly. v2: - Renamed get_qspi_flash_count() to m10bmc_user_flash_count() - Minor code cleanup per review comments - Added m10bmc_ prefix to functions in m10bmc_iops structure --- .../sysfs-driver-intel-m10-bmc-sec-update | 8 +++++ drivers/fpga/intel-m10-bmc-sec-update.c | 36 +++++++++++++++++++ 2 files changed, 44 insertions(+) diff --git a/Documentation/ABI/testing/sysfs-driver-intel-m10-bmc-sec-update b/Documentation/ABI/testing/sysfs-driver-intel-m10-bmc-sec-update index 2bb271695e14..1132e39b2125 100644 --- a/Documentation/ABI/testing/sysfs-driver-intel-m10-bmc-sec-update +++ b/Documentation/ABI/testing/sysfs-driver-intel-m10-bmc-sec-update @@ -27,3 +27,11 @@ Description: Read only. Returns the root entry hash for the BMC image "hash not programmed". This file is only visible if the underlying device supports it. Format: string. + +What: /sys/bus/platform/drivers/intel-m10bmc-sec-update/.../security/flash_count +Date: Jul 2022 +KernelVersion: 5.19 +Contact: Russ Weight +Description: Read only. Returns number of times the secure update + staging area has been flashed. + Format: "%u". diff --git a/drivers/fpga/intel-m10-bmc-sec-update.c b/drivers/fpga/intel-m10-bmc-sec-update.c index f9f39d2cfe5b..3f183202de3b 100644 --- a/drivers/fpga/intel-m10-bmc-sec-update.c +++ b/drivers/fpga/intel-m10-bmc-sec-update.c @@ -78,7 +78,43 @@ DEVICE_ATTR_SEC_REH_RO(bmc, BMC_PROG_MAGIC, BMC_PROG_ADDR, BMC_REH_ADDR); DEVICE_ATTR_SEC_REH_RO(sr, SR_PROG_MAGIC, SR_PROG_ADDR, SR_REH_ADDR); DEVICE_ATTR_SEC_REH_RO(pr, PR_PROG_MAGIC, PR_PROG_ADDR, PR_REH_ADDR); +#define FLASH_COUNT_SIZE 4096 /* count stored as inverted bit vector */ + +static ssize_t flash_count_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct m10bmc_sec *sec = dev_get_drvdata(dev); + unsigned int stride, num_bits; + u8 *flash_buf; + int cnt, ret; + + stride = regmap_get_reg_stride(sec->m10bmc->regmap); + num_bits = FLASH_COUNT_SIZE * 8; + + flash_buf = kmalloc(FLASH_COUNT_SIZE, GFP_KERNEL); + if (!flash_buf) + return -ENOMEM; + + WARN_ON(FLASH_COUNT_SIZE % stride); + ret = regmap_bulk_read(sec->m10bmc->regmap, STAGING_FLASH_COUNT, + flash_buf, FLASH_COUNT_SIZE / stride); + if (ret) { + dev_err(sec->dev, + "failed to read flash count: %x cnt %x: %d\n", + STAGING_FLASH_COUNT, FLASH_COUNT_SIZE / stride, ret); + goto exit_free; + } + cnt = num_bits - bitmap_weight((unsigned long *)flash_buf, num_bits); + +exit_free: + kfree(flash_buf); + + return ret ? : sysfs_emit(buf, "%u\n", cnt); +} +static DEVICE_ATTR_RO(flash_count); + static struct attribute *m10bmc_security_attrs[] = { + &dev_attr_flash_count.attr, &dev_attr_bmc_root_entry_hash.attr, &dev_attr_sr_root_entry_hash.attr, &dev_attr_pr_root_entry_hash.attr, -- 2.25.1