Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp3298318iob; Mon, 16 May 2022 18:33:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwW8z0vQ+C7pGkt6JbAZPeIoiF1ggUhsMsjZWJ3sIb3GSJBTSLsVqJHlWHkcxeN9wm0mCK4 X-Received: by 2002:a05:6402:26d6:b0:428:c30:3a45 with SMTP id x22-20020a05640226d600b004280c303a45mr16337909edd.210.1652751217576; Mon, 16 May 2022 18:33:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652751217; cv=none; d=google.com; s=arc-20160816; b=JqEr8Cem1hsFNOzdcx0Ygho++q5Kx6pmJttto3SD0r5eQbGhT9bxTB7OridNEx1T3J /J0wpFrMylL9jj9I+yAtqTlTaWyE/J8V09efIe5k9lkWvL72h5sMiIVdii4y6cHfc5Ho vd9BJ2LoQpu9nBmWZnCIDMRecr6acVzAaM4Bf7a2Y0B5xqQAGsup0jCH3Qnx5o65js6i M1HIbDA/hFqCoP0eM47Yw1wzk1WP8dxHIOi0fvogyBI3irZpVYs2LG05zfMO4E/J0P/P 40fsRyoemW3vBkeiiD5gdZLE52/w20pDYOxt5sxKJ0BKugZTTdrkMS8k2QALj480hKld lPsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=yZewY/IE7fi7d7OzlqnHQnD7E+e1MZnu2ndmyw6ZdyE=; b=d3nLwYrKnMFfZUIGVQtOTf5em1pCUKeyr7Tpvq9ZAC3+60MWjzbAfrd7YXuPLwspC6 mINmKxIlJxV6EK/pvV7J/HsOtqlfkIhLvMIQXbZXe8hoc5rTdViZ7Ak3uUaRFXnhXO2P WCUGthN61PIzvc1wbOfRnZlOURJqGV5WXKaZBgCmHXUKro0APGmh3tTVIBlCFXXjFl2Q KlVvSkEROjK7lkFbMQcVGFB5CC7jOd6HzZnJOGWO5DWm+U8D9IG15aAwT3DsNzGBHVwA g8ggJo8Kjxx9a89r3jIhvERYPmJsAx/5E8rfZ9wl4QYO7xKww+ZuhcH7KTc1mUOoJBr1 dW6w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kDBPpVAW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b6-20020aa7dc06000000b0042407dd9dc1si10851991edu.209.2022.05.16.18.33.12; Mon, 16 May 2022 18:33:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kDBPpVAW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239227AbiEPLrS (ORCPT + 99 others); Mon, 16 May 2022 07:47:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236114AbiEPLrP (ORCPT ); Mon, 16 May 2022 07:47:15 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1961831B; Mon, 16 May 2022 04:47:15 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A5ECD61015; Mon, 16 May 2022 11:47:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0825AC385B8; Mon, 16 May 2022 11:47:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652701634; bh=A23pfhdPVoKFYVSK02SQZTwQCJVPjr8lpcsjffIrKuQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kDBPpVAWItdh/Fj5ceigYM4amRcZ3gblDQYFBDYY1oqEVbonkr5cef+Ihvaw4nmxh +o7KhGEeVCOO4ONJ3294fkrj7DB6d8deLz+noH4q81taDe1GZRbp9ReW0dYflP5dr1 mI6fFepkysVs7GLnA0v3pfAncPsPDxHByjRsbCrrLmpIQ4NWn1haii4XM2/TjgsAZk kiKxVan3RRaf0onDz3n0W2VFXdJBk+/iYQIlk7zMhp5LIxlvJ2M225Ac+jLVfkuRf9 SbxLhyvyDoE0ciBAjSApkqrObDFJMHNNC+X7mG2AgebMVg6uG//GI1hkZ4zqnEe4Eu qViZojmOqGjgg== Date: Mon, 16 May 2022 13:47:08 +0200 From: Christian Brauner To: Vasily Averin Cc: Jan Kara , Alexander Viro , kernel@openvz.org, linux-kernel@vger.kernel.org, Amir Goldstein , Matthew Bobrowski , linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] sparse: use force attribute for fmode_t casts Message-ID: <20220516114708.liw6sltketcahpkl@wittgenstein> References: <1eb3b298-4f7e-32ad-74ae-12044ed637ed@openvz.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1eb3b298-4f7e-32ad-74ae-12044ed637ed@openvz.org> X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 14, 2022 at 01:22:28PM +0300, Vasily Averin wrote: > Fixes sparce warnings: > fs/notify/fanotify/fanotify_user.c:267:63: sparse: > warning: restricted fmode_t degrades to integer > fs/notify/fanotify/fanotify_user.c:1351:28: sparse: > warning: restricted fmode_t degrades to integer > fs/proc/base.c:2240:25: sparse: warning: cast to restricted fmode_t > fs/proc/base.c:2297:42: sparse: warning: cast from restricted fmode_t > fs/proc/base.c:2394:48: sparse: warning: cast from restricted fmode_t > fs/open.c:1024:21: sparse: warning: restricted fmode_t degrades to integer > > Signed-off-by: Vasily Averin > --- > fs/notify/fanotify/fanotify_user.c | 4 ++-- > fs/open.c | 2 +- Looks good to me, Reviewed-by: Christian Brauner (Microsoft)