Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp3314802iob; Mon, 16 May 2022 19:06:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyz7sv/8irIEPxM7rl2LBTm6skqMyBy7BAkD8NFVP1pOG8AY2hOZ8WMCcQx/SomMJTZ0B9p X-Received: by 2002:a17:90a:8407:b0:1d9:ab62:bd3c with SMTP id j7-20020a17090a840700b001d9ab62bd3cmr22374734pjn.139.1652753213059; Mon, 16 May 2022 19:06:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652753213; cv=none; d=google.com; s=arc-20160816; b=Bosi6SDY3VPn72HGe/eRS4/FWOxHwmOtiWBEQyxKPHz3TA6DxbTc8RTOwOHaosHHb8 niIGi+hXC4vmx+SYNQQeh46JW5I4VS/Ikc6rP4/n9XaMX3YibE7l5sYJDVxS6aIchHb/ DR9kMqXO9nWjXKGLF9a+Q3RsDPf8PEkieiBOTMAM9mW8TlzGzJusb5gB7TaTXv8N6KAh bR5iZNylcmgpFdrxEY5NRQQAY5YMvLAYOFkaHxcs+BtlrTAkQtx+1UhyMaSG3d3Od2Ou CY/ibG/AiJBkS3nvDA4AiSjBnCB1dpdGunyH101pZVkdS7aMm0TD+XkzdlOv8tqlDv/C gpiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=u3BQLBAhMh5KcC2xVyn/yDRSfkbvmpAQO9GHzgQC9mw=; b=MQdoSDtCBAZp5KkaLPDwkuS1qpnro5sXws80hGA93MP/MOSD6hVwPkh6vaTX5JoHYD Mjz8HkU1Ru3lsCBpF5cZECo90h2c03FDMpb9NvJNZ1C+/Y9E5cNqdZLCjpfNVwDGmO8z +wD33c6C+7balAS6wPQvLtnVQT5LrMYy+HF3Cb9E9bSPto6MoBN1OYa5zEkDhFgEAktE QcJfSAv1Dw0jumRTlxDXjdCW3Reh4GAQfcHo/CR/pmz/2xf0rP/aW1mWuER/qDTkkT0q A/DPf70rv1fD01dKgF+gTqweHTtKB03KNpZlh6x/2sPM2AQ/1XR6Lo2j5aYSu6NUQyuU UqOg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=dwk3n0bO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t129-20020a632d87000000b003db37953ca2si14305310pgt.577.2022.05.16.19.06.41; Mon, 16 May 2022 19:06:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=dwk3n0bO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240704AbiEPUJ6 (ORCPT + 99 others); Mon, 16 May 2022 16:09:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346941AbiEPT4U (ORCPT ); Mon, 16 May 2022 15:56:20 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E22947ACE; Mon, 16 May 2022 12:49:21 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8993560ABE; Mon, 16 May 2022 19:49:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C44CC385AA; Mon, 16 May 2022 19:49:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1652730559; bh=GZmT6UyDgzYGY7TSs0kpvPrztQ8Bwwl5DZCnoBnMDac=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dwk3n0bOcPT1ibDGtrMYlHyWevz3Pxj4OTFN7NoAnvFwjefN0LByX6AZ3JGWQJNB5 8fSUQqzQlpf9Sv/wTR3JFl5CjOeqKD+zGevT+FLMM2jFBgszuzAn9FpL3nOeF0GdTW iFMaSDYBOWYsVHmBymc4qaAXC4uv5R8Pedv9FI3M= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Florian Fainelli , Stefan Wahren , Paolo Abeni , Sasha Levin Subject: [PATCH 5.15 037/102] net: bcmgenet: Check for Wake-on-LAN interrupt probe deferral Date: Mon, 16 May 2022 21:36:11 +0200 Message-Id: <20220516193625.065740411@linuxfoundation.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220516193623.989270214@linuxfoundation.org> References: <20220516193623.989270214@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Florian Fainelli [ Upstream commit 6b77c06655b8a749c1a3d9ebc51e9717003f7e5a ] The interrupt controller supplying the Wake-on-LAN interrupt line maybe modular on some platforms (irq-bcm7038-l1.c) and might be probed at a later time than the GENET driver. We need to specifically check for -EPROBE_DEFER and propagate that error to ensure that we eventually fetch the interrupt descriptor. Fixes: 9deb48b53e7f ("bcmgenet: add WOL IRQ check") Fixes: 5b1f0e62941b ("net: bcmgenet: Avoid touching non-existent interrupt") Signed-off-by: Florian Fainelli Reviewed-by: Stefan Wahren Link: https://lore.kernel.org/r/20220511031752.2245566-1-f.fainelli@gmail.com Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c index 8bcc39b1575c..ea1391753752 100644 --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c @@ -3950,6 +3950,10 @@ static int bcmgenet_probe(struct platform_device *pdev) goto err; } priv->wol_irq = platform_get_irq_optional(pdev, 2); + if (priv->wol_irq == -EPROBE_DEFER) { + err = priv->wol_irq; + goto err; + } priv->base = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(priv->base)) { -- 2.35.1