Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 16 May 2022 21:21:31 +0200
User-Agent: K-9 Mail for Android
In-Reply-To: <20220516173537.GA2942634-robh@kernel.org>
References: <20220514115946.8858-1-linux@fw-web.de> <20220514115946.8858-2-linux@fw-web.de> <1652570081.002742.3276245.nullmailer@robh.at.kernel.org> <trinity-02ad648c-f6f8-4383-b389-a0578d5a02d2-1652615387162@3c-app-gmx-bap15> <20220516173537.GA2942634-robh@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: Re: [RFC v3 1/5] dt-bindings: phy: rockchip: add PCIe v3 phy
Reply-to: frank-w@public-files.de
To:     Rob Herring <robh@kernel.org>
CC:     Frank Wunderlich <linux@fw-web.de>,
        Michael Riesch <michael.riesch@wolfvision.net>,
        Vinod Koul <vkoul@kernel.org>,
        Johan Jonker <jbx6244@gmail.com>,
        linux-rockchip@lists.infradead.org, linux-pci@vger.kernel.org,
        Kishon Vijay Abraham I <kishon@ti.com>,
        linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
        Bjorn Helgaas <bhelgaas@google.com>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Peter Geis <pgwipeout@gmail.com>,
        Heiko Stuebner <heiko@sntech.de>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= <kw@linux.com>
From:   Frank Wunderlich <frank-w@public-files.de>
Message-ID: <9496CAFB-6CB6-4BDA-A539-3A6E1B562299@public-files.de>
Precedence: bulk

Am 16=2E Mai 2022 19:35:37 MESZ schrieb Rob Herring <robh@kernel=2Eorg>:
>On Sun, May 15, 2022 at 01:49:47PM +0200, Frank Wunderlich wrote:
>> Hi
>>=20
>> > Gesendet: Sonntag, 15=2E Mai 2022 um 01:14 Uhr
>> > Von: "Rob Herring" <robh@kernel=2Eorg>
>>=20
>> > On Sat, 14 May 2022 13:59:42 +0200, Frank Wunderlich wrote:

>Documentation/devicetree/bindings/phy/rockchip,pcie3-phy=2Eyaml
>> > >
>> >
>> > My bot found errors running 'make DT_CHECKER_FLAGS=3D-m
>dt_binding_check'
>> > on your patch (DT_CHECKER_FLAGS is new in v5=2E13):
>> >
>> > yamllint warnings/errors:
>> >
>> > dtschema/dtc warnings/errors:
>> >
>/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/=
rockchip,pcie3-phy=2Eyaml:
>properties:clock-names: 'oneOf' conditional failed, one must be fixed:
>> > 	[{'const': 'refclk_m'}, {'const': 'refclk_n'}, {'const': 'pclk'}]
>is too long
>> > 	[{'const': 'refclk_m'}, {'const': 'refclk_n'}, {'const': 'pclk'}]
>is too short
>> > 	False schema does not allow 3
>> > 	1 was expected
>> > 	3 is greater than the maximum of 2
>> > 	hint: "minItems" is only needed if less than the "items" list
>length
>> > 	from schema $id: http://devicetree=2Eorg/meta-schemas/items=2Eyaml#
>> >
>/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/=
rockchip,pcie3-phy=2Eyaml:
>ignoring, error in schema: properties: clock-names
>> >
>Documentation/devicetree/bindings/phy/rockchip,pcie3-phy=2Eexample=2Edtb:=
0:0:
>/example-0/phy@fe8c0000: failed to match any schema with compatible:
>['rockchip,rk3568-pcie3-phy']
>>=20
>> seems this is fixed when i remove the "minItems: 3" from clock names=20
>> (which is already fixed length because of the list)=2E
>
>Yes=2E
>
>> needed to change type of lane-map to this:
>>=20
>> $ref: /schemas/types=2Eyaml#/definitions/uint8-array
>
>Why? That's not a standard property though, so needs a 'rockchip'=20
>prefix=2E Though maybe a common property would be appropriate here=2E

Originally it was a bool property named "rockchip,bifurcation" and we chan=
ged it (after comments) to be a more generic property "lane-map" that can b=
e re-used on other vendors/controllers/phys=2E

Driver reads as u8 array and range is small enough for u8 even if used for=
 larger controllers (e=2Eg=2E PCIe x16)=2E

>> then it looks clean for it=2E=2E=2E=2E
>>=20
>> -m causes many errors unrelated to this schema-file even if i pass
>>
>DT_SCHEMA_FILES=3DDocumentation/devicetree/bindings/phy/rockchip,pcie3-ph=
y=2Eyaml
>
>The fix is fixing the remaining 40 or so '-m' errors=2E

So now clean for you(r bot), too? Did only get a bunch of other unrelated =
messages=2E

>Rob


regards Frank