Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 16 May 2022 09:58:40 +0200
Message-ID: <s5hk0alkixb.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Vitaly Rodionov <vitalyr@opensource.cirrus.com>
Cc:     Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        Mark Brown <broonie@kernel.org>, <alsa-devel@alsa-project.org>,
        <patches@opensource.cirrus.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 00/26] *ALSA: hda: cirrus: Add initial DSP support and firmware loading
In-Reply-To: <20220509214703.4482-1-vitalyr@opensource.cirrus.com>
References: <20220509214703.4482-1-vitalyr@opensource.cirrus.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Mon, 09 May 2022 23:46:37 +0200,
Vitaly Rodionov wrote:
> 
> The CS35L41 Amplifier contains a DSP, capable of running firmware.
> The firmware can run algorithms such as Speaker Protection, to ensure
> that playback at high gains do not harm the speakers.
> Adding support for CS35L41 firmware into the CS35L41 HDA driver also
> allows us to support several extra features, such as hiberation 
> and interrupts.
> 
> The chain adds support in stages:
> - General fixes to improve generalization and code re-use inside
>   the CS35L41 HDA driver.
> - Add support for interrupts into the driver, which is required
>   for complete support of the firmware.
> - Refactor ASoC CS35L41 code which deals with firmware to allow
>   for code re-use inside the CS35L41 HDA driver.
> - Add support for loading firmware and tuning files from file system,
>   and creating alsa controls to control it.
> - Support firmware load paths for different hardware systems.
> - Support suspend/resume in the driver when using firmware. The firmware
>   supports hibernation, which allows the CS35L41 to drop into a low
>   power mode during suspend.
> - Support the ability to unload firmware, swap and reload the firmware.
>   This is to allow different firmware to run during calibration.
> 
> The intended use-case is to load the firmware once on boot, and the driver
> autmatically tries to load the firmware after it binds to the HDA driver.
> This behaviour can be switched off using a kconfig, if desired.
> 
> Stefan Binding (25):
>   ALSA: hda: cs35l41: Fix error in spi cs35l41 hda driver name
>   ALSA: hda: cs35l41: Set Speaker Position for CLSA0100 Laptop
>   ALSA: hda: cs35l41: Remove Set Channel Map api from binding
>   ALSA: hda: cs35l41: Add Support for Interrupts
>   ALSA: hda: cs35l41: Enable GPIO2 Interrupt for CLSA0100 laptops
>   ASoC: cs35l41: Move cs35l41_set_cspl_mbox_cmd to shared code
>   ASoC: cs35l41: Move cs35l41 fs errata into shared code
>   ASoC: cs35l41: Move cs_dsp config struct into shared code
>   ALSA: hda: cs35l41: Add Amp Name based on channel and index
>   ALSA: hda: hda_cs_dsp_ctl: Add Library to support CS_DSP ALSA controls
>   ALSA: hda: hda_cs_dsp_ctl: Add apis to write the controls directly
>   ALSA: hda: cs35l41: Save codec object inside component struct
>   ALSA: hda: cs35l41: Save Subsystem ID inside CS35L41 Driver
>   ALSA: hda: cs35l41: Support reading subsystem id from ACPI
>   ALSA: hda: cs35l41: Support multiple load paths for firmware
>   ALSA: hda: cs35l41: Support Speaker ID for laptops
>   ASoC: cs35l41: Move cs35l41 exit hibernate function into shared code
>   ASoC: cs35l41: Do not print error when waking from hibernation
>   ASoC: cs35l41: Add common cs35l41 enter hibernate function
>   ALSA: hda: cs35l41: Support Hibernation during Suspend
>   ALSA: hda: cs35l41: Read Speaker Calibration data from UEFI variables
>   ALSA: hda: hda_cs_dsp_ctl: Add fw id strings
>   ALSA: hda: cs35l41: Add defaulted values into dsp bypass config
>     sequence
>   ALSA: hda: cs35l41: Support Firmware switching and reloading
>   ALSA: hda: cs35l41: Add kernel config to disable firmware autoload
> 
> Vitaly Rodionov (1):
>   ALSA: hda: cs35l41: Add initial DSP support and firmware loading

Now I applied only partially from 01 to 09 out of 26 patches.
Please resubmit the rest after brushing up and fixes.


thanks,

Takashi