Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6720e18e-0638-7f2f-533e-beca8a990404@linux.ibm.com>
Date:   Mon, 16 May 2022 13:50:48 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Reply-To: jjherne@linux.ibm.com
Subject: Re: [PATCH v19 05/20] s390/vfio-ap: refresh guest's APCB by filtering
 AP resources assigned to mdev
Content-Language: en-US
To:     Tony Krowiak <akrowiak@linux.ibm.com>, linux-s390@vger.kernel.org,
        linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc:     freude@linux.ibm.com, borntraeger@de.ibm.com, cohuck@redhat.com,
        mjrosato@linux.ibm.com, pasic@linux.ibm.com,
        alex.williamson@redhat.com, kwankhede@nvidia.com,
        fiuczy@linux.ibm.com
References: <20220404221039.1272245-1-akrowiak@linux.ibm.com>
 <20220404221039.1272245-6-akrowiak@linux.ibm.com>
 <fc760c00-0559-68d8-fd2d-f29e014a6685@linux.ibm.com>
 <62668577-bf0c-eda5-56a0-9ca56e5f9ce6@linux.ibm.com>
From:   "Jason J. Herne" <jjherne@linux.ibm.com>
Organization: IBM
In-Reply-To: <62668577-bf0c-eda5-56a0-9ca56e5f9ce6@linux.ibm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/16/22 13:13, Tony Krowiak wrote:
> 
> 
> On 5/16/22 12:36 PM, Jason J. Herne wrote:
>> On 4/4/22 18:10, Tony Krowiak wrote:
>>> |@@ -1306,8 +1392,6 @@ static int vfio_ap_mdev_set_kvm(struct ap_matrix_mdev 
>>> *matrix_mdev, kvm_get_kvm(kvm); matrix_mdev->kvm = kvm; - 
>>> memcpy(&matrix_mdev->shadow_apcb, &matrix_mdev->matrix, - sizeof(struct ap_matrix)); 
>>> kvm_arch_crypto_set_masks(kvm, matrix_mdev->shadow_apcb.apm, 
>>> matrix_mdev->shadow_apcb.aqm, matrix_mdev->shadow_apcb.adm);|
>>
>> This looks like an unrelated change. Does this snippet really belong to this patch?
> 
> It's kind of hard to tell which snippet you are talking about without the patch context, 
> but I assume you are referring to the removal of the memcpy statement in the 
> vfio_ap_mdev_set_kvm() function in which case this snippet belongs with this patch.
> 
> This patch introduces a function that filters the contents of the matrix_mdev->matrix to 
> ensure that the matrix_mdev->shadow_apcb contains only queues that are bound to the 
> vfio_ap device driver. The filtering function is called whenever an adapter, domain or 
> control domain is assigned or unassigned, so it is no longer necessary to copy the 
> contents of matrix_mdev->matrix into matrix_mdev->shadow_apcb before setting the masks in 
> the guest; that will have already been done by the filter function.
> 
> 

I was apparently a little overzealous with my trimming. Yes, you are correct. Thanks for
the explanation.

Reviewed-by: Jason J. Herne <jjherne@linux.ibm.com>


-- 
-- Jason J. Herne (jjherne@linux.ibm.com)