Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Wan Jiabing <wanjiabing@vivo.com>
To:     Patrice Chotard <patrice.chotard@foss.st.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Wan Jiabing <wanjiabing@vivo.com>
Subject: [PATCH] [media] c8sectpfe: Remove unneeded NULL check before clk_disable_unprepare
Date:   Mon, 16 May 2022 21:12:54 +0800
Message-Id: <20220516131254.13816-1-wanjiabing@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?tt74wvKN0pBpdeHGxgqv/cFaSpEHotFmnjiCBxgkfzyAfXBK+2Yx/zZOTDqj?=
 =?us-ascii?Q?IuV2nSO2KASYvSNDTkurVIjTCg1tDdcFSUBA9nVI6fJI+c/CoBtsMgW2j+a4?=
 =?us-ascii?Q?N8/BquQdTpfeU+yWFCoZWg6LruqFtlOoP1JKUPsC+hINwU0yuvJo4QhmFcBJ?=
 =?us-ascii?Q?QLwkdSG59LcvLPcB99iAIac+7CkkiJlDcXEpwBlAEfpqwZ8bbFZbW69AC0OK?=
 =?us-ascii?Q?0FCqXQClWMq1VxLgzeBtii+JPjAhddYxW9TIgnCaM17N19CEYabLCRQuLffF?=
 =?us-ascii?Q?AUSkY2ThXPR7rkpBCDzcwsnMYuZ/ZUK5XzhlTChQMTHrXznIZUdUzTXOT4gT?=
 =?us-ascii?Q?qFRyykglv1Kqpw+kCZCJDvp7v/FldkXOCtWqbrwj51jjUtXsnpz0ATfxnpcg?=
 =?us-ascii?Q?wuYYbQrM8s5Jb9o3A2S1lP8oS9gniRFHbcX6v7O/A57yVWVBvYW4eCDA587m?=
 =?us-ascii?Q?06B/qfKXdgmCttI9WWwY4iKgt5E42a8cTJ0FaUVHEeWXM+Zky1smtN9Eq9zC?=
 =?us-ascii?Q?K1BKQyqcaqtkEE9ZRf25xZYlFMEJaugLJMHwtOWkG6azyeBfrjVNNRdcYSCx?=
 =?us-ascii?Q?yE79v22djlWBuiECNXQ3+uO+mqdMXPMwE7sJDNH4lnLbVRQCLj2n7vLrgdtX?=
 =?us-ascii?Q?W0x43EMM91hRE/dGsi4hGw9h6Iv28KU40R+cSJQt9btDeV1tz/XOZckaQKkl?=
 =?us-ascii?Q?hTCTQ0cYRlm/+/Qofey65fTH1bHLc0sXCTst6GNTwpbxVkubLIaKV7FB5+Z8?=
 =?us-ascii?Q?omC31BFQSAp4GNytaBEBNdFw3YjMV1XaSp5uWbzIoN7eOO+DIOe+2A/FtkjT?=
 =?us-ascii?Q?TVOIZ2rRA3Rj0YZp+UsmEDRnVD9BTLpFG75OFgQ1XITa8JFMszM5cKuTxoYA?=
 =?us-ascii?Q?n/6PExeodRDvT0mjfEpcQzaKinh+OTdyeV3JUFBbx8EUiTPNVLqXSExvQRD9?=
 =?us-ascii?Q?sDN6FNfUyK2DLwq+LhOcXyD6C2UXwUctA04TullcxVZLbXrpFrhy3ldfVqpV?=
 =?us-ascii?Q?XP4iH7+CWhXqwRTXBS8W3ox5Jg3xuBfonn5kXn33TNtn6xio5ADL7jBKutfG?=
 =?us-ascii?Q?J+5abG7rJOw/wMsKKpI5ULjDjKMM/afRoTsyVSIgyiJGQJFBZAF+B68p8eLW?=
 =?us-ascii?Q?KPlh2GNvNy5za7qWyvQTQ5bC6BTM1pfEedYnkYgZ5CCaqZYwH1GWhLc7Rpzg?=
 =?us-ascii?Q?ZVRWZ0pjonWTzYlZQgIx+7zPuC44pNeSIZFe1ufFFMGQVN1WlFoUWFfkX+n2?=
 =?us-ascii?Q?ucEHq0qp4NBx9VKqo+EoEPhCLgRGXgxEyiPwJucsGwc4t11iWcaXGQVHYc7w?=
 =?us-ascii?Q?iAobvtWSZFFuMd6ryL/Y3OWNGUox7VMpYkZggQZlYLf9OrjGhZFTCefeJ841?=
 =?us-ascii?Q?VAhSI+0zfwkdByvmEGTqqh4DiqtX088Q4G3zx9PAh28fRSHR+iVJPIiEcq6+?=
 =?us-ascii?Q?ilS0Zas0Y+ThnQz64E/6oTZujA9ohFkXfEq/tRPQ04bjbX7V5iUd/q6sdgFD?=
 =?us-ascii?Q?aaqLw+ZhFpZnjy03dku6R/Fu7KbSl9ytcVidMT8NzWkvCb3Lua89xpP6seKb?=
 =?us-ascii?Q?gOwrSvNuzEDAnG6eneiz5d4gJf3YAie5Vp6zfXORaeeIpWLyzaO7Oi/8KuyM?=
 =?us-ascii?Q?a/OJWXDg4lwZ7i4omxBS8QM4AiuKNRnc7gq0UYpcYirZYf0OussSx/fa/OhN?=
 =?us-ascii?Q?w8RIml4k6vpRmDCR6wtI9QpcH+9MjWL/c63SNawm1i7JZdIQRcBfFqygQPFa?=
 =?us-ascii?Q?loG/YQcIZw=3D=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4eea71ff-9f58-4519-ca01-08da373dd46c
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3367.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2022 13:13:12.5590
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gKcNfipQ8HC2Y5GbOZI13yZvUm1W/g6Hqjv+Mq3HgQcGuzsT8d167HAAGhcgnpKeACig/GQkkpxjc6wCqNhA9w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEYPR06MB5112
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

clk_disable_unprepare() already checks NULL by using IS_ERR_OR_NULL.
Remove unneeded NULL check for fei->c8sectpfeclk.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c b/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c
index 7bb1384e4bad..7d63e56ae14c 100644
--- a/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c
+++ b/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c
@@ -915,8 +915,7 @@ static int c8sectpfe_remove(struct platform_device *pdev)
 	if (readl(fei->io + SYS_OTHER_CLKEN))
 		writel(0, fei->io + SYS_OTHER_CLKEN);
 
-	if (fei->c8sectpfeclk)
-		clk_disable_unprepare(fei->c8sectpfeclk);
+	clk_disable_unprepare(fei->c8sectpfeclk);
 
 	return 0;
 }
-- 
2.36.1