Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp3357098iob; Mon, 16 May 2022 20:32:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzmhW1IMgW8Km1Y+E/kDGdVmnwdLciE0s2MeGcybYcOr/JAqRy08ConHTvaxb7eKM5V7c1V X-Received: by 2002:aa7:cf83:0:b0:42a:c73e:6d86 with SMTP id z3-20020aa7cf83000000b0042ac73e6d86mr1148468edx.251.1652758374086; Mon, 16 May 2022 20:32:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652758374; cv=none; d=google.com; s=arc-20160816; b=PZZcYqJWHhDeosDI6jJSZacqib10/rh/0JDxrmkNyIzmelkC/yO1S5rQN071REaG6I CYJj6PnyWkGjaT38MFpf59hWJknxMhnLNjjmPSWxBjKYmHdSoF7NcnH95BODG/e22YVU wVrxrpum0vi25D2oACP8akgpO/GJs1cTV0XhX+r/raDPw0u3/LIevWDE0fHuBpYcx71w Or4XSfScgenRZhqqmuZUENYBTvYFoOJLf1bMRaNCPcHhUkU3zjRamtkPpVCaJjNbCPjq JM5DU87m3GHY6zIMR9q8CiEqfDjp9lhGw5et4BqQwZ3EJh2c8+yZIa/UyvkRsUdwgt0R DHGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=S5Hm9bCT3N/jL7x8eanz+7tBQhJts5GsVWA5bt/EUP4=; b=Axcb4DXTa3FQ45t3y6ZOKRpgB5hvBWFxrUhe6m4M9advJGiqq5r//VfBC4/zxoKI32 azz7TaJUlVnUHDBRCSbNvQVCYd6earLIUwdhDJ24vgabNXHD1wx/7LF931ANxydRrGxk JNzY6YmBp0zZBzG9BHauBBm3Amv5sB1fnH0fDt1D5egNDs/F9w89ieiHSe+y57ctVkNy TyG29vUQ0rWI13QEwtxQAXxtsTFOgxECG8FaUgoJISuVe5f+yUheq6KhFVNvhu+QaoqR 3vrSy5E0G9hGIGmqRGwS0aQRWNz1awDklbE9z8eR+tD4UUfOZ3wrO1sCR7w67pGw+ZFP OTGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=t0gnbJfj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c12-20020a056402120c00b0041d664093e1si11194425edw.482.2022.05.16.20.32.29; Mon, 16 May 2022 20:32:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=t0gnbJfj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240536AbiEPGx4 (ORCPT + 99 others); Mon, 16 May 2022 02:53:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240528AbiEPGxx (ORCPT ); Mon, 16 May 2022 02:53:53 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9BB2018E10; Sun, 15 May 2022 23:53:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=S5Hm9bCT3N/jL7x8eanz+7tBQhJts5GsVWA5bt/EUP4=; b=t0gnbJfjb+cM2EEEu5YNKmC0B0 Wbs28d6nXw72FjhHV9vS4KCkx1LwKvKUDv2Yh2W2hmUF3Ri+l77IhQwhMxFGE2o/ZGcGzGwQ8o3ls miid00cRCyJfu/kB23wPpw84FdoZONay6/2AK+uYk7g3rpactkcKkXwPO2sGk9NdNv4aKM5xjZfTj iR6bG/yZsBicLWnGXb8Aqgycc91RmCxvP2mfeYaPFDz1rwkvNeMUrh2pC+caXXj/4Msdp0p5VH5oX dGwZz97BadCFNJgrhLnLsf/okpncE5CnJX5lcw/KFBh2iOvDr8gGppv/AVgXSsE/G8YM5loSfQKxP bZygAF2A==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqUc3-006Gaw-Kv; Mon, 16 May 2022 06:53:51 +0000 Date: Sun, 15 May 2022 23:53:51 -0700 From: Christoph Hellwig To: Vasily Averin Cc: Jens Axboe , linux-block@vger.kernel.org, kernel@openvz.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] blk-mq: use force attribute for blk_status_t casts Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org No, no, no. Really, stop these patches that just make things worse now. __force casts are a really bad idea. Please just fix this in a way that does not require casting away these attributes as they are there for a reason!