Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
To:     Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Cc:     dan.carpenter@oracle.com, James Smart <james.smart@broadcom.com>,
        Ram Vegesna <ram.vegesna@broadcom.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Daniel Wagner <dwagner@suse.de>,
        Hannes Reinecke <hare@suse.de>,
        Nathan Chancellor <nathan@kernel.org>,
        Wei Yongjun <weiyongjun1@huawei.com>,
        linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: elx: efct: Remove redundant memset statement
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1wnekq53f.fsf@ca-mkp.ca.oracle.com>
References: <20220505143703.45441-1-harshit.m.mogalapalli@oracle.com>
Date:   Mon, 16 May 2022 22:13:20 -0400
In-Reply-To: <20220505143703.45441-1-harshit.m.mogalapalli@oracle.com>
        (Harshit Mogalapalli's message of "Thu, 5 May 2022 07:36:57 -0700")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?UMWJRSDcM1P6ggz0dZhL+rpk2yt6XPjQoWL+GtNsuWhE82waNT8eT8drZibA?=
 =?us-ascii?Q?Gnp9GY4frZ3dOtd5D0MqMRLastOTTmVOtUAYDS0WXdH91frfI+IHdQPaOySZ?=
 =?us-ascii?Q?UcWkZ8MQqMKN8u+WvqWAKxHG7iprg2wPsmefnQJCYjKlZCVfS316w9LmLpNf?=
 =?us-ascii?Q?KULY32FxHaaf0I98LFd7zxnnrUkCH6QngU19HQJdTeXmWDJk+6MV6TWi7duL?=
 =?us-ascii?Q?tsBpwHhWj4VXL/ixEmI4cq+/y8I73Hx6wD5JDObGaxMYD8p5eWqLEo9diD8P?=
 =?us-ascii?Q?OSANW++3cDB0BrY1nWgDgur1Ba5CZjqJ1DS9gi5ewhy/pxskTZBDUoXPdagH?=
 =?us-ascii?Q?2199UoYzQJAGAZnytkLsrg88X0BtknCyH7moNDlwD2NTDGuvHQ9Sb/ktD5DY?=
 =?us-ascii?Q?PyGH4ZDNnxESZT2/nH4y6ne5kyggEspAM7uN7TNMPIU74K0mDdgPc7mLFn5d?=
 =?us-ascii?Q?EI88+/yYppaZUijUNsIJ4/NT5O8GTCeox8c01aedEVEBh3Vp49H8VhYhPD5W?=
 =?us-ascii?Q?OYuCGhr3ApcyIp7/BipXowLt/nOjCGAInmLvOGpi+cw0ZnHeQ1FdDstfIytJ?=
 =?us-ascii?Q?RYuO5zAnZPAu87B04RJjlM9pMqZYOD3LlX5ZsSGryQC7O3x0GkkVSbV38Wv5?=
 =?us-ascii?Q?eZKm3oB8xX6kuKUhBY7lMEBKVYYfTploPiqsXdTAu6HxnBvr8i9m+sMhUOQz?=
 =?us-ascii?Q?XqhTRCRc3yqxtG9q/yngHrXr9WRZQC6FrfhRSsgxUACRP+VoYNN26FMoyx0g?=
 =?us-ascii?Q?iXcjrmXsQhtj2L5UKymE+VaXjfp0fFeu/M0nO9xoc9R4ZKewhTxHj1iUgJBi?=
 =?us-ascii?Q?5sSi2M2Ie9GVTp+MqCd7Vom62s+hlQg8UCdihc1kXt4fikdux1GThk7Z8eNv?=
 =?us-ascii?Q?6RTTrjhsHCtIE4d1q9pBxSako4oBVdiczLuuRE9QBxYthpjKLtVeL8YhVHs4?=
 =?us-ascii?Q?GNuJIK6ou6x+TODpDGf3AcYdEvawWD3v5J6h6EJLn0Dc92nqmYbhR99x+1AZ?=
 =?us-ascii?Q?0bHv2E+P4M7Yu+VhoCVDzbfC38olmMYxAtEbUM+Y5f5FEqt5s8yrXKcbWhI2?=
 =?us-ascii?Q?WzoPdWbLWqIQ47C5jxvltJIqoSuH0W41bSxFb2mBtcY2hGymPmmzb3Y1/T6N?=
 =?us-ascii?Q?e4SDhruIWzrHlYxA4SCFjZ1gYlh75Ft3d7VJ8l/2RGXoSQN76j28Z+UO7O+d?=
 =?us-ascii?Q?OQCPVAnCkjwmaBun8eOIqPpbAUfK3bmEo82V5E9Yn4J65SjEBhfsvHHirr9Y?=
 =?us-ascii?Q?xRLwGrgh5OhHb9ZGnrPkpEWM5kf1eRFbhSw3fjtQSwx5n9FJJDOmwWEO33Do?=
 =?us-ascii?Q?w0C3boiO7iD0ZEGnnK41lrI98QmaXDc3aVuISpkXvcmCGdrlQSoY7qGkZWut?=
 =?us-ascii?Q?HQjbmCMLoZlW9GXsKrKbZnvkslRevMuvjRaPJ9aArf+2zp+qN4Q2Mo+VWM2p?=
 =?us-ascii?Q?o57e9mWqytnPovqdVVkCmGIMtfJs2dzGUk9F2t3e0yS8W6DYlLnxneMUwf6s?=
 =?us-ascii?Q?fL0QFS2KXwfro7VTntzB9m5TN6zld7x00o3ZX6uc8ms/lM2W0TrIz2QYF/iI?=
 =?us-ascii?Q?dHiBh7jIxddV3OLYCS7Ft4so0r52XYGJPg3qnZd+1hfR/gDpLWVn/+Na80lz?=
 =?us-ascii?Q?OijwlsrFS6Esv5C9Z808XJkBPNKoCGSoaYsAlMqW595zvgwzw5DwjSruC8pk?=
 =?us-ascii?Q?7sa2TFSx27KxwQ/SMVHZb32cRXtIykF/aduWdP8tH2XCiux/ETrqnjHLEfdU?=
 =?us-ascii?Q?Zc1kY73rWUq4VciQ3lW7GCy5r2dx+fg=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d7cfd7d3-e24e-434f-384f-08da37aad1d3
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2022 02:13:23.2157
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZKpN8Zkfk9BFMZYjI+oHT2qbwQ3OkcntWqqIql09sbipiyHMdqBz2WBV89nzzFtQOkOhM3MI55/Cy0mIBgEv6QdD9rMyDoToUSuFVchsyN8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1001MB2291
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-05-16_16:2022-05-16,2022-05-16 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0
 mlxlogscore=805 spamscore=0 suspectscore=0 malwarescore=0 mlxscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2205170010
X-Proofpoint-GUID: YH3Yem_9puyAIS4w_IwuMsQMnrXhhmDo
X-Proofpoint-ORIG-GUID: YH3Yem_9puyAIS4w_IwuMsQMnrXhhmDo
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Harshit,

> As memset of 'bmbx' is immediately followed by a memcpy where 'bmbx'
> is the destination, memset is redundant.

Applied to 5.19/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering