Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp3414759iob; Mon, 16 May 2022 22:29:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwtSi2zIq7sYM+l1GkqaL2lP1gqJW0Z41HcAMF565jTo6lDUHWJle2aWJa0Mhp3KVMwa+pX X-Received: by 2002:a17:90a:cc02:b0:1df:257a:5396 with SMTP id b2-20020a17090acc0200b001df257a5396mr14575610pju.190.1652765390960; Mon, 16 May 2022 22:29:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652765390; cv=none; d=google.com; s=arc-20160816; b=CONjY2KeZmooYanjh+lED1fqtoLzgTp2IXgygGkgMT8kl6X6ucg3pWCLbWW2gSA8qj nUWlvp0qIfrOie52emnno99ptXUsWWIEQZ1/1IcDT7ACnIAFn1mkEbzRQCSnRbisEdnJ 2Y0/g4+QfL2GeoSYgA4i1CWn7I6TSVTv+FMFrSiILOiOSqWbpIYzPiLBBqhDv2Nfc162 g1TZN0VnJDUDvR+6Zlurju4MmNFMuUm3Okj/fO5Llxm1ro6vCwPEyqWIm8cvecfCQXKy hBPUMio8n6qQdRbI4CKqhaNDE1/lynJHDrZLr7yolY+CXxMVVuyXBXlNyZsxuKQb/3SI Zyag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=LzxG8e31/9dLs8daZ6akwgssYCxSHHNm9SeDboAqPew=; b=m/UxRC+dTr4CQw+lieqr1n6MowXZGta1GJmDcU/JBFz7GTk1qn+FVOzM8xL8+DWgOV VOHihS8mRwhOxwPHdOuJ6cXhEnZ/YSBnDr0OxS8mkSPIrPX6EDySSdWVWv68zZ6erSuG DadAZ/uaO9jpaEERGz0EA9ap84+MzAzcr/7SzvwzPjPJfGwFAcgKiTKaimx5VanKsMHj cTRdZSMCCQ6INVaEz/PmSL4uv+4ansBJpT2mWLB+/7MV+V/luIl5TsrbKVvjUoMM9JnQ 1dCJ/TmMWp4D72/xKc29S/abSmYh6UpyIdFBUQPm++NeIYRlNSxyxh5kMuSUpghs+CZq h/JQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=hfhtGe5O; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q17-20020a170902f79100b0015eb18d825dsi14770470pln.461.2022.05.16.22.29.39; Mon, 16 May 2022 22:29:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=hfhtGe5O; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347878AbiEPVNg (ORCPT + 99 others); Mon, 16 May 2022 17:13:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349419AbiEPVM4 (ORCPT ); Mon, 16 May 2022 17:12:56 -0400 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4342F102E for ; Mon, 16 May 2022 14:06:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652735186; x=1684271186; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=Ygp3oXCRuQhQlvfoUeEq342dl+zO8N9KolCKY7QcuiY=; b=hfhtGe5OTDCgWjKQ2qMGIK5nA+9IRnjt5r1t/xZuJTZWH0Z21X3PHrq5 wgUFI1sV5QcDmrwxO+EupXkLyeGyFlCUFn1kTAFy8ypBGP2jhJbfhwmn4 2XB5YTMZRXSATPCFb70YKZ9nig8LVjhqhAiAPxwtwtrlV7CNcDLtqzXXg f09NP1vYpdKzSQd2EghQe/r17Ex6bavDbiRHAEuTyBhTHi9P6NE7epHfp SHUCLqwiI3jHXYFLncwpSe0HntRxvVUn+psFNud4cqGRjlJN9ZFFs88Sg mG7kK++PJVsD2UwTi3Cr9XzIjqiyLhNCtOAQX68jM9HvSI4VeTxfQx/W2 w==; X-IronPort-AV: E=McAfee;i="6400,9594,10349"; a="251479352" X-IronPort-AV: E=Sophos;i="5.91,230,1647327600"; d="scan'208";a="251479352" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 May 2022 14:06:25 -0700 X-IronPort-AV: E=Sophos;i="5.91,230,1647327600"; d="scan'208";a="596722329" Received: from skechkar-mobl.ger.corp.intel.com (HELO [10.255.228.165]) ([10.255.228.165]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 May 2022 14:06:25 -0700 Message-ID: <546a73c4-9ffa-0d37-a5af-ea7902dc1931@linux.intel.com> Date: Mon, 16 May 2022 14:06:24 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.8.1 Subject: Re: [PATCH v6 1/5] x86/tdx: Add TDX Guest attestation interface driver Content-Language: en-US To: Wander Lairson Costa Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , "Kirill A . Shutemov" , Tony Luck , Andi Kleen , Kai Huang , Isaku Yamahata , marcelo.cerri@canonical.com, tim.gardner@canonical.com, khalid.elmously@canonical.com, philip.cox@canonical.com, linux-kernel@vger.kernel.org References: <20220512221952.3647598-1-sathyanarayanan.kuppuswamy@linux.intel.com> <20220512221952.3647598-2-sathyanarayanan.kuppuswamy@linux.intel.com> From: Sathyanarayanan Kuppuswamy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/16/22 11:08 AM, Wander Lairson Costa wrote: >> + >> +static int __init tdx_attestation_init(void) >> +{ >> + long ret; > nit: the type of ret should be int Agree. I will fix it in next version. -- Sathyanarayanan Kuppuswamy Linux Kernel Developer