Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp3469162iob; Tue, 17 May 2022 00:08:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzt07gXODvxOvWDnicnsYxAAZNPvK41E1n7YmDesrEcHAwTIeWCQFkWVZ72AdEgna3a3e0L X-Received: by 2002:a17:907:6d1b:b0:6f5:30c9:7c84 with SMTP id sa27-20020a1709076d1b00b006f530c97c84mr18266422ejc.107.1652771308377; Tue, 17 May 2022 00:08:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652771308; cv=none; d=google.com; s=arc-20160816; b=MUcTy5sIjCS9GsrYnAm2VZHaH05azmOEnUcaXMAx9vtyCVbBTbTSVaeQ8qtc+r2MUq 7o1tyj6y459RXZMYitnBkd5+u5tkUEEVgGwCifWqBZFH+H3pr6CfNdmWD4rLuBuOQdiM ngzZ0036HtTNY0d6wwsphqJu04PEYi5eTsF1IdogUHgT2WWl0++Xo2J1irhSv1ulRogT XP9URnj/CN8wMzbR3IlL4rqg/LylMOsvkzHOeeKxHYlEuqfnMFZpRJNQ9iTO9VGS6Hpv Hp6scn7jjRnyoxoYyOor4Ci9q4fIjLBLmt0164XmUTOU3mCm4FaGmgzl6LDL9vXGpWd2 nM4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=jv0Y4sH5q/+cOZfXrfwTFO+h4KwTbyJ3ZtbRwi7S/Lw=; b=ykHZvxb279NJrxoqwVizVEaJ0CqYrQMeW4UiXBpoMA8K3K4o8txhgw41vfbcOsxJl3 JCrCaCvADH681K+5UtQT0oqpOMxUNQFika/3YgOaew6fGvaF3hl/LpxjJNww35ng/SXZ lEsGhPvhUmqLBeQccit6pd85BzHhlxrOkiDPtY6gP2W1HjpRI60WsNTI4LDLYylNLB5n rB3VB5oC+dNcu7csXLKs9YctlyMwNWM7Z75Fu7JXPSuBeu7Z6RQ+RJ19bcfDS11uCLis HX/hoyyy7Qktie/Z113iJVa0wPgbWf9cQafTpNrLN4T0h5/T5qi6BgnyAEOEavTPyR13 PWlA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=ew4Tb8Mq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i17-20020aa7c9d1000000b004280d15fdb3si11936432edt.395.2022.05.17.00.08.02; Tue, 17 May 2022 00:08:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=ew4Tb8Mq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347623AbiEPT6C (ORCPT + 99 others); Mon, 16 May 2022 15:58:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347900AbiEPTwY (ORCPT ); Mon, 16 May 2022 15:52:24 -0400 Received: from mail-io1-xd31.google.com (mail-io1-xd31.google.com [IPv6:2607:f8b0:4864:20::d31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 734A444A39 for ; Mon, 16 May 2022 12:48:04 -0700 (PDT) Received: by mail-io1-xd31.google.com with SMTP id q203so1312681iod.0 for ; Mon, 16 May 2022 12:48:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=jv0Y4sH5q/+cOZfXrfwTFO+h4KwTbyJ3ZtbRwi7S/Lw=; b=ew4Tb8MqwPRgVuYAPzp9N7lmT/ezFUb7lubqLPv59RNbYaQaoA5L8MiagwGWoqJS+m mJSCtEETbHjNrCvgJ3WxZXwSyGLzGP0KKuvPZ5QT89vJo9753DV3+XFIuNU2CrNgdlkq AGGAZK+plrK3X/ebH1vd4e3nGfSjYYXbUQz5w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jv0Y4sH5q/+cOZfXrfwTFO+h4KwTbyJ3ZtbRwi7S/Lw=; b=oLSPA3ZddYWzBMlE0+CktBKDiwsQvQFnwARRh6l2rsauwIO5MYhGousD1t4QvdILas S3Rao7ulN0qAVLXXiehOi5xCTAyfEge8PkYkwjaw9HNrzD78oGtgW8w8E6rVzU5AxW0Q zIELlnllsw99LTFbssTj9UPAtamV/q0/6u4p6diu+FfAYR6LKiuU4mw2GyqQCShQxdCC jhbyNHqagxnWKvlz3xVd4y5DK9wU8APhN3dLusKQJgFuJ3R54SsCHybpPqY+trYBzTpr KXTSMgwtmiL4Fg80CY47GEYQZGue6DWZhZALZsBArLGeywsPj8mvHlwLisFTGvbyZ/Hz 9dCA== X-Gm-Message-State: AOAM533uVd7JcIuGMXwixBrlq/mAIMyMYsutITymd/JZw6VGBL3ENmzn /Ye6tm1vC2aq8+ikDeWO2Xp88A== X-Received: by 2002:a05:6638:2191:b0:32b:b7af:1228 with SMTP id s17-20020a056638219100b0032bb7af1228mr10056071jaj.13.1652730482764; Mon, 16 May 2022 12:48:02 -0700 (PDT) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id p12-20020a056e02104c00b002cd7dc16ae4sm88740ilj.1.2022.05.16.12.48.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 May 2022 12:48:02 -0700 (PDT) Subject: Re: [PATCH] kselftests/ir : Improve readability of modprobe error message To: Gautam Menghani , shuah@kernel.org, linux-kselftest@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Shuah Khan References: <20220513190721.16482-1-gautammenghani201@gmail.com> From: Shuah Khan Message-ID: Date: Mon, 16 May 2022 13:48:01 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20220513190721.16482-1-gautammenghani201@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/13/22 1:07 PM, Gautam Menghani wrote: > Improve the readability of error message which says module not found. > The new behaviour is consistent with the modprobe command. > > Signed-off-by: Gautam Menghani > --- > tools/testing/selftests/ir/ir_loopback.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/ir/ir_loopback.sh b/tools/testing/selftests/ir/ir_loopback.sh > index b90dc9939f45..aff9299c9416 100755 > --- a/tools/testing/selftests/ir/ir_loopback.sh > +++ b/tools/testing/selftests/ir/ir_loopback.sh > @@ -10,7 +10,7 @@ if [ $UID != 0 ]; then > fi > > if ! /sbin/modprobe -q -n rc-loopback; then > - echo "ir_loopback: module rc-loopback is not found [SKIP]" > + echo "ir_loopback: module rc-loopback is not found in /lib/modules/`uname -r` [SKIP]" > exit $ksft_skip > fi > > Applied to linux-kselftest next for 5.19-rc1 thanks, -- Shuah