Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp3505428iob; Tue, 17 May 2022 01:13:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyihCGDUX6nxPVLI3hGyXyzCzTLUXH2rHGVilzkFKr6YUqkpU43hH4EnJwlaTxI8JGmfWRu X-Received: by 2002:a17:90a:46c3:b0:1df:77a4:471e with SMTP id x3-20020a17090a46c300b001df77a4471emr5102432pjg.224.1652775202428; Tue, 17 May 2022 01:13:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652775202; cv=none; d=google.com; s=arc-20160816; b=div1hMSMgF2aYkASvpCHLOlLpInZCwiTVBtV6MJIbROOVMe9L3epjLffjQDc16FAeg qAnws7fzuF+k2IEZExtfXXzo3lPvcbnq112o9WG6d7C0qDBlTzUxRIAh/G80Yo1Qx77a DOl/q/SVYR4JpogwNVgsrgV4yKMY70NiyjjWdt3HK1yqcoxnbxeMzGlRD+cwextek+VV Q9dSkhtWcJa7ZSOtkXl5fDAJbJYoClpqnFA9xOUImsJ3L15AOiP3KuX0E8iykI1yn/+Y ziifgmQ4petTeLs5WY1rVyKYMYPE48zUUzWU89biC/JBHQTzD1jrd0IvF6TUoxk5W4o9 gDlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=GzzgCltF7EDsVxSkeU3YZiuTPNyBoItGWan0/cdS5EI=; b=yWZ1aZFgzl5xdIm+W7w3tJr/pIWF2nWLQ0azlkOXVaRwh8KnFeC9Lu8Fkfab2UbZV6 2FwKpe97TN0+ldI4N+SyoP7eKjWHLmFTURL044zCIlo1Tm4hjlrDuLiRvfGnSDqrsdy3 ppm/QiX2Fuhu6dLhYNBxUplFWrShXCmAZk3Auf+7N7tDQW6s9lgy+yDc1tC86WuGpzBx xkHZdti6osL5u7LsqVISah0GtYx6i59Gi/ibK40U+KPsEF9474jOZ5fMa4zOiG746Coj PmsBRaTxzN66P4g4D6Aq5fCYg/mGhBBJ6yRWjVA+2+SFKUSForfmOA4TcrltiO7uNkim kT4Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x10-20020a17090a6b4a00b001c6c8e19f0csi2166363pjl.98.2022.05.17.01.13.10; Tue, 17 May 2022 01:13:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346252AbiEPWx1 (ORCPT + 99 others); Mon, 16 May 2022 18:53:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230244AbiEPWxY (ORCPT ); Mon, 16 May 2022 18:53:24 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7792B41982 for ; Mon, 16 May 2022 15:53:23 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2A810B816A1 for ; Mon, 16 May 2022 22:53:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 68104C385B8; Mon, 16 May 2022 22:53:18 +0000 (UTC) From: Catalin Marinas To: Baolin Wang , will@kernel.org Cc: christophe.leroy@csgroup.eu, anshuman.khandual@arm.com, akpm@linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mike.kravetz@oracle.com, willy@infradead.org, songmuchun@bytedance.com Subject: Re: [PATCH v3 0/2] Implement arm64 specific huge_ptep_get() Date: Mon, 16 May 2022 23:53:15 +0100 Message-Id: <165274157825.4033361.18236433604256004496.b4-ty@arm.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 16 May 2022 08:55:56 +0800, Baolin Wang wrote: > As Mike pointed out [1], the huge_ptep_get() will only return one specific > pte value for the CONT-PTE or CONT-PMD size hugetlb on ARM64 system, which > will not take into account the subpages' dirty or young bits of a CONT-PTE/PMD > size hugetlb page. That will make us miss dirty or young flags of a CONT-PTE/PMD > size hugetlb page for those functions that want to check the dirty or > young flags of a hugetlb page. For example, the gather_hugetlb_stats() will > get inaccurate dirty hugetlb page statistics, and the DAMON for hugetlb monitoring > will also get inaccurate access statistics. > > [...] Applied to arm64 (for-next/misc), thanks! [1/2] arm64/hugetlb: Use ptep_get() to get the pte value of a huge page https://git.kernel.org/arm64/c/f0d9d79ec793 [2/2] arm64/hugetlb: Implement arm64 specific huge_ptep_get() https://git.kernel.org/arm64/c/bc5dfb4fd7bd -- Catalin