Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp3505628iob; Tue, 17 May 2022 01:13:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxWzYiCYb8sdtUn0gC4lS1Vv3k7ZOUnZ+mZzmKcsE6xxluD5k+MCC8tUnN0rwG/ftrSCBfh X-Received: by 2002:a17:903:30d2:b0:161:70be:bf86 with SMTP id s18-20020a17090330d200b0016170bebf86mr10392696plc.18.1652775227352; Tue, 17 May 2022 01:13:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652775227; cv=none; d=google.com; s=arc-20160816; b=aj5nxEHGRB+hYMW0P6tj6w+TQbPIJ2TF0wqFQ7SL4DK8Qz/3c77mDR5umIqB4JaasE CjbH0KX+4D8EoYFyZ4S9dkQx8SYlKHBE0x8PgQWDo/DEaPlcfvx1roJeuVXeWCpt7OjE hemYIJ/u15qVNXIeIXGTCZBH/ZHwr1fGjpzCN92jvk3OImI4wX7q6cpLOFfoG9mW/+7S xs9qi3F+nbI6lsBmt1O9YVvfQ0diqTGFv6XkAYgFNGDURvQqSneP6yKPwwJegOveiPS4 KuGsp7ctrAcX7WbDepTeecCSsLERg5+jfUU9NUhA6DuU9TrowvbBvmQzGT9/AJSuZ1RG GEgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=NgRN56Q/BkN3wAktc2DUtJ1ztdzHq3jGQdvLZCUxqpQ=; b=pzq4s0HtAgQSIlSozJ+kJl3TqUKN1TeIagV4vVjV2J+a+hHZ2/9jo9erxDp/77vFFS xpxl7SNtrFi69EzrVqBet9epyeSKuf9bgz70adN0nqGgcdYFfs7F4aPmCT1qQk9ibXuE PplZbLzsy/bnYB/kL/OFVMT49efsUPyPNdF5pSX4Si1XDG0Okhtv9A50KyFGNzeJcgMc ld8jlLYiXfkOufJmp1zrf91SoX3TkK1K/1G71l4nP9Y62Zcte+p/KRNjI9rsl62uhJQR 7bBzMHH94AiSCkQu1vLo1HWYIGWy/iq0VVW6xp6FlpQN043yY9GMXNWSxSGlOfx0nuQz MjCw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ANj9Mu+B; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cj18-20020a056a00299200b0051069299ec6si13520233pfb.173.2022.05.17.01.13.34; Tue, 17 May 2022 01:13:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ANj9Mu+B; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348050AbiEPUWn (ORCPT + 99 others); Mon, 16 May 2022 16:22:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348897AbiEPT7C (ORCPT ); Mon, 16 May 2022 15:59:02 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F9851EED0; Mon, 16 May 2022 12:52:26 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3B26660AB8; Mon, 16 May 2022 19:52:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A4570C34100; Mon, 16 May 2022 19:52:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1652730745; bh=Awiprtiqd6rBvfwinWDMtOdWLv2WDp/7Cu2ayN3Qk3E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ANj9Mu+BA9t7kUsxTLCTBt1HmCNWg2fjVAigMSt8b43qy0Br6W3f+dMTFTcNodY+Q /ZWb/PZTeKgSgmrEzCZR9bfJNR1s+c/cX0+ahOckq7AnmU1vlWBAkXA4SMn299dmvJ jzwZvzK9GLn4nHyXRYmxzmdhKahSBWZboFLf/rKw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Andrew Lunn , Fabio Estevam , Jakub Kicinski Subject: [PATCH 5.15 093/102] net: phy: micrel: Pass .probe for KS8737 Date: Mon, 16 May 2022 21:37:07 +0200 Message-Id: <20220516193626.668286837@linuxfoundation.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220516193623.989270214@linuxfoundation.org> References: <20220516193623.989270214@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Fabio Estevam commit 15f03ffe4bb951e982457f44b6cf6b06ef4cbb93 upstream. Since commit f1131b9c23fb ("net: phy: micrel: use kszphy_suspend()/kszphy_resume for irq aware devices") the kszphy_suspend/ resume hooks are used. These functions require the probe function to be called so that priv can be allocated. Otherwise, a NULL pointer dereference happens inside kszphy_config_reset(). Cc: stable@vger.kernel.org Fixes: f1131b9c23fb ("net: phy: micrel: use kszphy_suspend()/kszphy_resume for irq aware devices") Reported-by: Andrew Lunn Signed-off-by: Fabio Estevam Reviewed-by: Andrew Lunn Link: https://lore.kernel.org/r/20220504143104.1286960-2-festevam@gmail.com Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- drivers/net/phy/micrel.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/net/phy/micrel.c +++ b/drivers/net/phy/micrel.c @@ -1544,6 +1544,7 @@ static struct phy_driver ksphy_driver[] .name = "Micrel KS8737", /* PHY_BASIC_FEATURES */ .driver_data = &ks8737_type, + .probe = kszphy_probe, .config_init = kszphy_config_init, .config_intr = kszphy_config_intr, .handle_interrupt = kszphy_handle_interrupt,