Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9560ec84-9b05-63f9-0090-590c0f1bd6c1@fb.com>
Date:   Mon, 16 May 2022 19:49:23 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.9.0
Subject: Re: [PATCH bpf-next] selftests/bpf: Add missing trampoline program
 type to trampoline_count test
Content-Language: en-US
To:     Yuntao Wang <ytcoode@gmail.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>
Cc:     Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>, Shuah Khan <shuah@kernel.org>,
        Yucong Sun <sunyucong@gmail.com>,
        =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= <toke@redhat.com>,
        Kui-Feng Lee <kuifeng@fb.com>, Jiri Olsa <jolsa@kernel.org>,
        netdev@vger.kernel.org, bpf@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
References: <20220515063120.526063-1-ytcoode@gmail.com>
From:   Yonghong Song <yhs@fb.com>
In-Reply-To: <20220515063120.526063-1-ytcoode@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eG1Lak9FVjBKMHliTnl1VWxoYitzcXJqc1oxVkRMd2lDQzdJVjErbllmOXFo?=
 =?utf-8?B?dXp6MFZoY2VjTGY1Mk1tdE40UHJPbHBtWTJPMGt0UEpRMGVFM0tTdmo1a01W?=
 =?utf-8?B?blRGOUkvS0M2YXhpTTFEYlJRNllhV0RzRU1VQVBLODkxVTFYTzRxU3dzbW42?=
 =?utf-8?B?VEJqaHg2bENIZGMzd2VHV1dqKy82eHJlVXBSVHZXcFp2bWNnZThqd05JSU9X?=
 =?utf-8?B?ckxyVFhlenIxNmUzc25KNksreWpneEwxdFJQZEsxa0xUNUZtL29PdE5NM3VM?=
 =?utf-8?B?dDloSDgyKzZrRjZibllERGRmY3hTaVo0Wi9yUFFsZFNPZzZFTzRvMy9PdXll?=
 =?utf-8?B?YWp5V3IzdG83UTNsS3BBcmpVRHEzbFdNVHNuRldETVdGUVhYeWQwT3ZPbURE?=
 =?utf-8?B?Q21GN25IOTJZaFhsR1FKc0ZaTi9RRENGaXBNaXJrZTVIRjhqZEZPbjRVd2V3?=
 =?utf-8?B?SlhMWmszU1RISkc4K2xhS0Y2cmhMcWsrdGFnUHNjemJJaGJJamYxS0RCenNM?=
 =?utf-8?B?R09sVnBjZFAvOWFkYTA4WkZjYWpjeDU3WU5EdkphNEYzakZDbmxiY0M5aUQr?=
 =?utf-8?B?OUNZVmY4R3BQT0o3VHNNc2dLNnFtMWhRSnhSL1BDUTM0M2lWWUcydERMcFZp?=
 =?utf-8?B?alhEbmhqWEVpZVUzMnZZOXRvMysxK3FlQXlkOFJxU2hnUlB5L2lXNnhLdzBZ?=
 =?utf-8?B?SEg0UXhnVVQ0Vlh6TUhwZ2xYcG83R2dpb25oYTBEQWxSZ0dyc3RGaDliYjdT?=
 =?utf-8?B?T0J6a2Zrdm15QzFQcENrTXMyMEdibXdUYnVYVjJlbml2elp1Qk5xck0wNHRS?=
 =?utf-8?B?SDh3ZVpKSXNYaGdaRitPbHBXaFRGMEpSb3Z6Y3RsMUFhYUcrRUVsdVJxUUM0?=
 =?utf-8?B?M0xqRUFUSmJxazJZKzZEMXpNQVBJbXIyTVJQVVIyTExqWnhYcTAwbW9VZFNS?=
 =?utf-8?B?MGlkY0FLM2IyVDQrNTg1ZTI3SVNTaEZsNVQ2eC9jYndXSU0vVHdZVVQ3Q0lC?=
 =?utf-8?B?RXBUdnBOSTljamJhYnNESkd3eWo5Q2hlR1RzNEtxa212bHozekJ2cERoSm1W?=
 =?utf-8?B?MG5XTjBKd25qakZPV0swTkhpendhVi9DeGpZbXo3R0luN1BGSVA0S3NxL2Ni?=
 =?utf-8?B?eGdHNmZsY3lsbFl2RUNOa1lqOUY2bEphdWFrUGs1WWl1RzlON2Q4OVlEMjV6?=
 =?utf-8?B?OWhIN05XMnRVL1g5elF2RWVaSWZMWlliNzlBTXJHTGFmMDlJSnNMQ1U3MmVl?=
 =?utf-8?B?Y2ZSZ1RvdWxObmJ0NlF5dzM4TFJlRzZONVMxc2dQTmlEVTNETEdKSzBVbW1M?=
 =?utf-8?B?MVJ0d1BTZXlNV3kwNDZabVFYQVdOR1h3Zkdzc29UVFp6S05FOTRmVE14eENp?=
 =?utf-8?B?alNHNU9ldHlwZnBKbGhHd0UrSDhUdG53Z2RZWmpQMDU3d3lWQUhrTlJ5bDVI?=
 =?utf-8?B?STRiNmhDdFk5Sk1uSlpjSlVTY2Y2a056cXpka0FkMGVWYnV6SnV6ZzdZaWU3?=
 =?utf-8?B?SWkvMkZzWkZnZFdNOVduWnpITjYrczNVZ2RRdXh4NjVUS0hoWCtGMk02V1FC?=
 =?utf-8?B?SWVrS0syb3dIV2F4S1dSU0hMdk9kYXdDZ2lQWkU3VmJjRmFQS01jaDNtYSsv?=
 =?utf-8?B?SlVVY0FCQWNPcVovSkJvdFJJSkxyNkhTU0dBdlhidzIrQ2xjN2x1eFllVTFS?=
 =?utf-8?B?TEw5ZDIrL2ZCU2tXS2UwYjZBWE5jNzZvdE45dlVZVG9GSHBBS1gwKzFIbnlB?=
 =?utf-8?B?ZDlaK0w3YkpxK1cvWkJQdW9kcTVnU09CL2xsMjZlSHhSK0hHYnlvdHZpVlZJ?=
 =?utf-8?B?eEhiQXdMa09heXZjSThCVG1DZXVnTGRrYTVFV05XOG5UcE9USE1LT2FSVzBN?=
 =?utf-8?B?YmxEL2ZUWld2b0wvV2dDeUNmOXI3KzFlanVKbEJxRTNmUkFWa1pvdTlINTBW?=
 =?utf-8?B?VEpILzRFaDFwa3FtUzBHYjB0QmlaWG5XUU5YVzlzTmxSRzFQUFdITzU1dEtK?=
 =?utf-8?B?UkJRK0hlZVRzeVlMeHhDOTdVYlA0SmNHVVJtU1Q2dGhqL2VzNnpoRWY2TkZQ?=
 =?utf-8?B?TXZvNkFmakVVbTRzN2t6ZVJYS0pNL3BQWjJvSktwRUdaNzBtYTBPSWdQQUF4?=
 =?utf-8?B?Z21QTWRMMU04V3JMek10YldaQmpNOWtCSmZSTnBTY3Z5WVRlV2srWHFXNjF0?=
 =?utf-8?B?VnU5MzdEYXdEOW5odVNpeVZicGdqdkN5eGh3QW5iUUttZ3dQTU92QmZFbmlH?=
 =?utf-8?B?SDc2QTFXTzdlSXR6QTQwZ001akk5ZkNGSUE2T1BKU2UwdzJQbVZ5UzlCbVdI?=
 =?utf-8?B?MFphOTV1cWZHL2h1dG1HbXBtaGU4SDJSU3Y2Y2RnellWbWk3VjZIMGZpSjJp?=
 =?utf-8?Q?LhtBFegY0Izw9u3c=3D?=
X-OriginatorOrg: fb.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 43fefa57-251b-4598-17e5-08da37afdb0a
X-MS-Exchange-CrossTenant-AuthSource: SN6PR1501MB2064.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2022 02:49:26.2053
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FLfUxW1V1kUwUsTkpswKFaKjdBKeGrE85RNAbS80abuhcZ8O9uheH62JUQOiXkEd
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR15MB1455
X-Proofpoint-ORIG-GUID: UcG00h_rySRnLv_2IqQCd1tRENggZBjG
X-Proofpoint-GUID: UcG00h_rySRnLv_2IqQCd1tRENggZBjG
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514
 definitions=2022-05-16_16,2022-05-16_02,2022-02-23_01
X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 5/14/22 11:31 PM, Yuntao Wang wrote:
> Currently the trampoline_count test doesn't include any fmod_ret bpf
> programs, fix it to make the test cover all possible trampoline program
> types.
> 
> Since fmod_ret bpf programs can't be attached to __set_task_comm function,
> as it's neither whitelisted for error injection nor a security hook, change
> it to bpf_modify_return_test.
> 
> This patch also does some other cleanups such as removing duplicate code,
> dropping inconsistent comments, etc.
> 
> Signed-off-by: Yuntao Wang <ytcoode@gmail.com>

Acked-by: Yonghong Song <yhs@fb.com>