Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Bernard Zhao <bernard@vivo.com>
To:     Solomon Peachy <pizza@shaftnet.org>, Kalle Valo <kvalo@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     zhaojunkui2008@126.com, Bernard Zhao <bernard@vivo.com>
Subject: [PATCH] st/cw1200: cleanup the code a bit
Date:   Mon, 16 May 2022 18:41:36 -0700
Message-Id: <20220517014136.410450-1-bernard@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6FUS4uM49XV23j2es93ACtc5JVrdEx2euEvVitnSHQEcy8l2b36axCWpHQiD?=
 =?us-ascii?Q?u8epFk6JmB/bctD8zbnW+SBKsgJcECjqF/zdLbYv5Kkh2h1rxPFx+9Y9NwjL?=
 =?us-ascii?Q?KXP1e1WgArywv3aL5RFQ0U1oLDPdULi6ilVI/uoCky0q0E4kRMG+LqqLCJE8?=
 =?us-ascii?Q?3X81QoYLR7zQV1lgRyPaAyIIeHlbnoFogvKprU5jIW0G9UM9G5jN3FxwSt6p?=
 =?us-ascii?Q?WcSMNttpFJnZEvY115OhmRVr4IDcT/BRa6vido2ZeIN1/GhadErRwAwQaOwz?=
 =?us-ascii?Q?vw49/PO/Tb7yVb+ZADC4zS3JngLf1OPtbh13Wa3+DjcIhRkyaTC9mN7I0cW7?=
 =?us-ascii?Q?j1PepTbnkkC0N99MwDfaiKK/EmhzpwajU9ofML0FjXNZEjkMwngBrXjXqyAm?=
 =?us-ascii?Q?VLQ3bpqhXdjkDKQ+BU2ZP6QuBPRRXqqaqrJ2SQi7O/unw4hcZ/BZEgHlOrcz?=
 =?us-ascii?Q?iU+jP5FQazEL5R5q9fT8wJN3E+1Ed0i3UwNPQrYCpa1+ZCoRequfTGDy82lD?=
 =?us-ascii?Q?TWamBeEOcDia7rtqOS6fj9RWZ6CS/ET7aoKS1P6Rkuz334XZTEw6fvJnMLQz?=
 =?us-ascii?Q?5ojQ994DEOjDxrS7K8NfMyJLGjqc0jpEHO8/a9rEgigny0kN1c9yQ/ClRiQB?=
 =?us-ascii?Q?9QSEB3QHe3wsBCnbqU7qFaOYZWM/2uDL2m/bHxAr5sM4KyOgMvlDAXBhgD0D?=
 =?us-ascii?Q?JgJhw9fitmFfmwHojt9oUlbkj9N1kmJUYKHIzjUUg17dWOmbwR+YQR4wrQPB?=
 =?us-ascii?Q?X4EVnNHsnb3C5Zw9SOdiK3rXTq6tRsUpVyH/XdnVQzRggtLu7YLjvrGzmOq+?=
 =?us-ascii?Q?FRKm8QxsBaGYSZi4tY3XXpK7TEnByWgdGujd3xm0hUnRzSykn0+JpEeALfsd?=
 =?us-ascii?Q?oPYJMz32CB67dHJUV7o+ZgMYz0mid3mR+RdAgQddKPkqWu3XQPrWSFPzXrp2?=
 =?us-ascii?Q?zNOAFwWnsn9I32COsrNTvQboZ+bc9sySaKANh4tgP3PcvfFwLDm9QsQVlyiJ?=
 =?us-ascii?Q?Ai0Qo8eEoWlEdIN+JKeDs4pxzYcrS1C9vjgVc9KhJ1ewZJZ6rGuOp/NqWScS?=
 =?us-ascii?Q?+/ac/jTVy+hp/CI76UxJQHhRmFddqwYQ1UHx6RZD4Z1sv9W8cw11WLwf32Rp?=
 =?us-ascii?Q?/o5fsfICAFGNgCaLJr1/uH8wLSGzXFKHpPWRk70h6orQTttoES2Zn8s2nVlk?=
 =?us-ascii?Q?N/50qSJRCDI+kL6xWOqSg9fXe5GHgRLqKMpvKD5l9KSzksZoC2eVte6hHfej?=
 =?us-ascii?Q?JjVnstH2OsytPaz901ebzYLDNI6E51xsiF+jCPYEg9Y8iadAiWuCW5nkZrCk?=
 =?us-ascii?Q?69Wy7R4AgbGmP0FvXS0oZOwISlGEi5Iva0ZUBM+uqAPfi1P1zHlRrASCGNML?=
 =?us-ascii?Q?qp/NRedeDV6oVyRuTAwb8FcF2EslHpPcwWonTp916gCB/LNb+LS3ZKtWFGDq?=
 =?us-ascii?Q?UJHF2VQyBxnABkOUY8EVHfRYEX9wWm07vdqF+/HQa2Cxv0+XzcC29DrcVdj3?=
 =?us-ascii?Q?Bu0miLG/lCGfsBU9o8WfXF0j0ppIHTiF0W7/m/3DaRyLomNlZZhMB0HbHXmJ?=
 =?us-ascii?Q?3vYd471t3HAg5Kf5RdtWYkSJWwrkmjzrxs3fM3bF/SjzqhND97MnyGYwWsNC?=
 =?us-ascii?Q?uv/vrbDpptwrKaEhooceXVqh5svT8JlMkJY//dnh1vi2ixtuv20WmEyFEqaD?=
 =?us-ascii?Q?ly1pSuJaS2XfaNo7rn5TbfpFpkxBCV9fMxzy/yg4/Kj6EL7t+Riwc1cCIorj?=
 =?us-ascii?Q?3wiAk3rZyw=3D=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 14b9c852-b497-4dce-2e23-08da37a666e8
X-MS-Exchange-CrossTenant-AuthSource: PSAPR06MB4021.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2022 01:41:45.9749
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /Zwet0jFGlftd8v9LMCtgZMbprxJbAVNdJq2PeKbjKiFAeRqK6uSmfUgXCpmjSSMiJRcNsNFsIKfSHCqMggjVA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB5226
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Delete if NULL check before dev_kfree_skb call.
This change is to cleanup the code a bit.

Signed-off-by: Bernard Zhao <bernard@vivo.com>
---
 drivers/net/wireless/st/cw1200/bh.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/drivers/net/wireless/st/cw1200/bh.c b/drivers/net/wireless/st/cw1200/bh.c
index 10e019cddcc6..3b4ded2ac801 100644
--- a/drivers/net/wireless/st/cw1200/bh.c
+++ b/drivers/net/wireless/st/cw1200/bh.c
@@ -327,18 +327,12 @@ static int cw1200_bh_rx_helper(struct cw1200_common *priv,
 	if (WARN_ON(wsm_handle_rx(priv, wsm_id, wsm, &skb_rx)))
 		goto err;
 
-	if (skb_rx) {
-		dev_kfree_skb(skb_rx);
-		skb_rx = NULL;
-	}
+	dev_kfree_skb(skb_rx);
 
 	return 0;
 
 err:
-	if (skb_rx) {
-		dev_kfree_skb(skb_rx);
-		skb_rx = NULL;
-	}
+	dev_kfree_skb(skb_rx);
 	return -1;
 }
 
-- 
2.33.1