Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp3686140iob; Tue, 17 May 2022 05:27:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxf9ti2IrtWZozTlKfTqRD+FA3vXGoxqiIUlxBZpNpBiH8effdhIbnVM1NmAjphSYLvv8+E X-Received: by 2002:a17:906:dc89:b0:6f4:d3a9:34ed with SMTP id cs9-20020a170906dc8900b006f4d3a934edmr19634118ejc.459.1652790457052; Tue, 17 May 2022 05:27:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652790457; cv=none; d=google.com; s=arc-20160816; b=LAO3+EVYrOW8FNu2TQqkrc4/LeHqViIqInc9eY9DZtOG1jgOYB0Q0BLImgK5RL/6jw +0sSaxct8lHEGSnpMak+DKab+Nc2WegXlIW4Iq6JCjJNbg9jHpKf5UwU4h3JiUeKeY1H bOiesUa+owNfWrGLGGm07ZiEjUQEXK98f05RI19Q8bd43Dj0YKZHvu+ZP8KwuPS1hhnN ksRIPgp/KzEe2XsHq2msM8cqkiHtH3RuJa2NgCUaIjXitvTHS9wfyOp9KnZqQEesbiGr B5uyhfpZ7v4niwBmf0Jo+gHLMWO3944O70fuExxLPqWXaZ70r2FynTblxKX/Aok11lC9 iyuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:mail-followup-to:reply-to:message-id :subject:cc:to:from:date:dkim-signature:dkim-signature; bh=XWV9I8vEC/gVBQMdfp4ZLR/XCARFFY3wFzVWUZZsLyM=; b=Ym0OfIN+PLKuUtWLB0qB3kBvs/8hbpjxkdyOWPcfr7VlwjGMHygETzhISR6WVrX/OH bSZCZEviSPrT0LFObFLwhRT/3JJH31U+PqArvQL5vCkDiOP/Dl7diWEKgf3IAWSFBWXO efnjj1GZG9gcF6ZD9ojqX9Vr/NyN78+Eelo32ftRv0tXmz9XdGhDaryjGpm2eHNwoTBQ hbsz8CmyT9hyN4dB+hVLge9mZEQiOymBVB6rFMn56Q4iiJRPy0PLHyCBnUm+kF5rbyZ0 cZ/AfVixza751pEFBuevWu2YQuk9AIfP6HwCoFIZP3WZVTc4BTOgo6C9BifiegOqYBZ8 H15g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=j9NlYg+l; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ds22-20020a170907725600b006f38a179611si2792183ejc.580.2022.05.17.05.27.10; Tue, 17 May 2022 05:27:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=j9NlYg+l; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345589AbiEQLzu (ORCPT + 99 others); Tue, 17 May 2022 07:55:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345574AbiEQLzq (ORCPT ); Tue, 17 May 2022 07:55:46 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9A714C41B; Tue, 17 May 2022 04:55:41 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1FA761F8F7; Tue, 17 May 2022 11:55:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1652788540; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XWV9I8vEC/gVBQMdfp4ZLR/XCARFFY3wFzVWUZZsLyM=; b=j9NlYg+lgeZw9lxeHS9hEMqYh9EWqsSTl22Ibl6SLszboSCxHZeZodscBEl49w/4vIrcOB uAXkoX1nvTKjUM1EUBcvOyjjqjRbNUJbZ/kq4stZ+0/lerrP5gO4626alqaz99tsnRPc1F LBtIqYYF955Cs3zK/ONXbGQa4CWL9/k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1652788540; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XWV9I8vEC/gVBQMdfp4ZLR/XCARFFY3wFzVWUZZsLyM=; b=dxEL63L4qVfrlSY8/gFaeGBil7Jzz5/q5q2u14C3uE+vuxIzDaaJnUvlZVhVxGzwFZtcYq HrloqJOf4p4mS8Cg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B7A1D13305; Tue, 17 May 2022 11:55:39 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id nQDZKzuNg2JOAwAAMHmgww (envelope-from ); Tue, 17 May 2022 11:55:39 +0000 Date: Tue, 17 May 2022 13:51:21 +0200 From: David Sterba To: Johannes Thumshirn Cc: Pankaj Raghav , "axboe@kernel.dk" , "damien.lemoal@opensource.wdc.com" , "pankydev8@gmail.com" , "dsterba@suse.com" , "hch@lst.de" , "linux-nvme@lists.infradead.org" , "linux-fsdevel@vger.kernel.org" , "linux-btrfs@vger.kernel.org" , "jiangbo.365@bytedance.com" , "linux-block@vger.kernel.org" , "gost.dev@samsung.com" , "linux-kernel@vger.kernel.org" , "dm-devel@redhat.com" , Luis Chamberlain Subject: Re: [PATCH v4 06/13] btrfs: zoned: Make sb_zone_number function non power of 2 compatible Message-ID: <20220517115121.GA18596@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Johannes Thumshirn , Pankaj Raghav , "axboe@kernel.dk" , "damien.lemoal@opensource.wdc.com" , "pankydev8@gmail.com" , "dsterba@suse.com" , "hch@lst.de" , "linux-nvme@lists.infradead.org" , "linux-fsdevel@vger.kernel.org" , "linux-btrfs@vger.kernel.org" , "jiangbo.365@bytedance.com" , "linux-block@vger.kernel.org" , "gost.dev@samsung.com" , "linux-kernel@vger.kernel.org" , "dm-devel@redhat.com" , Luis Chamberlain References: <20220516165416.171196-1-p.raghav@samsung.com> <20220516165416.171196-7-p.raghav@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 17, 2022 at 06:53:40AM +0000, Johannes Thumshirn wrote: > On 16/05/2022 18:54, Pankaj Raghav wrote: > > /* Cache the sb zone number */ > > for (i = 0; i < BTRFS_SUPER_MIRROR_MAX; ++i) { > > zone_info->sb_zone_location[i] = > > - sb_zone_number(zone_info->zone_size_shift, i); > > + sb_zone_number(bdev, i); > > I think this easily fits on one line now, doesn't it? But given David's > statement, it'll probably can go away anyways. I agree that the formatting can be adjusted, but I'm never sure if I should point it out during the phase of functional changes so it's fixed in the next iteration as well, or not to point it out to avoid fixups that would go away anyway. I think I've seen more, a styling pass will be done anyway once we're close to the final version..