Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Anton Altaparmakov <anton@tuxera.com>
To:     Andrew Morton <akpm@linux-foundation.org>
CC:     "linux-ntfs-dev@lists.sourceforge.net" 
        <linux-ntfs-dev@lists.sourceforge.net>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Colin Ian King <colin.i.king@gmail.com>
Subject: Re: [PATCH] fs/ntfs: remove redundant variable idx
Thread-Topic: [PATCH] fs/ntfs: remove redundant variable idx
Thread-Index: AQHYadGjIrr1Cy/zz02Ilh3VzQbVG60iz5wAgAAqvoA=
Date:   Tue, 17 May 2022 12:09:46 +0000
Message-ID: <D8033E52-4BB9-44E7-A97A-FB1E51645902@tuxera.com>
References: <20220517093646.93628-1-colin.i.king@gmail.com>
 <20220517093646.93628-2-colin.i.king@gmail.com>
In-Reply-To: <20220517093646.93628-2-colin.i.king@gmail.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+JW6I5uX1FV2lzY71BM2zMAtUty/+MaZNL/yLwoFkb41rwGoCRKhADL0cAKk?=
 =?us-ascii?Q?uQHR74zuVkhJ667bVWMnUIqk9TNyfvKyZJnZXqwmLvE5HdZOy5haWPrNeXbM?=
 =?us-ascii?Q?yQWQeEWtWA9d4/lczeHEccryKCtGs/rYZTXuQhBXovpQBWy8yGNDG2zLpFXj?=
 =?us-ascii?Q?lswItXvjMLfL9N5nJAVnoeRfAGR8NastJjAtqXqXWcUA0ZEZUXpo8f7qrLnv?=
 =?us-ascii?Q?WyQXPiVk6vFW51ifN2lzfDGr64jO8cIWVSEW74RL2m9v0cADvh/Is5rSBkFv?=
 =?us-ascii?Q?aH5HWFxHtJigMPN6Ul+jORxBiOHKazKlsSntnO0vaibvQip2M16MDMOlm1ln?=
 =?us-ascii?Q?0V1bbuJXM/Sd/it45xe4cXQ0RdWkazAynAQZ5qMqU1WVAZ6+xDji1KzE93XH?=
 =?us-ascii?Q?tTfLoWGfB/yoM+W4yIqonRr6ON168eRNPMQhnGNB8BGC/OPcEHEHO77kvuRr?=
 =?us-ascii?Q?UodVM92icFcra9lP1/6OdF+Zsio7HZ4IfEtRL8DFdfp0bTUwXtnJrfwRYTVu?=
 =?us-ascii?Q?Rm/3or6xxhKdn3bmpR8of/oe+fkYhRM7Atar00BhFFQILlISm7LPmICl0K+v?=
 =?us-ascii?Q?RaXRWleeHWZ9OQ1/kL135chwhCaro3hqdZX+LIU4a7LSViPCmY9aajDKOuQr?=
 =?us-ascii?Q?7pqqOn/Hx7lcHScU2Rm8l3zvYa+Xl2psFe3nnUk723fwyOq8D++NSBNc7Lwo?=
 =?us-ascii?Q?0yLm27pSKWaJU0fF4RfIveM3Uf1vTJkjIMwnWMT6zZ1z4TMsp4w4Q0p0Ng1s?=
 =?us-ascii?Q?H4ZLXh2UIgnG35obi9MNr57PT1hFco6OOGsNFEgl9CWENIgQW84r8mLjT8/2?=
 =?us-ascii?Q?zIegNyxId45qgK5NI/0au14YaEPdlsa8Jf46XItQdRAX35zra0njk84a/J3q?=
 =?us-ascii?Q?Iyqvg9H/26yCpD2mCTYz0o4SkPPhjpM8rbbKeG7YsSK+9C3OPzY4FrQmHR2S?=
 =?us-ascii?Q?kl2yhl1mTjMflN3N+zddgnHnKU4O8QjvZZthU1m617MVlDmtV9PIsSFRkiky?=
 =?us-ascii?Q?Y2mZQ22Sgtb0AbcwmbODELd0t6oDjXOBSMLluq0dKX1MbwNgpN5Lj/yvS66d?=
 =?us-ascii?Q?ceBb6XDvi/yz6VlWdCmeIkK2xwBxBysLixJO6LNDD4quup6CpBCodTyH2+/N?=
 =?us-ascii?Q?iNOTl8EtXexRGBgUB//JK6Wu5mdWK0b5vOdwSQEDiZei/HpLOhz4/jN662ix?=
 =?us-ascii?Q?OHav+58p3/HvX4Kc9eyTPyN3J/F9hWh7dHpZBGvQe+9Ml49SsYop5O3B5v4g?=
 =?us-ascii?Q?fy2g0B3XGs0k5/dcyFeUGAP5ABGyGiIdGbay/3l1z4kt3HYOkiDJc9ZprBGE?=
 =?us-ascii?Q?so7cOMa3hNIrgOyx4M5iL+eEzafAkO/5PbDX722hwPiWcgoUs/8ob+qnSKJl?=
 =?us-ascii?Q?lUEfbNxDuh3J2WOpqx1XEIaPeerPJRTbvl0QM64xYWvz77YRnPp8YddFAz67?=
 =?us-ascii?Q?DaClahvKiHgLdBVkpOP8dWthrGRNA+n1RUDOOo+AodhEmumHVLk33cSytWDY?=
 =?us-ascii?Q?BSc1Oa8oPMGSjEHiB23D5YBAHhOSKP8bk3t49uudHuz/huBTYLS8CALAsGjk?=
 =?us-ascii?Q?JDD3zxeIxDY05q4aLAKO1D2BSDdm/milCsFSo2tHJ2D3KN/pYaLm6QxTHSar?=
 =?us-ascii?Q?PGHHz4m+L05TsdqMC1e1BNmVoIKud2ePNYS7oWEat8NsmrAGjU3fKjg27xoW?=
 =?us-ascii?Q?M2aLbFVwDpYXrLmg7oJRmNb1ApiWtNgYqczQRz8EVpsjH1xhS6Qhos1fGrg5?=
 =?us-ascii?Q?dFJ8cMMTCw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <28DB73FA10085D489EF7248291512C77@eurprd06.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: tuxera.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR0602MB2893.eurprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 431770ec-fc16-4194-8052-08da37fe223d
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 May 2022 12:09:46.1554
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: e7fd1de3-6111-47e9-bf5d-4c1ca2ed0b84
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: B6WvdmcLBJHg3BUIij47c6RKv7Gbdcr3c0/sMczX69ab1g6B5Lg4cBxXxx8jDNBCrFWjUdk5Qh+MEm+yAaLVfg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR06MB3034
X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_INVALID,
        DKIM_SIGNED,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Andrew,

Please could you merge this?  Thanks a lot!

Best regards,

	Anton

> On 17 May 2022, at 10:36, Colin Ian King <colin.i.king@gmail.com> wrote:
>=20
> The variable idx is assigned a value and is never read. The variable
> is not used and is redundant, remove it.
>=20
> Cleans up clang scan build warning:
> warning: Although the value stored to 'idx' is used in the enclosing
> expression, the value is never actually read from 'idx'
> [deadcode.DeadStores]
>=20
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Reviewed-by: Anton Altaparmakov <anton@tuxera.com>
> ---
> fs/ntfs/file.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/fs/ntfs/file.c b/fs/ntfs/file.c
> index e1392a9b8ceb..a8abe2296514 100644
> --- a/fs/ntfs/file.c
> +++ b/fs/ntfs/file.c
> @@ -1772,11 +1772,11 @@ static ssize_t ntfs_perform_write(struct file *fi=
le, struct iov_iter *i,
> 	last_vcn =3D -1;
> 	do {
> 		VCN vcn;
> -		pgoff_t idx, start_idx;
> +		pgoff_t start_idx;
> 		unsigned ofs, do_pages, u;
> 		size_t copied;
>=20
> -		start_idx =3D idx =3D pos >> PAGE_SHIFT;
> +		start_idx =3D pos >> PAGE_SHIFT;
> 		ofs =3D pos & ~PAGE_MASK;
> 		bytes =3D PAGE_SIZE - ofs;
> 		do_pages =3D 1;
> --=20
> 2.35.1
>=20