Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 17 May 2022 08:55:28 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc:     dsterba@suse.cz, Qu Wenruo <quwenruo.btrfs@gmx.com>,
        Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
        David Sterba <dsterba@suse.com>, Qu Wenruo <wqu@suse.com>,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
        linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: Fix an error handling path in
 btrfs_read_sys_array()
Message-ID: <20220517055528.GO4009@kadam>
References: <d915ceb4d459aff89c0264113db21592a6806db1.1652517184.git.christophe.jaillet@wanadoo.fr>
 <120e4c34-da48-7d86-4a50-c31a3804600d@gmx.com>
 <20220516135407.GM4009@kadam>
 <20220516150148.GX18596@twin.jikos.cz>
 <bbabdbba-9700-2cb6-beac-6566fd84ee3d@wanadoo.fr>
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <bbabdbba-9700-2cb6-beac-6566fd84ee3d@wanadoo.fr>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?tA7uJErrh+soiTUno36WQVA8XE2ECzVYZNm85O3lm7RJ5seykWQGepTJkR?=
 =?iso-8859-1?Q?94guMhNVY+Ji+sH7+AM19HDbrBJDm+/KMz3TPQSj1dsJh7wPZGJrIvpyQe?=
 =?iso-8859-1?Q?rzsrpuhWJdiPfN+dR8B+R18Nu+UD/fqj1dqjUVZcKmMHuCj/9jUaH3hfYn?=
 =?iso-8859-1?Q?nVtpPrmmshMthQZsWJVuHzOsbxt9m4kg3bnicJMsXPKivkbgn7u6Y/wiBA?=
 =?iso-8859-1?Q?ZO47z4xGvAOu7yr7bzkXnrouLoEktbh5Q77FqMEp0wQWQhmEJy4eEQsWpo?=
 =?iso-8859-1?Q?vrLXkIAI3NQR6O13zjEN+TqBpW4WFdD1EAVdeUHYePCCdI+hzHT3lsprez?=
 =?iso-8859-1?Q?8EsN/MajMMDJIkEPBXYrilEcc/ENetVnaoGPFp01IQYuakFp4OZY6NKV7v?=
 =?iso-8859-1?Q?pA6UK5Yy9zBgWy3ulw6UZ/+X0ET7MBjFbBFaNb9DK/vCBfHxR744g5z/mm?=
 =?iso-8859-1?Q?jduXlzwGfkvNqsCm0ePr3fo8I3w5kwf1SV+JQjaSIWWc/zFnIX8tXRT6TY?=
 =?iso-8859-1?Q?WYfQh/LxCL096ApUHzIeO+vZtW7YrYeh5dmGiOCR3Yisml6PrgQXD+nJ0C?=
 =?iso-8859-1?Q?+/ilpqVN5bBYFuBdrnQAWy9bfzbOt+yMTXm1yhKofMDjXB9HE022a3WXni?=
 =?iso-8859-1?Q?P8ENzfWUIFKDAIxEXqJKkvpV3aZn36vWDTxVdc65BcUXgsw/e45qQt6eWw?=
 =?iso-8859-1?Q?14tZdfc7vn3qlUkTjR+ZYXbPsFzlyNQ5FIAo5R+6HMvzgBb+LQm47eqZC6?=
 =?iso-8859-1?Q?iT07DqVxDWabDblD+99OCcB77QiZH+L3TS+908e0WmZGV3u0JC7SL8umgn?=
 =?iso-8859-1?Q?v3c66wCTQVHMqkWBJDs5mse7KvLvFK687b+YSrqSNVRw0PmySYotcrAbLo?=
 =?iso-8859-1?Q?UTyrcWwmnz/Xylin7NUGcD3r/p39NhY34frYv0qskYI5AAiOf+U2tFp9Xy?=
 =?iso-8859-1?Q?EI2bZtVV+3p7+5KwInYDuqOEQs84Zto15WBs3eLWrtXl4YC0aaruCtC/pH?=
 =?iso-8859-1?Q?dbGI5k7JFXIOXnw583mbpUz9trUwmZSTHIjWnEznYYoZ3yPw+4KQz9+xCT?=
 =?iso-8859-1?Q?RfpNQE4CgAfLjY0zXjrDPqeBfe5Y2wxnAj+SIgY5YVDr2PBB0kon35xS6V?=
 =?iso-8859-1?Q?96vxtsCqqqa9rPCLSKnYTdA/Li8a4+hPx8y2nSPQPKwIRSTAhtu9VifdpD?=
 =?iso-8859-1?Q?NuwEAQEmQg0qCSLvWikrMA9HT14xJ3mScKHsO05AMASo9Nrq62gkKPnpWm?=
 =?iso-8859-1?Q?EvavPqXQMAtBSt2eCGlaZ5f6m8lIHnW7TT4fLaBOPcCENfx41r4r+r181W?=
 =?iso-8859-1?Q?bb4tR/YVMmbaZHB6OzIggZZVlOhnE9qtA5QpmCD03k7qO5/nJ77WphYfKM?=
 =?iso-8859-1?Q?0JHVXSHQ21E1A+P+pWnjJLhrNmmxmOQqyBCRak/WFIvSuLR7qka1U5LBHn?=
 =?iso-8859-1?Q?2s29J0dVWgThzuvX07GEI0LxUTS4F+EuYeolKcsJhbveuu39VvJ+VYvkrW?=
 =?iso-8859-1?Q?Vxf8vOpOz6qljCMlMBO9XsRyOCBgNaftLUtS4zYPkdGPpDXrwoTRYB88E1?=
 =?iso-8859-1?Q?EG5AWuQpU8eoO9oe1WHMnLYDvwnfdlVvNm8b75Q/9QiKDpqgaSz1TOrgMA?=
 =?iso-8859-1?Q?mkRM1s9RRyi+s9DNJFgbV+UUAztUnZpeqr5BhrSxIMkHufQ9RW8eFW5HWc?=
 =?iso-8859-1?Q?waAyJ7hALG67+blkPgbSmV0sgnmc8M8MDchEtb1OV3CweVLv0M/0fbMnz5?=
 =?iso-8859-1?Q?sto9vqjBsTd5n5lASnxj7abyt1aqLV/z9UcQbuWhH5AIbsg+JmGYx4Nn8m?=
 =?iso-8859-1?Q?H134X9draSAjVDBL2yFtv0JKZfAyD5o=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fd15425e-be95-4fcf-eb28-08da37c9defd
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2022 05:55:39.8451
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cv5LjV1vcRfJXtZ8ULu1r/TRbUk8G2JH6saQIbG4+kKpiJJs9pnQ2FSjU1s03OcyVB7GVk6JJfw5hq6D1W1A6+I7wjopIl/pwCJ5X8q5QBE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4526
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-05-17_01:2022-05-16,2022-05-17 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0
 suspectscore=0 mlxlogscore=812 adultscore=0 phishscore=0 spamscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2205170034
X-Proofpoint-GUID: 0OH5fvNZrPLjKLzOzxhpu_Md5trYD9sI
X-Proofpoint-ORIG-GUID: 0OH5fvNZrPLjKLzOzxhpu_Md5trYD9sI
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, May 16, 2022 at 07:42:23PM +0200, Christophe JAILLET wrote:
> Le 16/05/2022 ? 17:01, David Sterba a ?crit?:
> > On Mon, May 16, 2022 at 04:54:07PM +0300, Dan Carpenter wrote:
> > > On Sun, May 15, 2022 at 06:57:25AM +0800, Qu Wenruo wrote:
> > > > 
> > > > 
> > > > On 2022/5/14 20:01, Christophe JAILLET wrote:
> > > > > If alloc_dummy_extent_buffer() we should return an error code, not 0 that
> > > > > would mean success.
> > > > > 
> > > > > Fixes: a1fc41ac28d3 ("btrfs: use dummy extent buffer for super block sys chunk array read")
> > > > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> > > > 
> > > > Reviewed-by: Qu Wenruo <wqu@suse.com>
> > > > 
> > > > All my fault, thanks for catching it.
> > > > Qu
> > > > 
> > > 
> > > I sent this patch in January and David was going to fold it into the
> > > original patch but it got lost.  Thanks, Christophe!
> 
> Hi,
> 
> Not exactly.
> Your patch was:
> -	if (IS_ERR(sb))
> -		return PTR_ERR(sb);
> +	if (!sb)
> +		return -ENOMEM;
> 
> Mine is only:
> -		return PTR_ERR(sb);
> +		return -ENOMEM;
> 
> So for some reason, what you had reported was just half applied. (or half
> fixed by someone else)
> 

Oh that's interesting.  I must have seen the same Smatch warning that
you saw and ignored it because I got confused which patch I had sent.
The kbuild-bot also tried to send a warning, but I squashed it for
the same reasons.  So in terms of process issues and avoidable bugs this
one is partly my bad.

regards,
dan carpenter