Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 17 May 2022 15:30:35 +0200
From:   Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>
To:     Marvin Lin <milkfafa@gmail.com>
Cc:     mchehab@kernel.org, linux-media@vger.kernel.org,
        linux-kernel@vger.kernel.org, kwliu@nuvoton.com,
        tmaimon77@gmail.com, avifishman70@gmail.com,
        openbmc@lists.ozlabs.org, tali.perry1@gmail.com, kflin@nuvoton.com
Subject: Re: [PATCH v2 5/5] drivers: media: platform: Add NPCM Video
 Capture/Encode Engine driver
Message-ID: <YoOje2L13q7d7KeI@latitude>
References: <20220513033450.7038-1-kflin@nuvoton.com>
 <20220513033450.7038-6-kflin@nuvoton.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="3VOuve4DtZAiUNkh"
Content-Disposition: inline
In-Reply-To: <20220513033450.7038-6-kflin@nuvoton.com>
Precedence: bulk


--3VOuve4DtZAiUNkh
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello,

first of all, thank you for bringing this driver upstream.

On Fri, May 13, 2022 at 11:34:50AM +0800, Marvin Lin wrote:
> Add driver for Video Capture/Differentiation Engine (VCD) and Encoding
> Compression Engine (ECE) present on Nuvoton NPCM SoCs.
>=20
> Signed-off-by: Marvin Lin <kflin@nuvoton.com>
> ---
>  drivers/media/platform/Kconfig              |    1 +
>  drivers/media/platform/Makefile             |    1 +
>  drivers/media/platform/nuvoton/Kconfig      |   12 +
>  drivers/media/platform/nuvoton/Makefile     |    2 +
>  drivers/media/platform/nuvoton/npcm-video.c | 2074 +++++++++++++++++++

Similar to what I said in reply to the bindings patch, I would prefer to
have the VCD code and the ECE code in two separate files, if possible,
to make reuse of the VCD code alone (on WPCM450) easier.


Best regards,
Jonathan

--3VOuve4DtZAiUNkh
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEvHAHGBBjQPVy+qvDCDBEmo7zX9sFAmKDo3oACgkQCDBEmo7z
X9tGUA/9GUVxyvf/HAB4kiy11NzJXBaicRH/U2S6qRig8krgDAFPLqMEXqYjJ5/c
mSKzlkGvszm2+cL76YR68BZDM+FJh+S6Flgc4sHSzIC/2FQrFQGnq8eswjHb/75V
sbCOfv2NU8SUUJXcXzliAZGaINdUGRs3blj5FdjkVohne6UMg79Yf4ntZvaOMT2w
VfzGU0m6NwbCUuNutXwshMTcjtxZBvQVvn+Hrd8qSNHjGerOW1aDBWhqjZf+bwpU
3GqTKRLqZ0hCCWjuy5kwdfBUDzhAayDZDu3bGNETOe24nbpSwlw1XCIb4DFSYRER
5phoS7KMlqUrqKKK214EfACd10h49FI+XQo8LZmDksioKfV1OcQwgqw46ztoD3lI
WUNKdVvkZ7TPC1QQXqVvdU7ok6z8AHaTwj+k7r6UdfqzBVyUr37ubQs3Kd/EsvFg
i5x/POh9qRXQzvoNjmLph9IJStXjR+TrVJWpNrolg5CaCd/0EOuLT/hzOqPYa5Ru
sDAmUv67rJ1d0Fq4OYkTW0qMSL073gQN+pt49kMOQ5qrdR2CfQzAYkGj26fvvuSz
zkQN+yWhHLzk2/gU7NDhBupFVuINOEOCPvKZdz84RD2IZNmqGDlM6xbUO3Iqfugh
QpuHolZYKLxgylm6yRR8NC75gpt5S7ZSMrBY49+3FNWq7lMdrRU=
=chtA
-----END PGP SIGNATURE-----

--3VOuve4DtZAiUNkh--