Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 17 May 2022 15:24:34 +0200
From:   Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>
To:     Marvin Lin <milkfafa@gmail.com>
Cc:     mchehab@kernel.org, linux-media@vger.kernel.org,
        linux-kernel@vger.kernel.org, kwliu@nuvoton.com,
        tmaimon77@gmail.com, avifishman70@gmail.com,
        openbmc@lists.ozlabs.org, tali.perry1@gmail.com, kflin@nuvoton.com
Subject: Re: [PATCH v1 2/5] dt-bindings: media: Add dt-bindings for NPCM
 Video Capture/Encode Engine
Message-ID: <YoOiEtY822XQ+JYl@latitude>
References: <20220512072722.25005-1-kflin@nuvoton.com>
 <20220512072722.25005-3-kflin@nuvoton.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="kYh3ep2r/8CyteCm"
Content-Disposition: inline
In-Reply-To: <20220512072722.25005-3-kflin@nuvoton.com>
Precedence: bulk


--kYh3ep2r/8CyteCm
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

since the WPCM450 also includes a VCD block, I'd be interested in
reusing the same bindings and driver there.

On Thu, May 12, 2022 at 03:27:19PM +0800, Marvin Lin wrote:
> Add dt-bindings document for NPCM Video Capture/Encode Engine.
>=20
> Signed-off-by: Marvin Lin <kflin@nuvoton.com>
> ---
>  .../bindings/media/nuvoton,npcm-video.yaml    | 87 +++++++++++++++++++
>  1 file changed, 87 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/nuvoton,npcm-=
video.yaml
>=20
> diff --git a/Documentation/devicetree/bindings/media/nuvoton,npcm-video.y=
aml b/Documentation/devicetree/bindings/media/nuvoton,npcm-video.yaml
> new file mode 100644
> index 000000000000..b5be7ef09038
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/nuvoton,npcm-video.yaml
> @@ -0,0 +1,87 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/nuvoton,npcm-video.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Nuvoton NPCM Video Capture/Encode Engine Device Tree Bindings
> +
> +maintainers:
> +  - Joseph Liu <kwliu@nuvoton.com>
> +  - Marvin Lin <kflin@nuvoton.com>
> +
> +description: |
> +  Video Capture/Differentiation Engine (VCD) and Encoding Compression En=
gine
> +  (ECE) present on Nuvoton NPCM SoCs.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - nuvoton,npcm750-video
> +      - nuvoton,npcm845-video
> +
> +  reg:
> +    items:
> +      - description: VCD registers
> +      - description: ECE registers

I'd somewhat prefer if these were actually two separate devicetree
nodes, since there are two hardware blocks and two register ranges.

This would make reuse of the VCD binding easier on WPCM450, because it
doesn't have an ECE block.


Best regards,
Jonathan

--kYh3ep2r/8CyteCm
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEvHAHGBBjQPVy+qvDCDBEmo7zX9sFAmKDofIACgkQCDBEmo7z
X9uXtQ//ezRzp0TGXgDyumHGdn89+Zb5LoXLRPBpknkiIhQ2Ozc29lC5k12ABrAH
HOu2tBhB+JlweLPJkNQIm5JQtFmIqG4fwU97jRiKbnbDDptacAnR3WOTwcHipiLr
kfTkeEOFQZ2XuznwbMtI16Rg32AhbKLkHTmWd70zsZzmdEz3RMMOs6jCtSlz36Zt
UxUm+Egq8JD2TgL2mTorTHdbZEhx6MUBu5ByQWk/ljAPSQHpz+PDf9VEzfgb+4Bs
N03rJUT8ns2xrtw5JI5UBxNRii7YSD+qsG4RXYjo9yjpjtf4Lys3LzKnivDP5+0l
2KXsby8vPrhNvTO+x5YGvU0dE7LVXoX/xqjIq8csod6Kd6ZNNBE+OaQ832+e+ZB2
d1Xso9HRtaih3YE/M9IvR0x0k8hfAePjJImlfBBcjqlQmGFT+h1rEfBez1SrACtl
mUpLcnAEZfm+qrpTpMLoDsZxIcZoyJZ0fej9IvTuRcCjk4Dwx54OS9AxHY4HD4GN
Mjhc6ZwGONbcqYh1iZ8thWYY4natr2wh4tNJ3UJbZwtqbFqUD0ze3sm7hdjpnC5m
3PikvXzyg3GALPBUjRj+FfWVzSDxRZ0w6t15C0ynZlW8pl419yzsMf2MWtjOkA/d
ZZrBqwgv3zqNZseitWyJ2HsOoWZbRWXOanBvd5zclk1EvZQVivU=
=RkHI
-----END PGP SIGNATURE-----

--kYh3ep2r/8CyteCm--