Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
To:     Pankaj Raghav <p.raghav@samsung.com>,
        "axboe@kernel.dk" <axboe@kernel.dk>,
        "damien.lemoal@opensource.wdc.com" <damien.lemoal@opensource.wdc.com>,
        "pankydev8@gmail.com" <pankydev8@gmail.com>,
        "dsterba@suse.com" <dsterba@suse.com>, "hch@lst.de" <hch@lst.de>
CC:     "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
        "jiangbo.365@bytedance.com" <jiangbo.365@bytedance.com>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "gost.dev@samsung.com" <gost.dev@samsung.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "dm-devel@redhat.com" <dm-devel@redhat.com>,
        Luis Chamberlain <mcgrof@kernel.org>
Subject: Re: [PATCH v4 06/13] btrfs: zoned: Make sb_zone_number function non
 power of 2 compatible
Thread-Topic: [PATCH v4 06/13] btrfs: zoned: Make sb_zone_number function non
 power of 2 compatible
Thread-Index: AQHYaUWnfgxv+u/BDkiy20kzzzkazg==
Date:   Tue, 17 May 2022 06:53:40 +0000
Message-ID: <PH0PR04MB741673F9764EFCA93F1932809BCE9@PH0PR04MB7416.namprd04.prod.outlook.com>
References: <20220516165416.171196-1-p.raghav@samsung.com>
 <CGME20220516165427eucas1p1cfd87ca44ec314ea1d2ddc8ece7259f9@eucas1p1.samsung.com>
 <20220516165416.171196-7-p.raghav@samsung.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 2
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?9ot6Frx+D7LF9ROH4NIBfvSsW/jPWplk9rG4i3xC9nNksOr2f9C8ui3kCacG?=
 =?us-ascii?Q?evHhnxPim+8449MFXNdNZMdjL3YzSCY7majK2FqWwW3FcaEMDAPzIBnotwdY?=
 =?us-ascii?Q?/+ppZ0E5lJqsBexNBfXJGUYfFX1AUp0UwcXF4PGrdmUY4wAc5VotuGf1g151?=
 =?us-ascii?Q?IZf01U6L9H3lth4FFM6qvIwye2juf0vuLnmdt0QzPHqTxMdNiCsAmsbPAxmC?=
 =?us-ascii?Q?z761X5r5mWjnMvlO4tdZGN++6b+JdQy7v+z/Ti/9hII+027UUmc1LBa5MsE1?=
 =?us-ascii?Q?nej4BpWe76kv8qIFI8/CjKuypSQG3Wucpkf1e1gQ7D/bXH8YR3QAptJrqkCU?=
 =?us-ascii?Q?Xk5Cuq1Ab3V06ATJ0zo8GZMHAqyB7KlOIDIi+DO0nM6mqSKKNpytW2TJFag4?=
 =?us-ascii?Q?anxD1KVY2tbYAblHAc8NE3QECm5LrfNr/0bW0afQ/BMhSyj/ryJzY9ZuKgEa?=
 =?us-ascii?Q?9i6lv00oMfJEr5n1VoXXjxNLTfsS461BgAM11x3cwvHK4e5ivNewioc6gQV7?=
 =?us-ascii?Q?dBlejXapDpkqvMxgH9aWHCuJMkOgZFpS73IKxv+2hbhyTZQR0Ajed1vSIEj4?=
 =?us-ascii?Q?EPfH8U0r9Poql61LxZzkr28SqkxqYczt9NsXJTAWBoyeseNa974TaN3GmyNV?=
 =?us-ascii?Q?O/Ca1ez2Tz5vo5abuhQJZcWOxFos8silW7KHduT9hvt0hl0lWgSEovsqeVC2?=
 =?us-ascii?Q?Yr0bLV3B0tXKs+08m5RXBXtle5lYB6or6fPyLlF8tb56hKqUqdEmgyx9rnwk?=
 =?us-ascii?Q?r9ObM6kKlf837oMQzeD717hBLTgm6xUbkTQHM9R0xUdoklzVSlL2X6gltzKf?=
 =?us-ascii?Q?0nF7vB6MFmK8ABj+0c2VCHzYLylRqTZ1/gde4fkbVdHGHrFBUzrZrCQI0daU?=
 =?us-ascii?Q?BfwFn9U3kn7O+NsUNaH7zjdqMb7Uj6bgVFNNmbEw9yKvcfCoJW0DqYbF1uM9?=
 =?us-ascii?Q?hdrRzyAI2QgPX8i3Ly0EghOxJOAARR0cBgMSXkNPbD+8bX/T99zBTQSMkpuL?=
 =?us-ascii?Q?X69pZFidRKsGBh17dnDIBwf2hjqcJNRu0iwRUv7d5mCIj5yXZrOwJwFJkDdv?=
 =?us-ascii?Q?dxG9rCaPhPh78acHe35ehruqpYi16zmmOiC96p0BmayXxOD49dV/k0sSnh/s?=
 =?us-ascii?Q?I0DAKp8d7nUgiGA/ajS5h474xolrtSkXb//iU8o8V00gvamQgKGOMit+QkCe?=
 =?us-ascii?Q?MScP92fd1x9DUFPr3Xfl5QGHvNUp64hpW27j7jF3T6c+TIGESq621Q3M1jhs?=
 =?us-ascii?Q?0PBmZIHzkVYC41AlKQuUbA39B0uSVFELB5SM475+4dEahsNL74mk2+iCyGZe?=
 =?us-ascii?Q?IrCdS33xav/Z7R8ID2Y5Vaeqia4TejKmAgVXb0wqFcS73gBGT3wKCsnSgLTY?=
 =?us-ascii?Q?oNLww4ryvlESMHzhFwdBAQC5ohassbd5VuWRssDGJVY7zyZdlpSyhlG03Eaz?=
 =?us-ascii?Q?+GNm6v4B5FnN3jY5FpIIF41J0xrMDYZPF3mlPkXZTFqSmxtMbtHVZKFgmNJD?=
 =?us-ascii?Q?NilXvhScagGJV6i59qa38gFVWK8+aF5IHdWbKIHDIRvj6p3nsNLZJDfk2djW?=
 =?us-ascii?Q?YszeABB3CFAMMBx+aO3IqJ97Z4RExS4q/4M+5PxQFPQgcq+kSRbD+9jnpPa6?=
 =?us-ascii?Q?eEsYIlOqxyYr0ZwZU7kXMwAvU0vBw71bnEtradotKLm221l/Cg/IHkgO94+1?=
 =?us-ascii?Q?gRqb/NPxIne4rJh3KNeRYZ+69SKMFPvcCQewdVY1xi+606bywNgJYwf24Qz9?=
 =?us-ascii?Q?XOVFdDyEzibqjFmTWTbtL1kpmwE5ruatxX2fofeQ8voa6C2GB14PzRSzxGvE?=
x-ms-exchange-antispam-messagedata-1: ajreH7aLRyqHTJIkwRTJxnz29tvgNl9nUzwTyDqADyFYMyI2onl963AF
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR04MB7416.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 883b5050-2326-41ad-b1de-08da37d1f9f0
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 May 2022 06:53:40.6871
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: +wqm/sFYx+iNsRlhyo7IvZ6/835EFHPrVZMx6wHK0RuxnIJlGXvfw/IlGQtqpBFpFFt3NzMvikciCM7JKwp7uZQX0zrR01tBk+GgjSzjVDI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB5337
X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 16/05/2022 18:54, Pankaj Raghav wrote:=0A=
>  	/* Cache the sb zone number */=0A=
>  	for (i =3D 0; i < BTRFS_SUPER_MIRROR_MAX; ++i) {=0A=
>  		zone_info->sb_zone_location[i] =3D=0A=
> -			sb_zone_number(zone_info->zone_size_shift, i);=0A=
> +			sb_zone_number(bdev, i);=0A=
=0A=
I think this easily fits on one line now, doesn't it? But given David's=0A=
statement, it'll probably can go away anyways.=0A=