Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 17 May 2022 21:53:26 +0800
From:   Chao Gao <chao.gao@intel.com>
To:     Sean Christopherson <seanjc@google.com>
Cc:     Paolo Bonzini <pbonzini@redhat.com>,
        Zeng Guang <guang.zeng@intel.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "Luck, Tony" <tony.luck@intel.com>,
        Kan Liang <kan.liang@linux.intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Kim Phillips <kim.phillips@amd.com>,
        Jarkko Sakkinen <jarkko@kernel.org>,
        Jethro Beekman <jethro@fortanix.com>,
        "Huang, Kai" <kai.huang@intel.com>,
        "x86@kernel.org" <x86@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Hu, Robert" <robert.hu@intel.com>
Subject: Re: [PATCH v9 0/9] IPI virtualization support for VM
Message-ID: <20220517135321.GA31556@gao-cwp>
References: <20220419153155.11504-1-guang.zeng@intel.com>
 <2d33b71a-13e5-d377-abc2-c20958526497@redhat.com>
 <cf178428-8c98-e7b3-4317-8282938976fd@intel.com>
 <f0e633b3-38ea-f288-c74d-487387cefddc@redhat.com>
 <YoK48P2UrrjxaRrJ@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YoK48P2UrrjxaRrJ@google.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Mon, May 16, 2022 at 08:49:52PM +0000, Sean Christopherson wrote:
>On Tue, May 03, 2022, Paolo Bonzini wrote:
>> On 5/3/22 09:32, Zeng Guang wrote:
>> > 
>> > I don't see "[PATCH v9 4/9] KVM: VMX: Report tertiary_exec_control field in
>> > dump_vmcs()" in kvm/queue. Does it not need ?
>> 
>> Added now (somehow the patches were not threaded, so I had to catch them one
>> by one from lore).
>> 
>> > Selftests for KVM_CAP_MAX_VCPU_ID is posted in V2 which is revised on top of
>> > kvm/queue.
>> > ([PATCH v2] kvm: selftests: Add KVM_CAP_MAX_VCPU_ID cap test - Zeng
>> > Guang (kernel.org) <https://lore.kernel.org/lkml/20220503064037.10822-1-guang.zeng@intel.com/>)
>> 
>> Queued, thanks.
>
>Shouldn't we have a solution for the read-only APIC_ID mess before this is merged?

We can add a new inhibit to disable APICv if guest attempts to change APIC
ID when IPIv (or AVIC) is enabled. Maxim also thinks using a new inhibit is
the right direction [1].

If no objection to this approach and Maxim doesn't have the patch, we can post
one. But we will rely on Maxim to fix APIC ID mess for nested AVIC.

[1] https://lore.kernel.org/all/6475522c58aec5db3ee0a5ccd3230c63a2f013a9.camel@redhat.com/