Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6a6b9fe4-d588-1150-5f83-d91c91be9924@axentia.se>
Date:   Tue, 17 May 2022 14:00:49 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH v2 4/4] mux: lan966: Add support for flexcom mux
 controller
Content-Language: sv
To:     Michael Walle <michael@walle.cc>
Cc:     Manohar.Puri@microchip.com, UNGLinuxDriver@microchip.com,
        alexandre.belloni@bootlin.com, claudiu.beznea@microchip.com,
        devicetree@vger.kernel.org, kavyasree.kotagiri@microchip.com,
        krzysztof.kozlowski+dt@linaro.org, lee.jones@linaro.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux@armlinux.org.uk, nicolas.ferre@microchip.com
References: <e43d766f-ec63-93d7-6b19-05b32579e6e3@axentia.se>
 <20220517115327.4139280-1-michael@walle.cc>
From:   Peter Rosin <peda@axentia.se>
In-Reply-To: <20220517115327.4139280-1-michael@walle.cc>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MGN5cEVvdldOSU5sV3V2K1FXR1Z4WnloSWRlS01XZFo1Z2Z5UEpaK29DNEdX?=
 =?utf-8?B?V0VON2pmZ1hkQXo1a1Jxenk1Q2xaekNiM0s2ZTJOK0JVM3Y4WE5RNWhrVnEx?=
 =?utf-8?B?Y0pKejRQVC9naTBJQ2psTnhnc1RaZmh4ekFZVU9SVzRaV3o1dC9BckRTUHNU?=
 =?utf-8?B?THYxWXpEV3pqcHpDbWFPRWU4SlU1RlFqc2h3Y04zam80OGVyVll1MktwK2s2?=
 =?utf-8?B?cm13L1F0R2pjcmY1MFR6dDZQZkZvb2R4ZnRCUnhZa1V2NGFDNk9zOTdncW94?=
 =?utf-8?B?K3BTZHQ3VjJOWG1LeWovR0VhYTFsZ05wcEgxZ08zK2k5U1JTZ0I1cEJmT1Zm?=
 =?utf-8?B?ZnR6Z05MalhiRmVwRUlMUUM3cGI1RFhsNUZ5MXZBclA3WmduT1dYWlMwNzlv?=
 =?utf-8?B?elJiSTBVSDlqcmpGMGV0WXpuNXo5LzBXcy9vbE9zbVRaWDBPaTRGbmZEdVFu?=
 =?utf-8?B?bVQ3UFVocFlVbUlYVXFzcHpVYjhqZWdFMGpWZEFJV256Wk94QU5xTVY4UjVC?=
 =?utf-8?B?dnVFL1czM0owZGZsNERYeHpRYWdGOXFiUGl0NnM4Si9pQ1JsNk9YSm0wZVBa?=
 =?utf-8?B?cE8vLzVDUXV4ZENqUmlaRGt3SW1Ob0U3anlCZzV3UjlmSlpwbXdxUlJOL1l0?=
 =?utf-8?B?VDMwRkhGNkJucVJoRVAxNkpzdy9tNzFqUHFTYkZUUk5BbytpdkFiaTNVcm1n?=
 =?utf-8?B?U3ZiRnpLYzFZVHJuSHVkTHI5SzNnQVZtKzZNTjB3Y0k3OHIwU2diV2x2aUFK?=
 =?utf-8?B?OXVUZjhzUHdUei9CUjRwU2dYK25TdjBXandmTzN0QjduM1lCb2lObTRLRzZR?=
 =?utf-8?B?Mk5seHI5eUFQNmttOURrYnlYMi8xQ292OEx0UzZLYys2QStVejlIU0VzZ3ZM?=
 =?utf-8?B?UkUwWkxQWXdZbnl1bHNJaklXbnBaUWwwUno5V3BVWTV4TXZYQjhyU0loNmsw?=
 =?utf-8?B?ZUJBVWx6ZlBCcW8xNmhyUHhRdDA2YXI0Ykc0OEZXbTUveThoZ0JhUU5YTGo3?=
 =?utf-8?B?UTRGMXFydmZTUGFyaW1UOWQ0M2k3NDJYNEtJZ3FtODFLV1hic0o2dTNhOHV4?=
 =?utf-8?B?dE1WUVUwUlZ2SGdsdEZSdU1tWk5mMlVRSWI4eWEzUDlFTGRuSzJPbEVnYmZp?=
 =?utf-8?B?dWpCWHlzNm5tZFJtdHNidTAvbHVwS1p1amptR2RybFFQbU9qamFJM0tUaUhH?=
 =?utf-8?B?b1JpTEhLUldKek1meHF6WE5Hb0Y1K2FxRjNKZTR1UitKYjRWSnFSZXU3R05T?=
 =?utf-8?B?MFFnQTZTZkxtZzBUODhyZkQxQllnUjdYR3FxOVBIcHg1dzhVN25TaTBMeWFH?=
 =?utf-8?B?NlRCb3lFdGRJTmdiU3pIV0hBR0RPcm8wSm9SWWRzZ3cwMkVROTZpYnlwdXFY?=
 =?utf-8?B?bFBZMm1HN0xZcy83bHFyZ0NORDJWUTZ2c05OaVhqNTI3VFVHN21wN2J6bEp1?=
 =?utf-8?B?bEVPRXV5ZFBKUlpFZFRzOFp4R25jcTZyeW55aUJEMmh3c1Z5bkVqc2FrLzVy?=
 =?utf-8?B?SHovQytpY1k2RlZQb0RtUU9sU3hoRWdrSjJsZThDdEx6b3cvdGdGVFcvVm5D?=
 =?utf-8?B?b3MzUzBRZnI4ckVGR1lWYmYyV3B4MnpjMDVEclJ2R2g4eWYrVnQ1Q2dESk50?=
 =?utf-8?B?RFUxOTcyb0Q1ck5BSjBnYXlqeUZkbjFDczkwblJUVVd3MVNNN3FWU0tBSTlz?=
 =?utf-8?B?eVY1SWNBZWRXMExOTEhueHM4ZVN0ZHg4QnJOYzZUczRzZm1KRG8vMzFKNC9Q?=
 =?utf-8?B?aytSOFA4R2h5U2htMDhhZ0NxR2dsbTdSQkJhYjhncCtOUnlKUDhHZEk4QjJP?=
 =?utf-8?B?VFB1VGd4cWNVQXpZZStHOCtrcTg1ZXMrTTE1dW9tNHBKWTlFMGQrcUJHeEtX?=
 =?utf-8?B?aVBCSHc2eEJ5U3ZYZTNoUnkyem1kaldFcSs4NzIydEtQUVVhU0Q1Nm42d1lQ?=
 =?utf-8?B?L1NGbnI2TDJKdXgxcFBGNXBsam9jVy84aDBIbkRydkV3Y0o2MWZVTTg4eUhC?=
 =?utf-8?B?dXdNUk52d0V5YkhaQmI5RkxxcVBSNElaNjd5NWVuOWFOWEM0bXdNR3grRGll?=
 =?utf-8?B?ZXBnZFpxWWt5UW5hSkRSMGdLTk1JSVZsTVI3TkhGTlR4UnNQNVE0Qnc0VmNL?=
 =?utf-8?B?NmJPMXRJTTcydlVaczNnOHBJeVc5TTJNQVYwbjRsQXBlNGQ4TStKUnhwb0xp?=
 =?utf-8?B?MnhDSWpoM0IySGdHeEU2MXJWMEEvOG5TU2VXbUI3cHNSSXpaQlFoNjc4dE1u?=
 =?utf-8?B?ZXIvMzNPaXdpd1RPdTc0NGFMbk5KVXl4L0NSYzZYd0k3c3BZbWpxYWFRYWls?=
 =?utf-8?B?SVlvOUJIVis0dEx3ZjViUElNZVFta2FHSUVsN0JpMnY0S1g2UEdSQT09?=
X-OriginatorOrg: axentia.se
X-MS-Exchange-CrossTenant-Network-Message-Id: 413a35f5-cf44-4215-1a66-08da37fce38c
X-MS-Exchange-CrossTenant-AuthSource: AM0PR02MB4436.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2022 12:00:51.6648
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4ee68585-03e1-4785-942a-df9c1871a234
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: syrjmbSv4HdMPZJA9Ycn89ELHampF0uuGcnH5fxyTYbI2U5gR9yQtU6axoeXxjGv
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR02MB3078
X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


2022-05-17 at 13:53, Michael Walle wrote:
> Hi,
> 
>>> +struct mux_lan966x {
>>
>> Why is the file named lan966, but then everything inside lan966x?
> 
> So I was about to reply to the bindings but since that question
> came up here, too, I'll do it here.
> 
> IMHO the name "lan966" is super confusing and if I followed it
> correctly, it was just invented because the DT guys don't want to
> have a wildcard in the compatibles. But LAN966 isn't a real product,
> just LAN9662 and LAN9668 is.

No wonder I failed when I searched the web for "lan966"...

So, as you were told in the thread you point at below, you name
stuff after one of them (and not some random thing that doesn't
exist), but then handle both in the same file(s). Like you would
have if one was introduced first and the other came later.

Cheers,
Peter

> 
> I'd really prefer to have a consistent naming. I've said it once
> [1], having "lan966" (over lan966x) feels like cheating and is even
> worse, because everyone would assume there is a thing named LAN966.
> lan966x might lead the reader to think twice what the 'x' means.
> 
> So I'd prefer to have lan966x in the documentation and the drivers
> and just "microchip,lan9668" or "microchip,lan9662" in the
> compatibles.
> 
> -michael
> 
> [1] https://lore.kernel.org/linux-devicetree/d18291ff8d81f03a58900935d92115f2@walle.cc/