Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp4095990iob; Tue, 17 May 2022 13:58:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx5wy3q3YgFMq8/Ch47FvAWmnVY+5vOPJkpUHm9QIOTu8LKco2srV3l0H5OQMotXO/WM2vE X-Received: by 2002:a17:907:7b85:b0:6fd:d799:ef4e with SMTP id ne5-20020a1709077b8500b006fdd799ef4emr21496241ejc.319.1652821085473; Tue, 17 May 2022 13:58:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652821085; cv=none; d=google.com; s=arc-20160816; b=utJtLNypGjSIJ/RbeK1P40Jr/PEPHwu3oMePs+WaYuR6acKmqOANUmcpuHKiTeiNV6 LRFc/BOJgS5E7wFbwmTU/e8fOozriKVSA/1rkcp+t665qqYGtpP1YgG3vrMHYY5BJtv2 apX+lNOzxm0S3zQQlpjST3I8sz8G57YG/3t4cncAusv9+ORGq5GBtJG1J90lwiQJlDY+ mPa1zbZZHnmIH7DVLBkACbawLN3/hXbA60tU9xe44jw9oyi9bBu7UfvajtrPKmfyTAzu bGtlfj4sXORlYyThjgKZt9StOwRlNH4K9S4ZlkKG6pj5PBt7teJSeD5zJV+dgFH1azkO nPPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=HcRa6SDnOXbv+irXoqiVIuAY1pxJQnMP3O4Ji8hBDDE=; b=mV5XIJ3LyJKNmXynDWIVwBNUgdjiwTY6CJ5l426OlGF//VXwhUNpuj+26+x+Nhn05g aFNHt7QikG8lWyYUcdm4/rqR8W+CuozpzpBuahPRkc3mefi9zhPEw65dRJXVxffOcBLE 7OHDU4p3G7ced8h98SeLuxsGIiO7/zhxFvLehvITGW5T2xF0Z/qZVcTLODtW4wPVNMPh zx7go3EiO4hAWNW5WVMQ3oo3uEhvniSW94IeNVhhAnM6qSeO0naigoKX1PL+OLm+JIMr kZoFGXTGtAjzyK3xN0HR+T9ITdyGef8ucEOkJnGt3Lj7xX0LHeIz2Jm4y0JHeGpjit4H WpOw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nc24-20020a1709071c1800b006f38d674824si388089ejc.2.2022.05.17.13.57.39; Tue, 17 May 2022 13:58:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239696AbiEQTsD (ORCPT + 99 others); Tue, 17 May 2022 15:48:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49012 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233185AbiEQTsA (ORCPT ); Tue, 17 May 2022 15:48:00 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:12e:520::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5663137BDC; Tue, 17 May 2022 12:47:58 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1nr3Ad-0003Z8-52; Tue, 17 May 2022 21:47:51 +0200 Date: Tue, 17 May 2022 21:47:51 +0200 From: Florian Westphal To: syzbot Cc: ali.abdallah@suse.com, coreteam@netfilter.org, davem@davemloft.net, edumazet@google.com, fw@strlen.de, kadlec@netfilter.org, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, ozsh@nvidia.com, pabeni@redhat.com, pablo@netfilter.org, paulb@nvidia.com, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] KASAN: use-after-free Read in nf_confirm Message-ID: <20220517194751.GA4316@breakpoint.cc> References: <000000000000fb4af305df391431@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <000000000000fb4af305df391431@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SORTED_RECIPS,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit: d887ae3247e0 octeontx2-pf: Remove unnecessary synchronize_.. > git tree: net-next > console+strace: https://syzkaller.appspot.com/x/log.txt?x=17f2b659f00000 > kernel config: https://syzkaller.appspot.com/x/.config?x=b1aab282dc5dd920 > dashboard link: https://syzkaller.appspot.com/bug?extid=793a590957d9c1b96620 > compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=1313dce6f00000 > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=169eb59ef00000 > > The issue was bisected to: > > commit 1397af5bfd7d32b0cf2adb70a78c9a9e8f11d912 > Author: Florian Westphal > Date: Mon Apr 11 11:01:18 2022 +0000 > > netfilter: conntrack: remove the percpu dying list AFAICS this bug exists since Fixes: 71d8c47fc653 ("netfilter: conntrack: introduce clash resolution on insertion race") nf_confirm needs to re-fetch 'ct' from skb->_nfct. Will send a patch.