Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220513033450.7038-1-kflin@nuvoton.com> <20220513033450.7038-2-kflin@nuvoton.com>
 <5e1d0765-5428-b787-75ad-063a1fb051fc@molgen.mpg.de>
In-Reply-To: <5e1d0765-5428-b787-75ad-063a1fb051fc@molgen.mpg.de>
From:   Kun-Fa Lin <milkfafa@gmail.com>
Date:   Tue, 17 May 2022 09:55:52 +0800
Message-ID: <CADnNmFqFXxDv=+uEze2LjV2eMSVbMyCp=uiTnrm3Z7Hm6j8SHg@mail.gmail.com>
Subject: Re: [PATCH v2 1/5] arm: dts: Add node for NPCM Video Capture/Encode Engine
To:     Paul Menzel <pmenzel@molgen.mpg.de>
Cc:     mchehab@kernel.org, linux-media@vger.kernel.org,
        linux-kernel@vger.kernel.org, CS20 KWLiu <kwliu@nuvoton.com>,
        tmaimon77@gmail.com, avifishman70@gmail.com,
        openbmc@lists.ozlabs.org, tali.perry1@gmail.com,
        Marvin Lin <kflin@nuvoton.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Dear Paul,

Thanks for your review and comments.

> Could you please add the datasheet name and revision to the commit message?

It may not be appropriate since the datasheet is not public.

> What board did you test this on?

I tested on Nuvoton NPCM750 evaluation board.

>
> > Signed-off-by: Marvin Lin <kflin@nuvoton.com>
>
> As you sent this from your Google Mail account, that address is going to
> be used in the author field. Is your Nuvoton address configured for git?
>
>      git config user.email
>
> Then I would have thought, that that address is also in the files
> generated by `git format-patch`.

Thanks for the reminder. I'll change the address configuration.

Regards,
Marvin