Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "G, GurucharanX" <gurucharanx.g@intel.com>
To:     Bernard Zhao <zhaojunkui2008@126.com>,
        "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        "Jakub Kicinski" <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     "bernard@vivo.com" <bernard@vivo.com>
Subject: RE: [Intel-wired-lan] [PATCH] intel/i40e: delete if NULL check before
 dev_kfree_skb
Thread-Topic: [Intel-wired-lan] [PATCH] intel/i40e: delete if NULL check
 before dev_kfree_skb
Thread-Index: AQHYZTzOQMmO4kPqPEi5xAu279lZRq0irvZQ
Date:   Tue, 17 May 2022 07:07:30 +0000
Message-ID: <BYAPR11MB3367D27F04977C53C9744AC1FCCE9@BYAPR11MB3367.namprd11.prod.outlook.com>
References: <20220511065451.655335-1-zhaojunkui2008@126.com>
In-Reply-To: <20220511065451.655335-1-zhaojunkui2008@126.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?nRGmhE5umHrkGxvC2ViHkM44N5UHa3cxIhoUZuCXUUwDUUnUkgz/sYkLVcrt?=
 =?us-ascii?Q?sUvtCUuUFbTJHlSG8QMi0lxAGB7KWK6RCtb6CtpgVpTbMU8GG3V/3mpmThFy?=
 =?us-ascii?Q?ZE66aL78n0K3/0cPKQFXwX2sr1MovxLzTALq/VNuYpVeS9Y2FhozmtviaYHJ?=
 =?us-ascii?Q?ib6UKIFNpZZko7O+GNBVuUk+yZ1pSnWsqV9D3hF2XWfTx16BGd0Wmyh7i30p?=
 =?us-ascii?Q?LwoQxW5jcXHrgepOY2vKBylslYNx/RB2UK0U4Bn0Fh7hEhvIaLItOYlkNSGn?=
 =?us-ascii?Q?KWZMQfKnIEMoiFbKL7PiVK4aSe4GOzvwd1AF0nxFp8I0jYTtB3KtwG5qsfuf?=
 =?us-ascii?Q?BmUVadO5UxuSPuSP45e20/3thXNJRBCZiCf7PFCnbHJvWk1I/OVTJr2vMoLd?=
 =?us-ascii?Q?pE8YsYWJiyxbd9pBkuVta9Jpk9LU0WMhICddCLZqcreEGl2s3aT76ptLPcsc?=
 =?us-ascii?Q?seb8epjeE/ihxlwhlJZSDMiz72b8dSv0EyukFYi2sJAzRZv46OKWBctdmHU3?=
 =?us-ascii?Q?uNWdAwIlDMGT5o5RemJPDXBQiz4roOfuKc7SHQBmasDOeWtoygChA3wHtpTj?=
 =?us-ascii?Q?eXST6LiB52VYrfak9DrVddZLcWF31hRIOJ6tHM8hVKHMcsUyH+eQSqn4yjO3?=
 =?us-ascii?Q?slZ3r+QPKxPgsP0l2LaFad43OjduwXxjHGuUoKISuhD0/0V5FwgUlK7lRUsP?=
 =?us-ascii?Q?vO3VdyUYM3ucSXV8oNhNLPVvdibzyk3zS39GFkhlROnK6R/qcncGPuK/5goV?=
 =?us-ascii?Q?dEG7Glkzch7b2f1hjyKdfFBaBsd2nPhMTn/+rtEiDaDQMFeg8v1FvFCX3UAa?=
 =?us-ascii?Q?/TqXyZoBPZSfMzED4i5nI8pNZCWEcy8o3otp7YcPC7nSF9YX/Ne7jvkSxN2e?=
 =?us-ascii?Q?rik9sD79nNtVq650MSV4VBpnDzNDtSXfEuf1RZU9weVNC3Rh2j+h+MuGSTCX?=
 =?us-ascii?Q?uNiOurIB/Tt7C7c9FS92faIxOAwroAga86kJpWV44rlrxYfcFXxOJDcVK2pG?=
 =?us-ascii?Q?8/rU9iN+cAIlKbqv4OP+X2z+oZMZCUHdfeG9OvIRPMZylqLVoly5NNWtZeqP?=
 =?us-ascii?Q?8QZ85lnAq5PYvvRzXo7J6ri8zqk1UXvdmU4YFUCSWu5LCrTeUWGsV/ciBgBd?=
 =?us-ascii?Q?Z1J1B29xrORmPvGsHmAEBSJofQJuvi9PmOz0R/doVAIjGoSoWCl/j4sYRo62?=
 =?us-ascii?Q?zeS6VissYWIprjbudNU/aK+4CROwUP2OxGo15oAq1A4fNy3Ql1Nd2sr+ouEh?=
 =?us-ascii?Q?Jid0XEy3ll4XwQZMrTyM1hNQHVZ6qUeyzf0BDdlNDoXSGl/aC7bQ9ZcSGDy/?=
 =?us-ascii?Q?yuYJTinTth2XAqGIdveaQXG9+fwd1VbCBxG94VDyYBeMvlzsCuGCxKnFD+AC?=
 =?us-ascii?Q?jggEqiD347JmKdA9nIr9MGXKbvYa77w2PKmCraJK6qsTDh9Y9k/albjmnu4p?=
 =?us-ascii?Q?3XkYYNjUVFtSCi+VgTIiHm1bdX+ggKhNgzYLxatQlvi0Dh2IK5EZtGe/9SDJ?=
 =?us-ascii?Q?1Z+i8RsUiS+IJXWhPbpkOmD3t6R6Wl6i6OR4dpv32iQoSdOQ0MyFJTWGezuY?=
 =?us-ascii?Q?SgyjRKgE2tDtV2WK3R+o0y3CGF1LuhZQ/aeU2PGS6Hz+u8OVghWLsEfCZ89p?=
 =?us-ascii?Q?uL6h97sfrNgmsq8rohrJJ/LQo95zX14BOapmDuSvS+uAHoahzTLlH8fOq3h/?=
 =?us-ascii?Q?smOpe9DR8kA3smFdDV/A4ab+2+qDLFDoW/+oYFkQssFzi5slhB6PNZLiinc8?=
 =?us-ascii?Q?e+ulnmzV6Q=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3367.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1239056c-0d18-4d85-4e9f-08da37d3e858
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 May 2022 07:07:30.1606
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: jK9zMhVEi/3pGcDKLmgZWbhMYHB0Z2liXndLJCItl8izYEWGi518y0Q4FwssURAABCTFkiyexF5qaLv6lgNbyw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1904
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Bernard Zhao
> Sent: Wednesday, May 11, 2022 12:25 PM
> To: Brandeburg, Jesse <jesse.brandeburg@intel.com>; Nguyen, Anthony L
> <anthony.l.nguyen@intel.com>; David S. Miller <davem@davemloft.net>;
> Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>;
> intel-wired-lan@lists.osuosl.org; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Cc: bernard@vivo.com; Bernard Zhao <zhaojunkui2008@126.com>
> Subject: [Intel-wired-lan] [PATCH] intel/i40e: delete if NULL check befor=
e
> dev_kfree_skb
>=20
> dev_kfree_skb check if the input parameter NULL and do the right
> thing, there is no need to check again.
> This change is to cleanup the code a bit.
>=20
> Signed-off-by: Bernard Zhao <zhaojunkui2008@126.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_txrx.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>=20

Tested-by: Gurucharan <gurucharanx.g@intel.com> (A Contingent worker at Int=
el)