Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp4150823iob; Tue, 17 May 2022 15:24:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwTYGUPwa4rJEO8/t0dgbOwKsAI2s4UlGGDY7Z4Bjuy1vr0TOeenjo23tRoRsdYl1RcQcYH X-Received: by 2002:a05:6402:2808:b0:427:c823:8152 with SMTP id h8-20020a056402280800b00427c8238152mr21658439ede.84.1652826263249; Tue, 17 May 2022 15:24:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652826263; cv=none; d=google.com; s=arc-20160816; b=jtl/BfFSlPTXJNT1KsGpTmg1OkvtLQnErVVW6CP3KMXTLo4pZTmQfbkemibbzX8f5O LXBmyzgvaEVNBvC++52fzk1+SYS3uNOUN6/ISd9RGEpq9uYGqMfqzBd177AiAdZE7sW2 RH3iXd+laxCyjeBcSfVvYP0aJ9kTB1Wk4kE9BIkVFhzqo2SmBvpJiZm8SI6K981DB0tS uUxKVSkWwGrdEcnNC/BDDlazzunv84G+67MTOG/pijHvT7QoOK89auO//7mNmuYEbiAo 9JvgEavrSnJGtI1+W18QREsjZOtjamgryvcQq9RXUZCe98rppIqFtIjWJzBQPVAhZ1v1 XPsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version; bh=4FNoWTSP55ndOPeC+jkUPZPRKqM/W1oOHqIRSNLtrZE=; b=hc/l8AbkDMYXWi2ril7vv55i0Ouey846jpOKafYWWuxRTEYp4D0MGD9KXcL/lg9GWT nQ6mJtByYJ6JSrKZA+IZm3PmFoU/aygXlmMKcDzvba26RiKnaM7GCHGVJBq4PCND/UP1 ydyIP4CI8rpRi8TxNoYuBsh/xzjXHA95k5cOUa4rb88gtORAl/Hd5txrzUIo9GBtSw5D u5t/X72KxLMfmdaHuaUp8OQ5SL/VnyAgO0uhyARI1eJWzrQAlCvylPcruWF5KwBUXyY8 /t2Ey0MRqiYLjj7xtMfnROcq2TLzgN8diY1cuABfTpo148Gzic/uQlxsJSmXN0jGoaw+ N6ew== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dp17-20020a170906c15100b006e7f21f913dsi544275ejc.233.2022.05.17.15.23.57; Tue, 17 May 2022 15:24:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236691AbiEQHG3 (ORCPT + 99 others); Tue, 17 May 2022 03:06:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235983AbiEQHGT (ORCPT ); Tue, 17 May 2022 03:06:19 -0400 Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD65546B37; Tue, 17 May 2022 00:06:18 -0700 (PDT) Received: by mail-qk1-f172.google.com with SMTP id j6so13937535qkp.9; Tue, 17 May 2022 00:06:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4FNoWTSP55ndOPeC+jkUPZPRKqM/W1oOHqIRSNLtrZE=; b=OBx16Kqb7r/+WLcnb5FTGr2Kr9wGIVdq5Jdby5mqBuZLdpVHcHK3E1WQF78mNvBBeh XJDuNNkbP+cUaa3VCXcy6yju/xlqzLEZ4ocvbhDJ7xqUnBL/8lH1aoHAlhp6QPIdlKO3 XPJuMEq+d/3uCgAsJlskKVeBlvqFj2ssSuxFKY+/TU/NX+w/3gWu7N8D5C4xzANoZm5J g8fZ5uCzYvEppngqlHoOtvuqeYwMvNvV/Tsy79ZeTFBGNr7ZIC78/0sYJJU0Ac5sG9lc j9oAyiOEkOY1PFRt93WBfXgVMBV7HdsQzomoxxZB+TRErkdWHf6FSx0pS3Q9W1Wn9QCv Q28g== X-Gm-Message-State: AOAM53303j8WQceCZHMUttYYLwqLBqrQuEmXDkAjEy94U+IuVG1ZCB93 n2hPm80moYX7m4Y/6+GQmw7fhDXxs1ZQFg== X-Received: by 2002:a05:620a:859:b0:6a0:15d6:60ca with SMTP id u25-20020a05620a085900b006a015d660camr15091013qku.350.1652771177812; Tue, 17 May 2022 00:06:17 -0700 (PDT) Received: from mail-yb1-f170.google.com (mail-yb1-f170.google.com. [209.85.219.170]) by smtp.gmail.com with ESMTPSA id c4-20020ac81104000000b002f3b82571b1sm7326984qtj.1.2022.05.17.00.06.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 May 2022 00:06:17 -0700 (PDT) Received: by mail-yb1-f170.google.com with SMTP id o80so11135242ybg.1; Tue, 17 May 2022 00:06:17 -0700 (PDT) X-Received: by 2002:a25:e04d:0:b0:64d:6f23:b906 with SMTP id x74-20020a25e04d000000b0064d6f23b906mr13099556ybg.380.1652771177087; Tue, 17 May 2022 00:06:17 -0700 (PDT) MIME-Version: 1.0 References: <20220517033526.2035735-1-zhangjialin11@huawei.com> In-Reply-To: <20220517033526.2035735-1-zhangjialin11@huawei.com> From: Geert Uytterhoeven Date: Tue, 17 May 2022 09:06:05 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] iio: adc: rzg2l_adc: add missing fwnode_handle_put() in rzg2l_adc_parse_properties() To: Jialin Zhang Cc: "Lad, Prabhakar" , Jonathan Cameron , Lars-Peter Clausen , Biju Das , linux-iio@vger.kernel.org, Linux-Renesas , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 17, 2022 at 6:44 AM Jialin Zhang wrote: > fwnode_handle_put() should be used when terminating > device_for_each_child_node() iteration with break or > return to prevent stale device node references from > being left behind. > > Fixes: d484c21bacfa ("iio: adc: Add driver for Renesas RZ/G2L A/D converter") > Reported-by: Hulk Robot > Signed-off-by: Jialin Zhang Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds