Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp4152636iob; Tue, 17 May 2022 15:26:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzgJZnTskTD2T4V7DJ7q6o1QHRkeFt7J70s36m/uXnp4OKnbnW5SpRWi8j0JpsYRE1iRIvL X-Received: by 2002:a17:907:a0c8:b0:6f7:492e:e74c with SMTP id hw8-20020a170907a0c800b006f7492ee74cmr21367582ejc.670.1652826419268; Tue, 17 May 2022 15:26:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652826419; cv=none; d=google.com; s=arc-20160816; b=gIH4j75FkQPXNlmSa8dpasMBsbsmV44rpo0Iha5i0XRz24UJ9fzVH70nSwCFww1mYc Q+6M/OP1ZUUvKxQ2qfujmDH3ksmE5k4YMkLfBfShis70Aasyfri8EPvpEkQx3BmfPpmR Hmdr+jhcyRhe3eE0gHIQROIj33ieHUPXE1Fp1Zzp9S4typpxsLVUiVGrUe2DEKHlzUrh hBOALdy3slUysNOGRpHDkdy59bcwPIFgW6+ISogGn3dMW5/EA+P/UJp1+d6ygxcbbB+h Daq7YQlBv0va0Zp3SsVdRuAjR/8vSfW59odKbeU18gGoHet3op5lkviBk2aBqDYToVcA Iumw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:user-agent:date:to:cc:from:subject :references:in-reply-to:content-transfer-encoding:mime-version :dkim-signature; bh=kk3k6llzVPvOiyVwtI1w8V49kIHd781E2pe6yqRZhys=; b=HvriZ6KutXnLq6pgjzX2d1UBRchbP3fGPl+CZLiaDxMrnOWUfoaqfv73KblvReke9A e7bIyftluHmQfAabIXuXEkEjSh+PHybSxAZETkJuSTzlFb0FYg/GJgbGRDGcb9NSjiDH 9OrStzl2um3njBjHKw4hUxhonV+IHmd5EYr/YU0PrNoSK+UM3uWfM0hkevYKDqhtFLjY hx1EWx5/HcIKGoEUqzkUMKo4LmaVM2bTTsxAy10Vv2PTydZkAWmqm5X3vs8J/H7F6wkg 5ErKKZXX+3qeo3ldNdpCk5Mskh87qmwpUiVZ+sDzvBlM3/Nxe2Pty33t0YFXHsN3nwk0 KdEQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=T3ArEvcA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hr13-20020a1709073f8d00b006e8bada2835si440229ejc.992.2022.05.17.15.26.32; Tue, 17 May 2022 15:26:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=T3ArEvcA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240307AbiEQHCG (ORCPT + 99 others); Tue, 17 May 2022 03:02:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34090 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240627AbiEQHB3 (ORCPT ); Tue, 17 May 2022 03:01:29 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4AC5545074; Tue, 17 May 2022 00:01:28 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9B764615B6; Tue, 17 May 2022 07:01:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ED728C34119; Tue, 17 May 2022 07:01:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652770887; bh=kk3k6llzVPvOiyVwtI1w8V49kIHd781E2pe6yqRZhys=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=T3ArEvcAh5VKL8yv++QVhPTIi02OIM8W37fO+3AxNgX+3Sgoo0QkEHPEKhcNspyCk wjwR4ETj3RcNDvQsDhaL7UT0dbYNrpkMDPV6EofNA12peCuGfxm4+4GzfYLrpbXu8m JkgUXzz/6J4dgBs7JBWIjrJXitpStCDTFMZseR29pdCpEghhawxh2skPj+aMx9qs9I 6oMGw7T7g8F/5owGtZVEQB0hllScacbe1eFPxvBtip3xvcmipFYWqs38RQxzT9kgp+ XxcTWoFO/Wl1uArNOrSTK7Ygeu9LFHjdNvIk3t4vxe2TKfIZRRaLyKuEjEHVDKUIv1 5rHn2D+LeyAig== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20220428183010.1635248-1-stefan.wahren@i2se.com> References: <20220428183010.1635248-1-stefan.wahren@i2se.com> Subject: Re: [PATCH] clk: bcm2835: fix bcm2835_clock_choose_div From: Stephen Boyd Cc: bcm-kernel-feedback-list@broadcom.com, Maxime Ripard , linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Stefan Wahren To: Florian Fainelli , Michael Turquette , Ray Jui , Scott Branden , Stefan Wahren Date: Tue, 17 May 2022 00:01:25 -0700 User-Agent: alot/0.10 Message-Id: <20220517070126.ED728C34119@smtp.kernel.org> X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Stefan Wahren (2022-04-28 11:30:10) > The commit 09e3b18ca5de ("clk: bcm2835: Remove unused variable") > accidentially breaks the behavior of bcm2835_clock_choose_div() and > booting of Raspberry Pi. The removed do_div macro call had side effects, > so we need to restore it. >=20 > Fixes: 09e3b18ca5de ("clk: bcm2835: Remove unused variable") > Signed-off-by: Stefan Wahren > --- Applied to clk-fixes