Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Tue, 17 May 2022 16:58:54 -0700
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Minchan Kim <minchan@kernel.org>
Cc:     Matthew Wilcox <willy@infradead.org>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-mm <linux-mm@kvack.org>,
        Suren Baghdasaryan <surenb@google.com>,
        Michal Hocko <mhocko@suse.com>,
        John Dias <joaodias@google.com>,
        Tim Murray <timmurray@google.com>,
        Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [PATCH] mm: don't be stuck to rmap lock on reclaim path
Message-Id: <20220517165854.fa6810576db304428b275385@linux-foundation.org>
In-Reply-To: <YnNqeB5tUf6LZ57b@google.com>
References: <20220503170341.1413961-1-minchan@kernel.org>
        <YnHzvV2Uz2ynENnG@casper.infradead.org>
        <YnIBbjRYACzvuZpp@google.com>
        <YnIYofrw/GGEvc0U@casper.infradead.org>
        <YnKhLX+jzJc+2KwB@google.com>
        <YnKwBeRAWwIlEVqy@casper.infradead.org>
        <YnMQp/zJVHu9Qq/S@google.com>
        <YnMdaW67GEDF0Ynr@casper.infradead.org>
        <YnNqeB5tUf6LZ57b@google.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 4 May 2022 23:11:04 -0700 Minchan Kim <minchan@kernel.org> wrote:

> > > +
> > > +	static struct rmap_walk_control rwc = {
> > >  		.rmap_one = page_idle_clear_pte_refs_one,
> > >  		.anon_lock = folio_lock_anon_vma_read,
> > >  	};
> 
> So, delta is

--- a/mm/page_idle.c~mm-dont-be-stuck-to-rmap-lock-on-reclaim-path-fix
+++ a/mm/page_idle.c
@@ -87,6 +87,10 @@ static void page_idle_clear_pte_refs(str
 {
 	struct folio *folio = page_folio(page);
 
+	/*
+	 * Since rwc.try_lock is unused, rwc is effectively immutable, so we
+	 * can make it static to save some cycles and stack.
+	 */
 	static struct rmap_walk_control rwc = {
 		.rmap_one = page_idle_clear_pte_refs_one,
 		.anon_lock = folio_lock_anon_vma_read,
_

and with that, I believe this change is good to be imported into mm-stable
later this week.