Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <145b19b7-00e1-3542-a99d-866539081add@linux.intel.com>
Date:   Tue, 17 May 2022 13:08:26 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.8.1
Subject: Re: [PATCH v6 5/5] x86/tdx: Add Quote generation support
Content-Language: en-US
To:     Kai Huang <kai.huang@intel.com>,
        Isaku Yamahata <isaku.yamahata@gmail.com>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
        "H . Peter Anvin" <hpa@zytor.com>,
        "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
        Tony Luck <tony.luck@intel.com>,
        Andi Kleen <ak@linux.intel.com>,
        Wander Lairson Costa <wander@redhat.com>,
        marcelo.cerri@canonical.com, tim.gardner@canonical.com,
        khalid.elmously@canonical.com, philip.cox@canonical.com,
        linux-kernel@vger.kernel.org
References: <20220512221952.3647598-1-sathyanarayanan.kuppuswamy@linux.intel.com>
 <20220512221952.3647598-6-sathyanarayanan.kuppuswamy@linux.intel.com>
 <20220513185824.GB2913259@ls.amr.corp.intel.com>
 <c07c9fa1-ff6a-df8a-6050-60ade29367f3@linux.intel.com>
 <38a7c7406f0b0c65e68679fb8399ffe3fae05cb2.camel@intel.com>
From:   Sathyanarayanan Kuppuswamy 
        <sathyanarayanan.kuppuswamy@linux.intel.com>
In-Reply-To: <38a7c7406f0b0c65e68679fb8399ffe3fae05cb2.camel@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 5/16/22 7:58 PM, Kai Huang wrote:
> On Fri, 2022-05-13 at 12:29 -0700, Sathyanarayanan Kuppuswamy wrote:
>>>
>>>
>>>> +
>>>> +	/* Wait for attestation completion */
>>>> +	ret = wait_for_completion_interruptible(&entry->compl);
>>>> +	if (ret < 0) {
>>>> +		/*
>>>> +		 * For premature termination, since VMM still owns the
>>>> +		 * shared buffer, mark the request invalid to let
>>>> +		 * quote_callback_handler() handle the memory cleanup
>>>> +		 * function.
>>>> +		 */
>>>> +		invalidate_quote_request(entry);
>>>
>>> Interrupt can arrive after signal interrupt.  So invalidate_quote_request()
>>> should check if the request is already processed, and return 0 or -EINTR.
>>> Probably check the state always and del_list under single lock/unlock pair.
>>
>> Agree. But I think we should return -EINTR for the interrupted case
>> irrespective of the processed status (so no return 0).
>>
>> I will hold the lock and handle the cleanup for the processed
>> status.
> 
> Even if we check the buffer status in invalidate_quote_request(), there's no
> guarantee the VMM won't change the buffer status _after_ we do the check, so
> looks such check isn't necessary.
> 

Consider the case where we get a callback interrupt, and before we
complete the processing for it, user terminates the request. In this
scenario,  quote_callback_handler() will consider the request is
still valid and no do the memory cleanup. To handle this case,
we need to check the status in invalidate_quote_request() and do
the cleanup if required.

/* Handles early termination of GetQuote requests */
void invalidate_quote_request(struct quote_entry *entry)
{
         struct tdx_quote_hdr *quote_hdr;

         /*
          * For early termination, if the request is not yet
          * processed by VMM (GET_QUOTE_IN_FLIGHT), the VMM
          * still owns the shared buffer, so mark the request
          * invalid to let quote_callback_handler() handle the
          * memory cleanup function. If the request is already
          * processed, then do the cleanup and return.
          */

         mutex_lock(&quote_lock);
         quote_hdr = (struct tdx_quote_hdr *)entry->buf->vmaddr;
         if (quote_hdr->status == GET_QUOTE_IN_FLIGHT) {
                 entry->valid = false;
                 mutex_unlock(&quote_lock);
                 return;
         }
         _del_quote_entry(entry);
         mutex_unlock(&quote_lock);
}


-- 
Sathyanarayanan Kuppuswamy
Linux Kernel Developer