Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp105413iob; Tue, 17 May 2022 20:20:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxBfVIFtpQbm2skmqGQbgG4d2QNzHtqE+OzsY8+MzMgRFK6lI4P6OvbmH41e7o96L+G5yxJ X-Received: by 2002:a62:7b87:0:b0:518:1665:ef15 with SMTP id w129-20020a627b87000000b005181665ef15mr2416171pfc.84.1652844028353; Tue, 17 May 2022 20:20:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652844028; cv=none; d=google.com; s=arc-20160816; b=tu5+VTTQNeu5FQoB876f6XtyEqBPASaj6WHg1XBeOd8WWjfh5lp1TlGdlFdusOk9gz KEjjfAjYHIQOWE8B8RatnlOPXtq0Hz2qGV01y3jH+/HJiPuV44CdCeERxKU63utxBmKb KY32vl0VxzGHZf24UCaq7AIq45BaQgPPXT9auHfd+BdQ2JZQlex6H3iTu0n0z8edxm+W Ao1w4xliAlb2WRo7Sqb9YOpZ8EfcUMU8WKgl5RR9OWFXsahyNdd1pEYuG8J8k7fvDTVS sj//Yi3uj4cuWhrto+bX7hMjGLvPhJSVGlblPmgwv5vow14zEcxkOVL2mWuC83XPH1eP 5NkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=UazRNADyyJz2HI+RS6R0a4/dm7+XkEeyBn9yGoLISk0=; b=XHN/AHFaEdNiGI9QT+u0qgEXAIT8vshOwnEWFeevblZgfoWz2lXHh/GQ299IoKLin9 vUu515FpIANPJy6NqHBWKXtSPExzAugl/UdPKTirr/vSREWwhS25r/AF1jkR3Xa7vir0 APtgTuMXGA1KHGlur+MzjMitjofM1GALg6liHBiaflcw2gyqPjo9SMI8DDeJV5vDKPR1 eV2ZwNAldLHn0dTJNi4jrF0aTmVAQreF28+9usvIDt1L+wTt/bmQxy5xOeVd2xhSBwA7 AJ8NG4k70CB3IG0/UIfCggoOi+0DHS5ZsvhqFLgDCu96idvdjbTbzrXSTtK8xetS0aeK HPqA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=BKp7+FEV; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id c20-20020a170902c1d400b0015d078de5b9si1211318plc.30.2022.05.17.20.20.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 May 2022 20:20:28 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=BKp7+FEV; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E78B261611; Tue, 17 May 2022 20:18:10 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348547AbiEQOMB (ORCPT + 99 others); Tue, 17 May 2022 10:12:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348525AbiEQOLI (ORCPT ); Tue, 17 May 2022 10:11:08 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1FB9EAE; Tue, 17 May 2022 07:11:06 -0700 (PDT) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 67D211F8CA; Tue, 17 May 2022 14:11:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1652796665; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UazRNADyyJz2HI+RS6R0a4/dm7+XkEeyBn9yGoLISk0=; b=BKp7+FEVfq6NcVwdI04E/j1IXhL8fav2W9wQb6/2V+MLS4zVCpGBL04+5kiZPUHpPEWWSJ UCuw6cy5UFA5oDKAHRw0jxrGspZnMX7jbttS2tX8QWMEWQryA8mHzjbrpe5MfzzbeKkAE+ HL6pRS/de3kEkB9TyLHSW9ZDBKYUAwA= Received: from suse.cz (unknown [10.100.201.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 10D772C141; Tue, 17 May 2022 14:11:04 +0000 (UTC) Date: Tue, 17 May 2022 16:11:00 +0200 From: Petr Mladek To: "Guilherme G. Piccoli" Cc: "Luck, Tony" , Dinh Nguyen , "akpm@linux-foundation.org" , "bhe@redhat.com" , "kexec@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "bcm-kernel-feedback-list@broadcom.com" , "linuxppc-dev@lists.ozlabs.org" , "linux-alpha@vger.kernel.org" , "linux-edac@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "linux-leds@vger.kernel.org" , "linux-mips@vger.kernel.org" , "linux-parisc@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-remoteproc@vger.kernel.org" , "linux-s390@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "linux-um@lists.infradead.org" , "linux-xtensa@linux-xtensa.org" , "netdev@vger.kernel.org" , "openipmi-developer@lists.sourceforge.net" , "rcu@vger.kernel.org" , "sparclinux@vger.kernel.org" , "xen-devel@lists.xenproject.org" , "x86@kernel.org" , "kernel-dev@igalia.com" , "kernel@gpiccoli.net" , "halves@canonical.com" , "fabiomirmar@gmail.com" , "alejandro.j.jimenez@oracle.com" , "andriy.shevchenko@linux.intel.com" , "arnd@arndb.de" , "bp@alien8.de" , "corbet@lwn.net" , "d.hatayama@jp.fujitsu.com" , "dave.hansen@linux.intel.com" , "dyoung@redhat.com" , "Tang, Feng" , "gregkh@linuxfoundation.org" , "mikelley@microsoft.com" , "hidehiro.kawai.ez@hitachi.com" , "jgross@suse.com" , "john.ogness@linutronix.de" , "keescook@chromium.org" , "luto@kernel.org" , "mhiramat@kernel.org" , "mingo@redhat.com" , "paulmck@kernel.org" , "peterz@infradead.org" , "rostedt@goodmis.org" , "senozhatsky@chromium.org" , "stern@rowland.harvard.edu" , "tglx@linutronix.de" , "vgoyal@redhat.com" , "vkuznets@redhat.com" , "will@kernel.org" , Alex Elder , Alexander Gordeev , Anton Ivanov , Benjamin Herrenschmidt , Bjorn Andersson , Boris Ostrovsky , Chris Zankel , Christian Borntraeger , Corey Minyard , Dexuan Cui , "H. Peter Anvin" , Haiyang Zhang , Heiko Carstens , Helge Deller , Ivan Kokshaysky , "James E.J. Bottomley" , James Morse , Johannes Berg , "K. Y. Srinivasan" , Mathieu Poirier , Matt Turner , Mauro Carvalho Chehab , Max Filippov , Michael Ellerman , Paul Mackerras , Pavel Machek , Richard Weinberger , Robert Richter , Stefano Stabellini , Stephen Hemminger , Sven Schnelle , Vasily Gorbik , Wei Liu Subject: Re: [PATCH 21/30] panic: Introduce the panic pre-reboot notifier list Message-ID: References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-22-gpiccoli@igalia.com> <63a74b56-89ef-8d1f-d487-cdb986aab798@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 2022-05-16 13:33:51, Guilherme G. Piccoli wrote: > On 16/05/2022 13:18, Luck, Tony wrote: > >> [...] > > Would it be possible to have some global "kdump is configured + enabled" flag? > > > > Then notifiers could make an informed choice on whether to deep dive to > > get all the possible details (when there is no kdump) or just skim the high > > level stuff (to maximize chance of getting a successful kdump). > > > > -Tony > > Good idea Tony! What if I wire a kexec_crash_loaded() in the notifier? I like this idea. One small problem is that kexec_crash_loaded() has valid result only under kexec_mutex. On the other hand, it should stay true once loaded so that the small race window should be innocent. > With that, are you/Petr/Dinh OK in moving it for the info list? Sounds good to me. Best Regards, Petr