Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
MIME-Version: 1.0
References: <20220517101410.3493781-1-andre.przywara@arm.com>
 <20220517153444.GA1057027-robh@kernel.org> <CAFEAcA8sE8Rj0GmF71ox4BdDr0UcaS4QwiLUVUUFH5oj+hDhfA@mail.gmail.com>
In-Reply-To: <CAFEAcA8sE8Rj0GmF71ox4BdDr0UcaS4QwiLUVUUFH5oj+hDhfA@mail.gmail.com>
From:   Rob Herring <robh@kernel.org>
Date:   Tue, 17 May 2022 12:47:56 -0500
Message-ID: <CAL_JsqLRvEn2E7cpTzQJRCJ=aeLjUtKhDimWat=nPtm3QP+cfA@mail.gmail.com>
Subject: Re: [PATCH] of/fdt: Ignore disabled memory nodes
To:     Peter Maydell <peter.maydell@linaro.org>
Cc:     Andre Przywara <andre.przywara@arm.com>,
        Frank Rowand <frowand.list@gmail.com>,
        devicetree@vger.kernel.org,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Ross Burton <ross.burton@arm.com>,
        Ard Biesheuvel <ardb@kernel.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>,
        Russell King <linux@armlinux.org.uk>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, May 17, 2022 at 11:54 AM Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Tue, 17 May 2022 at 16:34, Rob Herring <robh@kernel.org> wrote:
> >
> > On Tue, May 17, 2022 at 11:14:10AM +0100, Andre Przywara wrote:
> > > When we boot a machine using a devicetree, the generic DT code goes
> > > through all nodes with a 'device_type = "memory"' property, and collects
> > > all memory banks mentioned there. However it does not check for the
> > > status property, so any nodes which are explicitly "disabled" will still
> > > be added as a memblock.
> > > This ends up badly for QEMU, when booting with secure firmware on
> > > arm/arm64 machines, because QEMU adds a node describing secure-only
> > > memory:
> > > ===================
> > >       secram@e000000 {
> >
> > BTW, 'memory' is the correct node name.
>
> We already have a 'memory' node, which is for the NS
> memory. This one's for the secure-only RAM block,
> which is why I gave it a name that hopefully helps in
> spotting that when a human is reading the DT.

You can do: secram: memory@e000000 {

Where 'secram' is only a source level label until overlays come into
the picture.

> I'm not really sure to what extent node names in device trees are
> "this is just an identifying textual label" and to what extent
> they are "this is really ABI and you need to follow the standard",
> though -- nothing in practice seems to care what they are,
> suggesting the "textual label" theory, but some bits of tooling
> complain if you do things like forget the address value or use the
> same address for two different nodes, suggesting the "really ABI"
> theory.

Node names are supposed to follow the class of device and there's a
list of established names in the spec.

Sometimes it's ABI and sometimes not. Much of it is just good hygiene.
memory nodes are also special because 'device_type' is used to
identify them, but device_type is generally deprecated for FDT as its
meaning in OpenFirmware doesn't apply (it defines what callable
methods exist). We could use the nodename (without unit address)
instead, but that would fail in some cases as other names have been
used.

Rob