Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Tue, 17 May 2022 15:19:00 +0100
From:   "Russell King (Oracle)" <linux@armlinux.org.uk>
To:     Chen Zhongjin <chenzhongjin@huawei.com>
Cc:     alexander.sverdlin@nokia.com, ardb@kernel.org,
        linus.walleij@linaro.org, nico@fluxnic.net,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] ARM: module: Add all unwind tables when load module
Message-ID: <YoOu1Ng53Tv/ec0d@shell.armlinux.org.uk>
References: <20220401131534.241205-1-chenzhongjin@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220401131534.241205-1-chenzhongjin@huawei.com>
Sender: Russell King (Oracle) <linux@armlinux.org.uk>
Precedence: bulk

Hi,

On Fri, Apr 01, 2022 at 09:15:34PM +0800, Chen Zhongjin wrote:
>  struct mod_arch_specific {
>  #ifdef CONFIG_ARM_UNWIND
> -	struct unwind_table *unwind[ARM_SEC_MAX];
> +	struct unwind_table unwind_list;

Why is this not a:

	struct list_head unwind_list;

because, from what I can tell, the _only_ member that is used in this
struct unwind_table is the "mod_list" member - so everything else is
entirely unused and redundant.

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!