Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp111557iob; Tue, 17 May 2022 20:35:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzmfeO5uUNwf4ctyiniriw8J6n80CyU5yzfz14oLVEIK4dz51H4YnL3Qk12CoMXHBtcxsdW X-Received: by 2002:a17:90b:17c4:b0:1df:a60b:1e28 with SMTP id me4-20020a17090b17c400b001dfa60b1e28mr3140830pjb.31.1652844918861; Tue, 17 May 2022 20:35:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652844918; cv=none; d=google.com; s=arc-20160816; b=o18BSvER65fcw2A4a46PfH7N5YiQsvSnPsi4Ygorl28bUmqrIyG8YPtl9cbHZGy70Y llfxT5/hJjA8kW/MLIdwU5V/WoF+cyxYguU5BQA3zEdU3Drld4jtOt7hu/Ip+5b8UqeC 08dGnOhxdokLqugAhJtd5tOCoJQKbI/8Fvb/+C+QDT1scoy0VNlt87TWBBSkfOUh2nKb bTxZvEXjMNB00rDC+DPqI+a+ALrc1HpytMjFvOkfNVg1TYs5GKRLgvt3beC99zpYTIlE F9dfnGhDw57Ez3B3kfCKDEde5/X+/wVW+TPKB0eisPXrQWsNfehRLKGuyKa/HZbezzZN Jy8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=ghYuHv8+UTuGk31lMOMuZ6uf4+lo6cXGHTsGrQVdN88=; b=lcfeLXv98cQuvb3cX4po1R0kVh1cQ9Yncy1EK3HxgwXjb926Igfn+i74XnBfQ/fQbv wfl2NGECGyEmnRK2yIEp65d2XiCDkX7SEXwvh6j8VgmVe1H5yeWYIgSbcUN/bHzzSgs/ 4+FnJDCfejfEHrDn7wIKZyH7S3lz76iCWiDlFkSToO/D3Z0MoG+zKJbIy0wOSD+TlaSv h+Vr9/sVomImA8NIzm5TJuKcB2Zh4mSUkAv0BHeuXfJRipFEL4FtNodH/coy40McqvNy JCV5uJ4rqxHk6ChrWeFniuWg6uje7Orn4YiWGM/vhwSCIswrlV0pnQQN3VcbqfdoEkAI ZzZQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TGVIx8po; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id n11-20020a635c4b000000b003d56e21a7cfsi1153807pgm.60.2022.05.17.20.35.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 May 2022 20:35:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TGVIx8po; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id CBC4470938; Tue, 17 May 2022 20:25:56 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232866AbiERBuk (ORCPT + 99 others); Tue, 17 May 2022 21:50:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38084 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229861AbiERBuj (ORCPT ); Tue, 17 May 2022 21:50:39 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6CE5B546B9; Tue, 17 May 2022 18:50:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BB40C615D2; Wed, 18 May 2022 01:50:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DA8C5C385B8; Wed, 18 May 2022 01:50:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652838637; bh=Wz2LeatRysIIJI6We7LTZk35ChDhAzJXX04vN/qest4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=TGVIx8poRzlJHVepsNHLU+LI7vdlE3uI/EGCQGs68AHNEPcHNiyIRi9xqvOUgxDSh 8YtnnmFYNiAAI+fsQvdph9190vDmT7ckoZMekUIrkysJj8nAFvYfuko9WkqjUrNLax UGZ82PgXyr+AZ+n6vzerg9OQ3swAIOrf2O2YmkeMEgFC8lmI3q1z2kbTDfsGwdVE9Z bgkv4d/4b0Bb5FsH5StZnYKHVmagO7ewylboCCuxWqqJhewHuYFOemXCthEEkW3We4 pzoC9dkAWv57MUsrHY1xwB/bpnjDfCGLzWAtTrNKBx1Oi1Ml21qzhgE9c+PmZP7cbo xrzN003HEz9+A== Date: Tue, 17 May 2022 18:50:35 -0700 From: Jakub Kicinski To: Martin =?UTF-8?B?TGnFoWth?= Cc: netdev@vger.kernel.org, lkml , davem@davemloft.net, edumazet@google.com, pabeni@redhat.com Subject: Re: [PATCH] gcc: fix -Warray-compare Message-ID: <20220517185035.4ee3dd8e@kernel.org> In-Reply-To: <21708ede-f378-d20e-0b1d-410e946fcca5@suse.cz> References: <21708ede-f378-d20e-0b1d-410e946fcca5@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 17 May 2022 16:19:16 +0200 Martin Li=C5=A1ka wrote: > Subject: [PATCH] gcc: fix -Warray-compare The subject should be more like eth: sun: cassini: remove dead code >=20 > Fixes the following GCC warning: >=20 > drivers/net/ethernet/sun/cassini.c:1316:29: error: comparison between two= arrays [-Werror=3Darray-compare] > drivers/net/ethernet/sun/cassini.c:3783:34: error: comparison between two= arrays [-Werror=3Darray-compare] Because AFAICT this comparison will always be true: #define CAS_HP_ALT_FIRMWARE cas_prog_null Hopefully DaveM will correct if I'm getting this wrong :)