Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <e18eb810-e437-6a19-26ec-1f0daedaaf5f@microchip.com>
References: <20220413071318.244912-1-codrin.ciubotariu@microchip.com> <20220422011216.A4A23C385A5@smtp.kernel.org> <e18eb810-e437-6a19-26ec-1f0daedaaf5f@microchip.com>
Subject: Re: [PATCH] clk: at91: generated: consider range when calculating best rate
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     mturquette@baylibre.com, Nicolas.Ferre@microchip.com,
        alexandre.belloni@bootlin.com, Claudiu.Beznea@microchip.com
To:     Codrin.Ciubotariu@microchip.com,
        linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date:   Tue, 17 May 2022 00:14:38 -0700
User-Agent: alot/0.10
Message-Id: <20220517071440.DAC76C385B8@smtp.kernel.org>
Precedence: bulk

Quoting Codrin.Ciubotariu@microchip.com (2022-04-26 00:24:15)
> On 22.04.2022 04:12, Stephen Boyd wrote:
> > Quoting Codrin Ciubotariu (2022-04-13 00:13:18)
> >> clk_generated_best_diff() helps in finding the parent and the divisor =
to
> >> compute a rate closest to the required one. However, it doesn't take i=
nto
> >> account the request's range for the new rate. Make sure the new rate
> >> is within the required range.
> >>
> >> Fixes: 8a8f4bf0c480 ("clk: at91: clk-generated: create function to fin=
d best_diff")
> >> Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
> >> ---
> >=20
> > Is this fixing anything real or it's just a thing that you noticed and
> > sent a patch to fix?
>=20
> It fixes the clk_set_min/max_rate() calls to a generated clock. Do you=20
> want me to add this fact in the commit description?
>=20

I wanted to know if there are clk_set_min/max_rate() calls on this clk.
Are there?