Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <142a9c03-574f-adcf-bc4d-bb2a25c01e88@wanadoo.fr>
Date:   Tue, 17 May 2022 19:54:38 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH] RDMA: remove null check after call container_of()
Content-Language: en-US
To:     Jason Gunthorpe <jgg@ziepe.ca>, Haowen Bai <baihaowen@meizu.com>
Cc:     Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
        Leon Romanovsky <leon@kernel.org>, linux-rdma@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <1652751208-23211-1-git-send-email-baihaowen@meizu.com>
 <20220517121646.GE63055@ziepe.ca>
From:   Christophe JAILLET <christophe.jaillet@wanadoo.fr>
In-Reply-To: <20220517121646.GE63055@ziepe.ca>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Le 17/05/2022 à 14:16, Jason Gunthorpe a écrit :
> On Tue, May 17, 2022 at 09:33:28AM +0800, Haowen Bai wrote:
>> container_of() will never return NULL, so remove useless code.
> 
> It is confusing here, but it can be null. 

Hi,

out of curiosity, can you elaborate how it can be NULL?

CJ

> If you want to do this then
> you have to split out the _ib_alloc_device call and check it
> seperately.
> 
> Jason
>