Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <38a7c7406f0b0c65e68679fb8399ffe3fae05cb2.camel@intel.com>
Subject: Re: [PATCH v6 5/5] x86/tdx: Add Quote generation support
From:   Kai Huang <kai.huang@intel.com>
To:     Sathyanarayanan Kuppuswamy 
        <sathyanarayanan.kuppuswamy@linux.intel.com>,
        Isaku Yamahata <isaku.yamahata@gmail.com>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
        "H . Peter Anvin" <hpa@zytor.com>,
        "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
        Tony Luck <tony.luck@intel.com>,
        Andi Kleen <ak@linux.intel.com>,
        Wander Lairson Costa <wander@redhat.com>,
        marcelo.cerri@canonical.com, tim.gardner@canonical.com,
        khalid.elmously@canonical.com, philip.cox@canonical.com,
        linux-kernel@vger.kernel.org
Date:   Tue, 17 May 2022 14:58:38 +1200
In-Reply-To: <c07c9fa1-ff6a-df8a-6050-60ade29367f3@linux.intel.com>
References: <20220512221952.3647598-1-sathyanarayanan.kuppuswamy@linux.intel.com>
         <20220512221952.3647598-6-sathyanarayanan.kuppuswamy@linux.intel.com>
         <20220513185824.GB2913259@ls.amr.corp.intel.com>
         <c07c9fa1-ff6a-df8a-6050-60ade29367f3@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Fri, 2022-05-13 at 12:29 -0700, Sathyanarayanan Kuppuswamy wrote:
> > 
> > 
> > > +
> > > +	/* Wait for attestation completion */
> > > +	ret = wait_for_completion_interruptible(&entry->compl);
> > > +	if (ret < 0) {
> > > +		/*
> > > +		 * For premature termination, since VMM still owns the
> > > +		 * shared buffer, mark the request invalid to let
> > > +		 * quote_callback_handler() handle the memory cleanup
> > > +		 * function.
> > > +		 */
> > > +		invalidate_quote_request(entry);
> > 
> > Interrupt can arrive after signal interrupt.  So invalidate_quote_request()
> > should check if the request is already processed, and return 0 or -EINTR.
> > Probably check the state always and del_list under single lock/unlock pair.
> 
> Agree. But I think we should return -EINTR for the interrupted case
> irrespective of the processed status (so no return 0).
> 
> I will hold the lock and handle the cleanup for the processed
> status.

Even if we check the buffer status in invalidate_quote_request(), there's no
guarantee the VMM won't change the buffer status _after_ we do the check, so
looks such check isn't necessary.

-- 
Thanks,
-Kai