Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Tue, 17 May 2022 08:54:29 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     cgel.zte@gmail.com
Cc:     mkalderon@marvell.com, aelior@marvell.com, leon@kernel.org,
        linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
        Minghao Chi <chi.minghao@zte.com.cn>,
        Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH] qedr: Remove unnecessary synchronize_irq() before
 free_irq()
Message-ID: <20220517115429.GA1901088@nvidia.com>
References: <20220513081647.1631141-1-chi.minghao@zte.com.cn>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220513081647.1631141-1-chi.minghao@zte.com.cn>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cGRreTdwdGJzRHFKUXhXNS82REhDOXh1dlFMQVRSaE1jRVVNUlpnS081YWRQ?=
 =?utf-8?B?MEZsc0lZUTVJUC9xRUowbzR5QlRMZnlEZDNzRFo0OTF4c25WOEt3SjltVnJs?=
 =?utf-8?B?OVR3cTNxN1dNWjJzeXFlOVRNQkxUZVZSdm95a2FYOFpuTGZLcW5xcURqRkdB?=
 =?utf-8?B?NGRYc010d2dyUVY1NUU5MkkvYnQ0MVg4a0Jpb1dTTDVYcUZGVlZPMnNDSHFs?=
 =?utf-8?B?SDdGNEdZd3NxMG5JL2dCU0dscUExUGFuYU1TakpFZk43ZldNRi9IMzA2bElD?=
 =?utf-8?B?anhzQ2xBaUFJVm1CeU1YM0lOVmcwanJ1ZVg5STBRL1ZqQnFzMFNxNDZJRGpU?=
 =?utf-8?B?R2VLNXM0QUIwT1MxdUdGRkgvQXl2ZktzenRuMEdQOXppM0JlU2xnUFhpTVZp?=
 =?utf-8?B?bDFvV1FCeWEzY1NmVnJFc282QU0wMEZzL1hMYVRUak4zdHk4ekhNckNOanlN?=
 =?utf-8?B?bFNnTTB2ZlErRU5laTltdHdhbEFXblJzT2szbSs1bGtDNEI3OU9lWkRYeG42?=
 =?utf-8?B?ZFc1R1RvNXpTSE8vcHlhN2EzdmJINzQrblgxN09ndmlNZThWWXVhY0xRbG1K?=
 =?utf-8?B?TnM0QUYvbDJibUVOUXJFT0RKNzdHcElQQXo2eFZpTVNBZEk2cTRucjFJbm42?=
 =?utf-8?B?SzhwRFJremMxaFVmT3cwVlJBVXZKL2x0SmhXQWtUNXp1NDJ4YnNsZUR6SFRw?=
 =?utf-8?B?RDRKaDVlR1lzY2E2S0lMcW5HUDIxMEVxanYrY0xTUnEwbDdPdXB1Qm1WOTNP?=
 =?utf-8?B?RVQzT01ycmFTdmhoTU9iNThrT0NDb05mYlkraEJmWCtGZzNTTjNaTzJ6OUVl?=
 =?utf-8?B?aHduNTdFVjJ4anJ3OTZEclhJSUZPMnUrVTNqT2x2MERRcm03VHJLalhrQmZp?=
 =?utf-8?B?cXpKSFhvS3VxMWJCRUdEc1VhQ2k3bktYZFI4aWZVeSsvZEgxaG11MDBWR29C?=
 =?utf-8?B?Y2xkeG5OeGVLS09tY3BEVHdSbkNjY1pyLzdITTVXZHRRZlN4YS9FVkJMcXhN?=
 =?utf-8?B?eURFemhQb05zcVludlBSM24yL0h4VHF2ZGMwU0JMdlErVTBSdkIwRkljcGhU?=
 =?utf-8?B?amlPNE5HZ1RKNHdPUHJQb3lKbHJab1VSSGZYWXNwMGFqVmlRQkdRZEtmR25r?=
 =?utf-8?B?RDJYamMxaGFHakcxb0MwT052a1dtQnNYdlZSOXFsT0NmSVRIQWxUN3JzL2Nm?=
 =?utf-8?B?UmcrRVJ5bmVIYVQ3WGhja3NJZFJReHhrSy9ML2I2dmlQTTNibi9mQ1pydmZN?=
 =?utf-8?B?TXV6ZmpobW8yY1Z0dnFpVkFIcDk5NE5aUXBabzB5Z1dHakZ0c1lOckQxZEY3?=
 =?utf-8?B?WmFTcnhESFpUSFVIR0pTNlhwdW5EVGtBTFNHYjRLbFRRQVJuRmxGNUlxaTB3?=
 =?utf-8?B?MmN3V0JpK0RCY3hjdGgwN1VDWVoydjUrZnYxZlZ5YzhaNEdJN1RZKzFXNGMy?=
 =?utf-8?B?KzJsQzV3d2ROckNYaVJCNGppbmZhTkNkcEwxZzlBdXBhQjA5NEFwSUJuZWtu?=
 =?utf-8?B?ZVZBblkrczRyVGxtOWZpU0t1TzZGdUlFVVJWVU55UEZvR1RIK01LbTlIZXpS?=
 =?utf-8?B?ak9XOEpLZFplL0YzOS9YTW1iUi9tZytIandSRUZ0UFNrUWRGTzBkbWJ4TjNH?=
 =?utf-8?B?V0xOMUU5bDFyWnRuaFptZEFlWndUb1dreHlDekFNWFltWUJUdHRVa25QcW1r?=
 =?utf-8?B?dWxMVWlOaEEvaTFSdG53K1RvbmRqWlU4K1g5WGxseGc1MC9kaFVWMWhkT0VN?=
 =?utf-8?B?RlB2ZFNsa2JIbnlRTmU2TGxaT2pBRFhCMFF5WHlQdWt0WHV1UEhPRzNkUHRy?=
 =?utf-8?B?VXBuY2p3THhVMDY5SVdlNmlOcXQzaTJwT0ZxTk5uaFg2OUtwL0tmaDdTKzlV?=
 =?utf-8?B?aGdVSGZnNGRCSUdNUEljcHV1ZVp5eEhjK1ZpRllsVDBiSjFMcGp2N29MQ0lI?=
 =?utf-8?B?c0tvZWJhbXNPZ1FZRTJMNTZEZldHREhJd01qS3VDWkw2Qk0wcy9vaHpiejR0?=
 =?utf-8?B?UGI0SFR6THAycFU0UUR1L01XNzdSSUlHU1FuNENRN0JBcHI3ekxyVGlKZXE3?=
 =?utf-8?B?dmNyMkh2SDJMSTArZzRUUXVXOFVQUzNkZHlTWWdiSEdmSG8zMWdJTHZTM3dT?=
 =?utf-8?B?NnQ3ZHJaR2E2eVhZck0zbWZFRmtXd0hTNlJiM1kzK0RXNlFMSHQ3cXJkeWEy?=
 =?utf-8?B?bEY2STR5aHpiTU9nWXRmQ1dWajNsNldLYTVhSTRrWEtrZUh1dFdDd0ZjNEti?=
 =?utf-8?B?RXJ6Yjg5Z3Z2anhVV25JYXYrQzhCZWFPQ2ZGQ3pBM05sZ1hXVTVVa3dOeTFQ?=
 =?utf-8?B?UjZsQjBNK25hMzRjN3oxemhDR21MUkljTTBBeW1TaGtNYXRNQjErQT09?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4853df3d-b461-4181-450e-08da37fc0057
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2022 11:54:30.5695
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WWPrlKdEzrV0yVIv27wqelEkVZeds7nWAV2687GR8uw7G6rNPyhs0mFxO3oi6fL+
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3598
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, May 13, 2022 at 08:16:47AM +0000, cgel.zte@gmail.com wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
> 
> Calling synchronize_irq() right before free_irq() is quite useless. On one
> hand the IRQ can easily fire again before free_irq() is entered, on the
> other hand free_irq() itself calls synchronize_irq() internally (in a race
> condition free way), before any state associated with the IRQ is freed.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> Acked-by: Michal Kalderon <michal.kalderon@marvell.com>
> ---
>  drivers/infiniband/hw/qedr/main.c | 1 -
>  1 file changed, 1 deletion(-)

Applied to for-next, thanks

Jason