Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <573fae0d-c9ab-98b0-c6f1-5b0d4e52dd01@amd.com>
Date:   Tue, 17 May 2022 10:03:15 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context
Content-Language: en-US
To:     Dmitry Osipenko <dmitry.osipenko@collabora.com>,
        Erico Nunes <nunes.erico@gmail.com>,
        Steven Price <steven.price@arm.com>
Cc:     David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
        Tomeu Vizoso <tomeu.vizoso@collabora.com>,
        Rob Herring <robh@kernel.org>,
        Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>,
        Rob Clark <robdclark@gmail.com>,
        Dmitry Osipenko <digetx@gmail.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        dri-devel <dri-devel@lists.freedesktop.org>
References: <20220411221536.283312-1-dmitry.osipenko@collabora.com>
 <a78343c8-2a6d-b223-4219-6b6b0a4fcb1f@arm.com>
 <CAK4VdL2hCEoshWZbCh5mkHuS6wYMiPFR3v4MWTnrEKM9zyv6Mw@mail.gmail.com>
 <ef88ec2c-77b5-fa0d-49d1-fdd2451713b7@collabora.com>
From:   Andrey Grodzovsky <andrey.grodzovsky@amd.com>
In-Reply-To: <ef88ec2c-77b5-fa0d-49d1-fdd2451713b7@collabora.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YTczTVNTaTFSelBYeFpEbWdwWTFkOHJ1eTZjU1VpM2d0aURmUkt5NGIyMGl2?=
 =?utf-8?B?ZE55YkhEbEdGcmRXZktCd1JMUWJLMXlNaGFITUp1Mm9mc2pabUdtV3dldEJN?=
 =?utf-8?B?NlorTWk1cjkvMm1pQVJyVGpVaUVEY0UxbHpvMW1jTEVaTlNoUzFLY2lGNUZG?=
 =?utf-8?B?S2VKZ0gwVCtGbW5raG1say9tdkpRVmFrM0NDMHpWbEY5K2NFVFVNbmgvT1Yr?=
 =?utf-8?B?aHJGVWM2djdmdW8wdUIrazM1cWdIbUllN2RWSHkvMWNHUytnNU1OTVZ0MkdT?=
 =?utf-8?B?Y3A3WEg0dzlBcSttWDZLNXhEanVrSkxLRHl0V0FTK0oxNU1QMDh6RlltR0NS?=
 =?utf-8?B?WkdIeVpMQThYbGlpWHdSWmMrZlFod3NhanRXbnoxdnRQZ1g3RHdaeTFCT1hi?=
 =?utf-8?B?MUw0VVpuSnN6ZWY1K3NubFhZcUg3ODNZWVo4RU5CMkxWaUFoelB1QzlYSjR1?=
 =?utf-8?B?b05kZjhISFlSZUlzS20yMlRlUm1nbStPSXFBcXFJWitiNERGenhhMDlEK0sw?=
 =?utf-8?B?L2N5bER2Qmsva0JSSkYrRWZqUXFVako2bUR6RHNhcUpESTlVdUxRbWxqUWZO?=
 =?utf-8?B?Nml1dUxmcHpHS3ljendIVGd2OVE0MDgxRkFGaHRaS3orK3pRT2pqeUE1UU1U?=
 =?utf-8?B?a24vMS85bTdXcGlFbnFYYXlSK0NOaUQzd05MU1I5R080WVdCK3hXZHlrdHhK?=
 =?utf-8?B?cG5sTmNUT1FCSlRrdjYycGZIeFdORVgxT3lzOXZXYlkxNWM4ME1sTG1EaHZa?=
 =?utf-8?B?cXZHZElQUGFvYVlQMkJ6ckVHcmdjYnYxa1pQTWRJTTAvMk9wZHlvbjRkdmNN?=
 =?utf-8?B?RVdrU2ZzazM5WU8zSi9udzJydFp5YmNuLzEyakZHTjB5Z2lqeGIwUWx6SUQx?=
 =?utf-8?B?dFhpUEF4YTlnNndqQVg4VVBXUTFVOVJyb3NxSzJuQnY3eU1tMUZLalBGa0Rq?=
 =?utf-8?B?RWJJTi9oZm05RmZwK09SNDVhQWlvY3pvOEhvLzNBNDg0bmowU2dIQmQvUDlZ?=
 =?utf-8?B?T3dObXZxQ1FTL0RWM3U3UHVpMXVCbmU1eWZFU1A2Yms5S09uSGh2emxoL0l5?=
 =?utf-8?B?ZGpPcGJwWDZqZlUxRkpjK2ZIUTNXZkFndlFKREZ6TEV4bitiOUpwNTJoM2E5?=
 =?utf-8?B?WnVmTGN5cU55UGRVcDI4S0cwYzJnaWxrcTdyYTlRSzBXa2dnOGhVNjFqRnJi?=
 =?utf-8?B?K1BoSExZSEFISDBDa1ZRaVZVZkJMYjFyS29iUm9sSVRZNzZWSmNLU29RMHJR?=
 =?utf-8?B?TVRRaWNFZkhDRTQ4Mmg5QkJsSmgxT2ZHMlo2dCtuYUNuVkFQRHE0MGZSNmMz?=
 =?utf-8?B?NWdkTCtRTGt2U1J4NmEwdENsTmRScFQxc3ZzY3NKTURiTDc1OFVSV2VCdTZX?=
 =?utf-8?B?VkhnL3ZyWGZVTFJGUVlCSmxiSitkTnJrRFZwd21Pc2FHL0NITkFKd1h3bzFB?=
 =?utf-8?B?MC9KQmRNY3RCYzRUSGMxTlV6bzhJekZVVUNrYXVmbitFNTZIbmkvMm9HQk9Z?=
 =?utf-8?B?c0VFWnNsSzE2WkVhVWVZTzJTTnhiSDl4VTUwbnZNWExVS01kZzB4Z3hCL2Ux?=
 =?utf-8?B?RG9NRWxvWVI0NGVlQ1ZtdHUyc0JzcFE5cGFjd0V1OWVSSlZGV1dPMTJHSkd5?=
 =?utf-8?B?eXZFTm4rOXhnMmR3UGx0L0JyWlNkUkp2MmpmTTZQOStjbTQ5bzhnSmVoQmMw?=
 =?utf-8?B?RldRczUweVJxb0M0ZkpIWFBrb245bjRFdTZKcWROMTdwcDNUaWZRdWpUVmRM?=
 =?utf-8?B?dE5JOHhqd1pFZzZnbkVBeTc0SzhMNW5kUHc2Vko4c0xZUFlDckRLdkNmc1FF?=
 =?utf-8?B?cFFGaUJFTGxpN3Y0aDNZY29UN3RFRS9SQmNHSEpqUGhPSGZDaEQ5dHdvMTVm?=
 =?utf-8?B?eWllV0pqWUxmSmlXVnBKYVMwWjZ1MzZicjJ2VmFTaStPV0tJZDh1ekN4dnEw?=
 =?utf-8?B?QUt4Q1Nhb3g0MlhBQktQTHl6eFBBclNIZ1dUTE50TG9ySmdDdzJEbXFKdkZr?=
 =?utf-8?B?cGgwa3hjanJHMXNwdDVhUWlKREdidlVkOUt1TDBSaEN4WmJaa2dwNGZ0WVZF?=
 =?utf-8?B?WkR0V2lVLzVBSHhyM1FxbzR5N1RPWkRiOHg4akhoWE9mWm90VnRkV3BqTE1X?=
 =?utf-8?B?UFlGTlA0dkhDN2d2ZW9xRTJLalZRalNlTVZsTGpDTThNWXlVNlFIcHZmN2Vn?=
 =?utf-8?B?dVluTURmeTQ1SmVvUVdXK0hGWVB1VmFEckRNOWgzQ3FmTUNtNytsV0dNWFA0?=
 =?utf-8?B?OHMwcFAzd25Vcy9yKys4NmdaVmtJU3lDa0VFNjZ1eGs4c3hUVVlsS1QvVUFH?=
 =?utf-8?B?Y1g1c2pYOXc0elV4d2xUY3VjUGdVRWZTMGxBYWx0Z2RXTk10WEUrcHlNODRI?=
 =?utf-8?Q?7MpUc8qkmEDkfMeVVFZEkwZ8yhd01+5QbGnoMlMrL3bPC?=
X-MS-Exchange-AntiSpam-MessageData-1: CVDXNtgCPjotlg==
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 69ca42f7-7fff-43a1-e603-08da380dfe18
X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB1947.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2022 14:03:17.7777
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +36K3x3Oip/vHCuAh8fCByYD+WcPJwGzm7GRBFwqcIG4vBnh+QTsqFF+AiWwsfFtgPVEIiAdgpIp1R6UZXjemQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6655
X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Let me push it into drm-misc-next.

Andrey

On 2022-05-17 05:03, Dmitry Osipenko wrote:

> On 5/17/22 10:40, Erico Nunes wrote:
>> On Wed, Apr 13, 2022 at 12:05 PM Steven Price <steven.price@arm.com> wrote:
>>> On 11/04/2022 23:15, Dmitry Osipenko wrote:
>>>> Interrupt context can't sleep. Drivers like Panfrost and MSM are taking
>>>> mutex when job is released, and thus, that code can sleep. This results
>>>> into "BUG: scheduling while atomic" if locks are contented while job is
>>>> freed. There is no good reason for releasing scheduler's jobs in IRQ
>>>> context, hence use normal context to fix the trouble.
>>>>
>>>> Cc: stable@vger.kernel.org
>>>> Fixes: 542cff7893a3 ("drm/sched: Avoid lockdep spalt on killing a processes")
>>>> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
>>> Reviewed-by: Steven Price <steven.price@arm.com>
>> Is there something blocking this patch?
>> Mesa CI is still hitting the issue and I have been waiting for it to
>> be applied/backported to update CI with it.
>> Thanks
> If this patch won't be picked up anytime soon, then I'll include it into
> my "memory shrinker" patchset together with the rest of the fixes, so it
> won't get lost.
>