Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <9700f700-a426-31b8-9bb2-20d8bc7f3f01@oracle.com>
Date:   Tue, 17 May 2022 19:33:35 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.9.0
Subject: Re: [PATCH v2] scsi: target: fixup incorrect use of 'cpumask_t'
Content-Language: en-US
To:     mingzhe.zou@easystack.cn, torvalds@linux-foundation.org,
        zgrieee@gmail.com, martin.petersen@oracle.com
Cc:     linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
        target-devel@vger.kernel.org, dongsheng.yang@easystack.cn,
        zoumingzhe@qq.com
References: <20220516054721.1548-1-mingzhe.zou@easystack.cn>
From:   michael.christie@oracle.com
In-Reply-To: <20220516054721.1548-1-mingzhe.zou@easystack.cn>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MDZNSnc2S3FyTC9QZ0tJMFRwS1R5N2pncEpXVnV4RjZiV2dnbFkyTUlvaTlr?=
 =?utf-8?B?TEVQejh1c0Y1VTE2K2hJR1VYZVMrd2psNEpTMjNJL0ZJLzRyWU1lbTNuWU9I?=
 =?utf-8?B?eHh3ME5MVGsxOGRrTEZ5akZhMitCUEhzWWxIK1lUeDI0TzlvS1FTQzczdXBw?=
 =?utf-8?B?M0gvc3d5WkY3VnRjMm9pYzNrVDlrRXdadU9mSG9iZWpDRWtPNFZwL002cS96?=
 =?utf-8?B?YlZDNXFXbE9XcFVESlZYQktabjhScExTaVRwSWJhZ2I5ODBvdEhOM2Y0SjVy?=
 =?utf-8?B?WFBGRTV6WmdMaUlkcWJIWFltUVpvSVJhUmlHS0NMaWVyOTkvdXNPOEc2V1N2?=
 =?utf-8?B?YU42RHFQdEF3Mk5DR2hLMjdoYkFTaUtSak1IakZqcU5HTkQxZVcrOTR1UVNK?=
 =?utf-8?B?SWZlZVZmMFNONndnektKaTRLQWV4bCtlUk90UzBpRllRQ0RtL0lPM3RKbzgx?=
 =?utf-8?B?YmNDOEhwSmNtZkdxTllsKzkzVy9naldOaXRzVTh3QTltajZxTDRYTHZUZVhz?=
 =?utf-8?B?L3JQeXlIeEVGcnkvZFdadDZ3NUZ5YkNBZUIrRWxGMXpRbVZLL1R6bVdIMTdP?=
 =?utf-8?B?M2NVZll0bkVvei8xak43Tk1uMDFQSm13WDJvZEZiT21jbURSdW8rWEl3cFdY?=
 =?utf-8?B?VUgwRzVtalk5YWhLSHJ6eGZneURRcEloWGg1eCs4MmZJZVNQWnBzVzkvT3NP?=
 =?utf-8?B?VHRrcnVVT3JyZkdwU0Jibk80UThpL3M2WmdRUzBDVG0rMHNwMVJxTG9uWjBM?=
 =?utf-8?B?Q1RKRThneGozckNGUUJUd0FsYmFMcHN5bmVUUnJDbVdCdUFVOTdXODNHa3Q1?=
 =?utf-8?B?aUowQXIrSENveG9VenNzWVNKeWZWd2dpWEh0SDN4RkluMUlSenVuWVozZTNF?=
 =?utf-8?B?WG84TjJmTHFEamZRN01VVnR6MU1xNFdXaVZtS3o3MUZpUmdpdnF3SmlrSnMw?=
 =?utf-8?B?V2lybkRDdXVqeE5hN2k0UGRid21SaFp1R240TkF1ZzJVTVp3bDluSk90UHQ1?=
 =?utf-8?B?WDEzTUpYTlphTSt0WDdpbHZBbE90UCtUd25ESjhaMG1PRENxOWxoTVo3QTc4?=
 =?utf-8?B?R0xodmVSNWdVWXpsU1plR0NndUp1Nk1keTc5eTQ4eStTeTZnNFFyKzZGNWJD?=
 =?utf-8?B?REh4RGt5YUx0elVWd3F1K1NwcXo1c2p2czJxNU1OTmZMdHBXblFuY1Z4dWpj?=
 =?utf-8?B?bDFGdE04T2dRZU5ZYU1xYzd1RDVRc0VLM01zME9PZ2lEcHFxc25GVVM3UGxp?=
 =?utf-8?B?bEM2MExpbGl0Vlh1WFZIc0ZqTzlkbGltbE5EakFPMzBBeTV2Q1h1L0VkbGFF?=
 =?utf-8?B?cmQrbmNZS0ZoZXZNa2ZlUUsvUzB3dlZwYnJGcG00TUJTK3d5V3gwdWF4elUr?=
 =?utf-8?B?Zk5TK1B6bWdlcG1jYnB4dGdMRGc1SlF5enA1OVBxKys4aU4yb3ZKak9mSWdZ?=
 =?utf-8?B?cHdPWFpmNXp5dzJMVTlTaGFzQ3BLSmp2UUhPaXFYTzVCUUViYWN1Zm5QVEFm?=
 =?utf-8?B?WWNrbWZpc21RcDQrUGM4WFkyMXpGZW9BbkRab1U5c1RzUzViY1NOVnM4TERY?=
 =?utf-8?B?VWxkcWZ3ZHRPT1BTbkluR1BKSnF3dDNzTmdsSnZkcXFLWWZxcXJWMCswemcw?=
 =?utf-8?B?RFNJY2o4UXpWK3pHQSt0TlNxakMyTnBWVksxVE9iYi9CdmducnNMR3U3ZnIw?=
 =?utf-8?B?eTEyZCsvZ1JTNmF4NlNnVVBsR2s1a3Ywb29QYm04K0VPbmZCalJDSzJxVjVj?=
 =?utf-8?B?aXRYRks5SzllMkUvUndnTVNEYzFMWXhuT3B2SWpPQ2d2SVhyZ3NWTlo1ZWsv?=
 =?utf-8?B?MmwxWE1rSVB3cFRCQTl6T0VCY0lyOEY3eFQyTkRxOGQ4UjlQMitIeTNua1ox?=
 =?utf-8?B?c29JNHRqUTFrTkdoU0lwSzlqK3VPU05rSXQ0azh3ZFVMTXNjOUlPa0JTU3dx?=
 =?utf-8?B?bk5iQmZXS1BQaUpxd0ppM3l1U2dES0hFTUhzNXY1ckhFbWxmeDVCMm9tR0ZT?=
 =?utf-8?B?T1FCWFZnZHR3TDRwTzFubVJLMnJVYVJVTXBVZ1lEby8rajRoYXdzWkRBVk9s?=
 =?utf-8?B?QVQyV21TdnNVckwwSDJqR2hXbTFxSHBsYll6RXZHcmdBNUgzZDFtSkVMLzhw?=
 =?utf-8?B?d3ZOUVo0TVhFQnhiRzRWU1RqK0ZJcEsvWkVNYjRIc3cvbCt5QmZwY2lkWDM1?=
 =?utf-8?B?ZEN5OHAvTFcwc1R0MDJYS01qTTlURnRDTU91REZ0UUcxOU1TQk1LMFo2RlNi?=
 =?utf-8?B?QXY2Yk9hSHBNaXJORkhFVExOK1kvMXo2dG8zcy8yRUdXUXNkOVI4K2Q3YkhM?=
 =?utf-8?B?NjBYODRRQnVJYTQySXJYaHA2N0xHOGdlbE8xYk9OOGtab050THNETnFIS0NK?=
 =?utf-8?Q?AIfwp2o+3Z6zynjM=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9d1aee06-8b94-480e-5c68-08da38660c2c
X-MS-Exchange-CrossTenant-AuthSource: DM5PR10MB1466.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2022 00:33:37.0118
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7AHc1J6+n5iRBTl18u5Aj2fkya4Kgd7DckwSJU3CzVjscy0oAiJZKP75OF2uWwX6ulrdJ9Jiu9+ixCP8iKfvOHYjmrbgd7sV6D2mTjYtyAg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4657
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.874
 definitions=2022-05-17_03:2022-05-17,2022-05-17 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0
 mlxlogscore=999 spamscore=0 suspectscore=0 malwarescore=0 mlxscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2205180001
X-Proofpoint-GUID: Bas0wXOPN_XiODgqtk88IJKy9I2obPyG
X-Proofpoint-ORIG-GUID: Bas0wXOPN_XiODgqtk88IJKy9I2obPyG
X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 5/16/22 12:47 AM, mingzhe.zou@easystack.cn wrote:
> From: mingzhe <mingzhe.zou@easystack.cn>
> 
> In commit d72d827f2f26, I used 'cpumask_t' incorrectly.
> ```
> void iscsit_thread_get_cpumask(struct iscsi_conn *conn)
> {
>         int ord, cpu;
>         cpumask_t conn_allowed_cpumask;
>         ......
> }
> 
> static ssize_t lio_target_wwn_cpus_allowed_list_store(
>                struct config_item *item, const char *page, size_t count)
> {
>         int ret;
>         char *orig;
>         cpumask_t new_allowed_cpumask;
>         ......
> }
> ```
> 
> So, that the correct pattern should be as follows:
> ```
> cpumask_var_t mask;
> 
> if (!zalloc_cpumask_var(&mask, GFP_KERNEL))
>         return -ENOMEM;
> ... use 'mask' here as a  ...
> free_cpumask_var(mask);
> ```
> 
> Fixes: d72d827f2f26 ("scsi: target: Add iscsi/cpus_allowed_list in configfs")
> Reported-by: Test Bot <zgrieee@gmail.com>
> Signed-off-by: mingzhe <mingzhe.zou@easystack.cn>
>

Reviewed-by: Mike Christie <michael.christie@oracle.com>